Merge pull request ClickHouse#80207 from ClickHouse/yarik/fix-comparison-conversion

Fix numeric comparison in keyCondition

Author: yariks5s

src/Storages/MergeTree/KeyCondition.cpp

@@ -58,7 +58,6 @@ namespace Setting
 namespace ErrorCodes
 {
 extern const int LOGICAL_ERROR;
-extern const int BAD_TYPE_OF_FIELD;
 }
 
 /// Returns the prefix of like_pattern before the first wildcard, e.g. 'Hello\_World% ...' --> 'Hello\_World'
@@ -1982,19 +1981,6 @@ KeyCondition::RPNElement::RPNElement(Function function_, size_t key_column_, con
 {
 }
 
-static void castValueToType(const DataTypePtr & desired_type, Field & src_value, const DataTypePtr & src_type, const String & node_column_name)
-{
-    try
-    {
-        src_value = convertFieldToType(src_value, *desired_type, src_type.get());
-    }
-    catch (...)
-    {
-        throw Exception(ErrorCodes::BAD_TYPE_OF_FIELD, "Key expression contains comparison between inconvertible types: "
-            "{} and {} inside {}", desired_type->getName(), src_type->getName(), node_column_name);
-    }
-}
-
 
 bool KeyCondition::extractAtomFromTree(const RPNBuilderTreeNode & node, RPNElement & out)
 {
@@ -2254,7 +2240,12 @@ bool KeyCondition::extractAtomFromTree(const RPNBuilderTreeNode & node, RPNEleme
 
                     if (!const_type->equals(*common_type))
                     {
-                        castValueToType(common_type, const_value, const_type, node.getColumnName());
+                        // Replace direct call that throws exception with try version
+                        Field converted = tryConvertFieldToType(const_value, *common_type, const_type.get(), {});
+                        if (converted.isNull())
+                            return false;
+
+                        const_value = converted;
 
                         // Need to set is_constant_transformed unless we're doing exact conversion
                         if (!key_expr_type_not_null->equals(*common_type))

tests/queries/0_stateless/03516_comparison_pk_bug.reference

@@ -0,0 +1,2 @@
+1
+0

tests/queries/0_stateless/03516_comparison_pk_bug.sql

@@ -0,0 +1,7 @@
+SELECT 1 FROM numbers(1) WHERE toIntervalHour(number) = 0;
+
+CREATE TABLE t1 (c0 Decimal(18,0)) ENGINE = MergeTree() ORDER BY (c0);
+INSERT INTO TABLE t1(c0) VALUES (1);
+
+SELECT c0 = 6812671276462221925::Int64 FROM t1;
+SELECT 1 FROM t1 WHERE c0 = 6812671276462221925::Int64;