Skip to content

Commit deb5bba

Browse files
committed
add counters for WriteBufferFromHTTP
1 parent 56b84ad commit deb5bba

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

src/Common/ProfileEvents.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -985,6 +985,9 @@ The server successfully detected this situation and will download merged part fr
985985
M(ReadWriteBufferFromHTTPRequestsSent, "Number of HTTP requests sent by ReadWriteBufferFromHTTP", ValueType::Number) \
986986
M(ReadWriteBufferFromHTTPBytes, "Total size of payload bytes received and sent by ReadWriteBufferFromHTTP. Doesn't include HTTP headers.", ValueType::Bytes) \
987987
\
988+
M(WriteBufferFromHTTPRequestsSent, "Number of HTTP requests sent by WriteBufferFromHTTP", ValueType::Number) \
989+
M(WriteBufferFromHTTPBytes, "Total size of payload bytes received and sent by WriteBufferFromHTTP. Doesn't include HTTP headers.", ValueType::Bytes) \
990+
\
988991
M(ConcurrencyControlSlotsGranted, "Number of CPU slot granted according to guarantee of 1 thread per query and for queries with setting 'use_concurrency_control' = 0", ValueType::Number) \
989992
M(ConcurrencyControlSlotsDelayed, "Number of CPU slot not granted initially and required to wait for a free CPU slot", ValueType::Number) \
990993
M(ConcurrencyControlSlotsAcquired, "Total number of CPU slot acquired", ValueType::Number) \

src/IO/ReadWriteBufferFromHTTP.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
#include "ReadWriteBufferFromHTTP.h"
2-
#include <sstream>
3-
#include <string_view>
42

53
#include <IO/HTTPCommon.h>
64
#include <Common/NetException.h>

src/IO/WriteBufferFromHTTP.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@
55
#include <Interpreters/Context.h>
66

77

8+
namespace ProfileEvents
9+
{
10+
extern const Event WriteBufferFromHTTPRequestsSent;
11+
extern const Event WriteBufferFromHTTPBytes;
12+
}
13+
814
namespace DB
915
{
1016

@@ -39,9 +45,16 @@ WriteBufferFromHTTP::WriteBufferFromHTTP(
3945

4046
LOG_TRACE((getLogger("WriteBufferToHTTP")), "Sending request to {}", uri.toString());
4147

48+
ProfileEvents::increment(ProfileEvents::WriteBufferFromHTTPRequestsSent);
4249
ostr = &session->sendRequest(request);
4350
}
4451

52+
void WriteBufferFromHTTP::nextImpl()
53+
{
54+
ProfileEvents::increment(ProfileEvents::WriteBufferFromHTTPBytes, offset());
55+
WriteBufferFromOStream::nextImpl();
56+
}
57+
4558
void WriteBufferFromHTTP::finalizeImpl()
4659
{
4760
// Make sure the content in the buffer has been flushed

src/IO/WriteBufferFromHTTP.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ class WriteBufferFromHTTP : public WriteBufferFromOStream
2929
size_t buffer_size_ = DBMS_DEFAULT_BUFFER_SIZE,
3030
ProxyConfiguration proxy_configuration = {});
3131

32+
// Counts the counter WriteBufferFromHTTPBytes
33+
void nextImpl() override;
34+
3235
/// Receives response from the server after sending all data.
3336
void finalizeImpl() override;
3437

0 commit comments

Comments
 (0)