Merge pull request ClickHouse#80236 from ClickHouse/no-sentry

Remove Sentry

Author: alexey-milovidov

.github/ISSUE_TEMPLATE/85_bug-report.yaml

@@ -38,9 +38,9 @@ body:
         > Change "enabled" to true in "send_crash_reports" section in `config.xml`:
         ```xml
         <send_crash_reports>
-                <!-- Changing <enabled> to true allows sending crash reports to -->
-                <!-- the ClickHouse core developers team via Sentry https://sentry.io -->
-                <enabled>false</enabled>
+            <!-- Changing <enabled> to true allows sending crash reports to -->
+            <!-- the ClickHouse core developers team. -->
+            <enabled>true</enabled>
         </send_crash_reports>
         ```
         -----

.gitmodules

@@ -137,9 +137,6 @@
 [submodule "contrib/fmtlib"]
 	path = contrib/fmtlib
 	url = https://github.com/fmtlib/fmt
-[submodule "contrib/sentry-native"]
-	path = contrib/sentry-native
-	url = https://github.com/ClickHouse/sentry-native
 [submodule "contrib/krb5"]
 	path = contrib/krb5
 	url = https://github.com/ClickHouse/krb5

ci/docker/fasttest/Dockerfile

@@ -14,6 +14,7 @@ RUN apt-get update \
         apt-utils \
         ca-certificates \
         curl \
+        netcat-openbsd \
         gnupg \
         lsb-release \
         wget \

contrib/CMakeLists.txt

@@ -138,9 +138,6 @@ add_contrib (amqpcpp-cmake AMQP-CPP) # requires: libuv
 add_contrib (cassandra-cmake cassandra) # requires: libuv
 add_contrib (curl-cmake curl)
 add_contrib (azure-cmake azure) # requires: curl
-if (NOT OS_DARWIN)
-    add_contrib (sentry-native-cmake sentry-native) # requires: curl
-endif()
 add_contrib (fmtlib-cmake fmtlib)
 add_contrib (krb5-cmake krb5)
 add_contrib (cyrus-sasl-cmake cyrus-sasl) # for krb5

contrib/sentry-native

@@ -72,7 +72,6 @@ You are running a simple `docker run clickhouse/clickhouse-server` and it crashe
 ```bash
 $ docker run -it clickhouse/clickhouse-server
 ........
-2024.11.06 21:04:48.912036 [ 1 ] {} <Information> SentryWriter: Sending crash reports is disabled
 Poco::Exception. Code: 1000, e.code() = 0, System exception: cannot start thread, Stack trace (when copying this message, always include the lines below):
 
 0. Poco::ThreadImpl::startImpl(Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable>>) @ 0x00000000157c7b34

contrib/sentry-native-cmake/CMakeLists.txt

@@ -992,24 +992,17 @@ Log properties can be omitted by commenting out the property. For example, if yo
 
 ## send_crash_reports {#send_crash_reports}
 
-Settings for opt-in sending of crash reports to the ClickHouse core developers team via [Sentry](https://sentry.io).
+Settings for sending of crash reports to the ClickHouse core developers team.
 
 Enabling it, especially in pre-production environments, is highly appreciated.
 
-The server will need access to the public internet via IPv4 (at the time of writing IPv6 is not supported by Sentry) for this feature to function properly.
-
 Keys:
 
-| Key                   | Description                                                                                                                                                                                            |
-|-----------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `enabled`             | Boolean flag to enable the feature, `false` by default. Set to `true` to allow sending crash reports.                                                                                                  |
-| `send_logical_errors` | `LOGICAL_ERROR` is like an `assert`, it is a bug in ClickHouse. This boolean flag enables sending this exceptions to sentry (Default: `false`).                                                        |
-| `endpoint`            | You can override the Sentry endpoint URL for sending crash reports. It can be either a separate Sentry account or your self-hosted Sentry instance. Use the [Sentry DSN](https://docs.sentry.io/error-reporting/quickstart/?platform=native#configure-the-sdk) syntax.                  |
-| `anonymize`           | Avoid attaching the server hostname to the crash report.                                                                                                                                               |
-| `http_proxy`          | Configure HTTP proxy for sending crash reports.                                                                                                                                                        |
-| `debug`               | Sets the Sentry client into debug mode.                                                                                                                                                                |
-| `tmp_path`            | Filesystem path for temporary crash report state.                                                                                                                                                      |
-| `environment`         | An arbitrary name of an environment in which the ClickHouse server is running. It will be mentioned in each crash report. The default value is `test` or `prod` depending on the version of ClickHouse.|
+| Key                   | Description                                                                                                                          |
+|-----------------------|--------------------------------------------------------------------------------------------------------------------------------------|
+| `enabled`             | Boolean flag to enable the feature, `true` by default. Set to `false` to avoid sending crash reports.                                |
+| `send_logical_errors` | `LOGICAL_ERROR` is like an `assert`, it is a bug in ClickHouse. This boolean flag enables sending this exceptions (Default: `true`). |
+| `endpoint`            | You can override the endpoint URL for sending crash reports.                                                                         |
 
 **Recommended usage**
 

docs/en/operations/_troubleshooting.md

@@ -1691,13 +1691,12 @@
 
     <send_crash_reports>
         <!-- Setting <enabled> to true allows sending crash reports to -->
-        <!-- the ClickHouse core developers team via Sentry https://sentry.io -->
+        <!-- the ClickHouse core developers team. -->
         <!-- Doing so at least in pre-production environments is highly appreciated -->
+        <!-- The reports are anonymized -->
         <enabled>true</enabled>
         <send_logical_errors>true</send_logical_errors>
-        <!-- The reports are anonymized by default -->
-        <anonymize>true</anonymize>
-        <endpoint>https://[email protected]/5226277</endpoint>
+        <endpoint>https://crash.clickhouse.com/</endpoint>
     </send_crash_reports>
 
     <!-- Uncomment to disable ClickHouse internal DNS caching. -->

docs/en/operations/server-configuration-parameters/_server_settings_outside_source.md

@@ -931,14 +931,8 @@ query_masking_rules:
 #           response_content: config://http_server_default_response
 
 send_crash_reports:
-    # Changing <enabled> to true allows sending crash reports to
-    # the ClickHouse core developers team via Sentry https://sentry.io
-    # Doing so at least in pre-production environments is highly appreciated
-    enabled: false
-    # Change <anonymize> to true if you don't feel comfortable attaching the server hostname to the crash report
-    anonymize: false
-    # Default endpoint should be changed to different Sentry DSN only if you have
-    # some in-house engineers or hired consultants who're going to debug ClickHouse issues for you
-    endpoint: 'https://[email protected]/5226277'
-    # Uncomment to disable ClickHouse internal DNS caching.
-    # disable_internal_dns_cache: 1
+    enabled: true
+    endpoint: 'https://crash.clickhouse.com/'
+
+# Uncomment to disable ClickHouse internal DNS caching.
+# disable_internal_dns_cache: 1