Skip to content

Commit e5c8bcb

Browse files
fix issues
1 parent f4516b6 commit e5c8bcb

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

cmake/darwin/default_libs.cmake

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,18 @@ set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15)
1515
set(THREADS_PREFER_PTHREAD_FLAG ON)
1616
find_package(Threads REQUIRED)
1717

18+
if(NOT CMAKE_CROSSCOMPILING)
19+
execute_process(
20+
COMMAND xcrun --sdk macosx --show-sdk-version
21+
OUTPUT_VARIABLE OS_DARWIN_SDK_VERSION
22+
OUTPUT_STRIP_TRAILING_WHITESPACE
23+
)
24+
if(${OS_DARWIN_SDK_VERSION} MATCHES "^[0-9]+\\.[0-9]+")
25+
message(STATUS "Detected OSX SDK Version: ${OS_DARWIN_SDK_VERSION}")
26+
else ()
27+
message(WARNING "Unexpected OSX SDK Version: ${OS_DARWIN_SDK_VERSION}")
28+
endif()
29+
endif()
30+
1831
include (cmake/unwind.cmake)
19-
include (cmake/cxx.cmake)
32+
include (cmake/cxx.cmake)

contrib/postgres-cmake/CMakeLists.txt

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -80,22 +80,10 @@ if (OS_DARWIN OR OS_FREEBSD OR USE_MUSL)
8080
endif()
8181

8282
# Mac 15.4 / Xcode 16.3 started defining srtchrnul
83-
# Could be cleaned up after resolved in upstream https://www.postgresql.org/message-id/flat/385134.1743523038%40sss.pgh.pa.us
84-
if (OS_DARWIN AND NOT USE_MUSL)
85-
execute_process(
86-
COMMAND xcrun --sdk macosx --show-sdk-version
87-
OUTPUT_VARIABLE XCRUN
88-
OUTPUT_STRIP_TRAILING_WHITESPACE
89-
)
90-
91-
string(REGEX MATCH "([0-9]+)\\.([0-9]+)" _ ${XCRUN})
92-
set(SDK_VERSION_MAJOR "${CMAKE_MATCH_1}")
93-
set(SDK_VERSION_MINOR "${CMAKE_MATCH_2}")
94-
95-
message(STATUS "Detected SDK Version: ${SDK_VERSION_MAJOR}.${SDK_VERSION_MINOR}")
96-
if(SDK_VERSION_MAJOR GREATER 15 OR (SDK_VERSION_MAJOR EQUAL 15 AND SDK_VERSION_MINOR GREATER_EQUAL 4))
97-
target_compile_definitions(_libpq PRIVATE -DHAVE_STRCHRNUL)
98-
endif()
83+
# Could be cleaned up if properly resolved in upstream
84+
# https://www.postgresql.org/message-id/flat/385134.1743523038%40sss.pgh.pa.us
85+
if (OS_DARWIN AND OS_DARWIN_SDK_VERSION AND OS_DARWIN_SDK_VERSION VERSION_GREATER_EQUAL 15.4)
86+
target_compile_definitions(_libpq PRIVATE -DHAVE_STRCHRNUL)
9987
endif()
10088

10189
target_link_libraries (_libpq PRIVATE OpenSSL::SSL)

0 commit comments

Comments
 (0)