Merge pull request ClickHouse#80304 from ClickHouse/stripe-log-use-new-serialization-formats

Allow compatible types in `StripeLog` tables

Author: alexey-milovidov

src/Formats/NativeReader.cpp

@@ -233,9 +233,8 @@ Block NativeReader::read()
         {
             /// Index allows to do more checks.
             if (index_column_it->name != column.name)
-                throw Exception(ErrorCodes::INCORRECT_INDEX, "Index points to column with wrong name: corrupted index or data");
-            if (index_column_it->type != type_name)
-                throw Exception(ErrorCodes::INCORRECT_INDEX, "Index points to column with wrong type: corrupted index or data");
+                throw Exception(ErrorCodes::INCORRECT_INDEX, "Index points to a column with a wrong name ({} instead of {}): corrupted index or data", index_column_it->name, column.name);
+            /// Note: we can't compare data types as strings, compatible data types may differ in parameters.
         }
 
         /// If no rows, nothing to read.

src/Storages/StorageStripeLog.cpp

@@ -1,4 +1,3 @@
-#include <sys/stat.h>
 #include <sys/types.h>
 
 #include <optional>
@@ -24,10 +23,9 @@
 
 #include <Interpreters/Context.h>
 
-#include <Parsers/ASTLiteral.h>
 #include <Storages/StorageFactory.h>
 #include <Storages/StorageStripeLog.h>
-#include "StorageLogSettings.h"
+#include <Storages/StorageLogSettings.h>
 #include <Processors/ISource.h>
 #include <Processors/Sources/NullSource.h>
 #include <Processors/Sinks/SinkToStorage.h>

tests/queries/0_stateless/03509_stripe_log_compatible_types.reference

@@ -0,0 +1 @@
+2022-09-21 03:03:24

tests/queries/0_stateless/03509_stripe_log_compatible_types.sql

@@ -0,0 +1,14 @@
+DROP TABLE IF EXISTS test_tz;
+
+CREATE TABLE test_tz
+(
+    `dt` DateTime('UTC')
+)
+ENGINE = StripeLog;
+
+INSERT INTO test_tz VALUES ('2022-09-21 03:03:24');
+
+SELECT *
+FROM test_tz;
+
+DROP TABLE test_tz;