Merge branch 'master' into disable_enble_url_encoding

Author: shankar-iyer

README.md

@@ -47,18 +47,21 @@ Please feel free to reach out to tyler `<at>` clickhouse `<dot>` com.
 You can also peruse [ClickHouse Events](https://clickhouse.com/company/news-events) for a list of all upcoming trainings, meetups, speaking engagements, etc.
 
 Upcoming meetups
-* [Austin Meetup](https://www.meetup.com/clickhouse-austin-user-group/events/307289908) - May 13, 2025
 * [London Meetup](https://www.meetup.com/clickhouse-london-user-group/events/306047172/) - May 14, 2025
 * [Istanbul Meetup](https://www.meetup.com/clickhouse-turkiye-meetup-group/events/306978337/) - May 15, 2025
 * [Shenzhen Meetup](https://www.huodongxing.com/event/7803892350511) - May 17, 2025
+* [Belgium Meetup](https://www.meetup.com/clickhouse-belgium-user-group/events/307818346/) - May 20, 2025
 * [Seattle Meetup](https://www.meetup.com/clickhouse-seattle-user-group/events/307622716/) - May 20, 2025
 * [Tokyo Meetup](https://www.meetup.com/clickhouse-tokyo-user-group/events/307689645/) - June 5, 2025
+* [Cyprus Meetup](https://www.meetup.com/clickhouse-cyprus-user-group/events/307819236) - June 10, 2025
 * [Washington DC Meetup](https://www.meetup.com/clickhouse-dc-user-group/events/307622954/) - June 12, 2025
+* [Tel Aviv Meetup](https://www.meetup.com/clickhouse-meetup-israel/events/307820741/) - June 17, 2025
 * [Atlanta Meetup](https://www.meetup.com/clickhouse-atlanta-meetup-group/events/307627590/) - July 8, 2025
 * [New York Meetup](https://www.meetup.com/clickhouse-new-york-user-group/events/307627675/) - July 15, 2025
 
 
 Recent meetups
+* [Austin Meetup](https://www.meetup.com/clickhouse-austin-user-group/events/307289908) - May 13, 2025
 * [Denver Meetup](https://www.meetup.com/clickhouse-denver-user-group/events/306934991/) - April 23, 2025
 * [Jakarta Meetup with AWS](https://www.meetup.com/clickhouse-indonesia-user-group/events/306973747/) - April 22, 2025
 * [Kuala Lumper Meetup with CNCF](https://www.meetup.com/clickhouse-malaysia-meetup-group/events/306697678/) - April 16, 2025

ci/jobs/performance_tests.py

@@ -170,7 +170,6 @@ def run_test(
         if res != 0:
             with open(f"{results_path}/{test_name}-err.log", "w") as f:
                 f.write(err)
-            err = Shell.get_output(f"echo \"{err}\" | grep '{test_name}\t'")
         with open(f"{results_path}/{test_name}-raw.tsv", "w") as f:
             f.write(out)
         with open(f"{results_path}/wall-clock-times.tsv", "a") as f:

ci/jobs/scripts/check_style/aspell-ignore/en/aspell-dict.txt

@@ -152,6 +152,7 @@ CapContains
 CapUnion
 CapnProto
 CapnProtoEnumComparingMode
+CardSecondary
 CatBoost
 CellAreaM
 CellAreaRads
@@ -2484,6 +2485,7 @@ positionCaseInsensitiveUTF
 positionUTF
 positiveModulo
 positiveModuloOrNull
+postfilter
 postfix
 postfixes
 postgres
@@ -2501,6 +2503,7 @@ prefetched
 prefetches
 prefetching
 prefetchsize
+prefilter
 preflight
 preimage
 preloaded

ci/jobs/scripts/check_style/check-settings-style

@@ -69,7 +69,7 @@ done
 # previous releases, which is more important than consistency
 for setting in $(
       awk '{ gsub(/^.*Settings/, "", $2); print $1 " " $2}' "${SETTINGS_FILE}" | \
-      sort | uniq | awk '{ print $1 }' | uniq -d | grep -v "connect_timeout" | grep -v "max_connections"
+      sort | uniq | awk '{ print $1 }' | uniq -d | grep -v "connect_timeout" | grep -v "max_connections" | grep -v "max_block_size"
     );
 do
     echo "# Found multiple definitions of setting ${setting} with different types: "

ci/jobs/sqltest_job.py

@@ -290,9 +290,12 @@ def do():
                 command=do,
             )
         )
-        results[-1].set_files("report.html")
 
-    Result.create_from(results=results, stopwatch=stop_watch, files=[]).complete_job()
+    Result.create_from(
+        results=results,
+        stopwatch=stop_watch,
+        files=["report.html"] if results[-1].is_ok() else [],
+    ).complete_job()
 
 
 if __name__ == "__main__":

ci/praktika/info.py

@@ -113,6 +113,10 @@ def is_merge_queue_event(self):
     def is_push_event(self):
         return self.env.EVENT_TYPE == "push"
 
+    @property
+    def is_dispatch_event(self):
+        return self.env.EVENT_TYPE == "dispatch"
+
     @property
     def instance_lifecycle(self):
         return self.env.INSTANCE_LIFE_CYCLE

ci/praktika/job.py

@@ -92,7 +92,7 @@ def parametrize(
                 == len(timeout)
                 == len(provides)
                 == len(requires)
-            ), f"Parametrization lists must be of the same size [{len(parameter)}, {len(runs_on)}, {len(timeout)}, {len(provides)}, {len(requires)}]"
+            ), f"Parametrization lists for job [{self.name}] must be of the same size [{len(parameter)}, {len(runs_on)}, {len(timeout)}, {len(provides)}, {len(requires)}]"
 
             res = []
             for parameter_, runs_on_, timeout_, provides_, requires_ in zip(

ci/praktika/json.html

@@ -1257,10 +1257,6 @@
             return { data: jsonData, lastModifiedTime: newLastModifiedTime, eTag: newETag, updated: true };
         } catch (error) {
             console.error('Error loading Results:', error);
-            if (infoElement) {
-                infoElement.textContent = 'Error loading data';
-                infoElement.style.display = 'block';
-            }
             return { data: null, lastModifiedTime: null, eTag: null, updated: true };
         }
     }

ci/praktika/result.py

@@ -545,21 +545,14 @@ def copy_result_to_s3(cls, result, clean=False):
         s3_path = f"{Settings.HTML_S3_PATH}/{env.get_s3_prefix()}/{Path(result_file_path).name}"
         if clean:
             S3.delete(s3_path)
-        archive_file = Utils.compress_file(result_file_path, no_strict=True)
-        archive_type = archive_file.split(".")[-1]
-        content_encoding = ""
-        if archive_type == "gz":
+        # gzip is supported by most browsers
+        archive_file = Utils.compress_file_gz(result_file_path)
+        if archive_file:
+            assert archive_file.endswith(".gz")
             content_encoding = "gzip"
-        elif archive_type == "zst":
-            content_encoding = "zstd"
-        elif archive_type == "br":
-            content_encoding = "br"
         else:
-            if archive_type:
-                print(
-                    f"WARNING: Not supported compress codec: [{archive_type}] - skip compress"
-                )
-                archive_file = result_file_path
+            content_encoding = ""
+            archive_file = result_file_path
 
         url = S3.copy_file_to_s3(
             s3_path=s3_path,

ci/praktika/runner.py

@@ -36,7 +36,7 @@ def generate_local_run_environment(workflow, job, pr=None, sha=None):
             BRANCH="branch_name",
             SHA=sha or Shell.get_output("git rev-parse HEAD"),
             PR_NUMBER=pr or -1,
-            EVENT_TYPE="",
+            EVENT_TYPE=workflow.event,
             JOB_OUTPUT_STREAM="",
             EVENT_FILE_PATH="",
             CHANGE_URL="",
@@ -250,7 +250,8 @@ def _run(self, workflow, job, docker="", no_docker=False, param=None, test=""):
             docker = docker or f"{docker_name}:{docker_tag}"
             current_dir = os.getcwd()
             Shell.check(
-                "docker ps | grep -q praktika && docker rm -f praktika", verbose=True
+                "docker ps -a --format '{{.Names}}' | grep -q praktika && docker rm -f praktika",
+                verbose=True,
             )
             cmd = f"docker run --rm --name praktika {'--user $(id -u):$(id -g)' if not from_root else ''} -e PYTHONPATH='.:./ci' --volume ./:{current_dir} --workdir={current_dir} {' '.join(settings)} {docker} {job.command}"
         else: