Skip to content

Commit fa87f92

Browse files
Change the default stderr processing for UDFs to "log_last"
1 parent 172b9f4 commit fa87f92

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/Dictionaries/ExecutableDictionarySource.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ void registerDictionarySourceExecutable(DictionarySourceFactory & factory)
265265
.command_termination_timeout_seconds = config.getUInt64(settings_config_prefix + ".command_termination_timeout", 10),
266266
.command_read_timeout_milliseconds = config.getUInt64(settings_config_prefix + ".command_read_timeout", 10000),
267267
.command_write_timeout_milliseconds = config.getUInt64(settings_config_prefix + ".command_write_timeout", 10000),
268-
.stderr_reaction = parseExternalCommandStderrReaction(config.getString(settings_config_prefix + ".stderr_reaction", "none")),
268+
.stderr_reaction = parseExternalCommandStderrReaction(config.getString(settings_config_prefix + ".stderr_reaction", "log_last")),
269269
.check_exit_code = config.getBool(settings_config_prefix + ".check_exit_code", true),
270270
.is_executable_pool = false,
271271
.send_chunk_header = config.getBool(settings_config_prefix + ".send_chunk_header", false),

src/Dictionaries/ExecutablePoolDictionarySource.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ void registerDictionarySourceExecutablePool(DictionarySourceFactory & factory)
244244
.command_termination_timeout_seconds = config.getUInt64(settings_config_prefix + ".command_termination_timeout", 10),
245245
.command_read_timeout_milliseconds = config.getUInt64(settings_config_prefix + ".command_read_timeout", 10000),
246246
.command_write_timeout_milliseconds = config.getUInt64(settings_config_prefix + ".command_write_timeout", 10000),
247-
.stderr_reaction = parseExternalCommandStderrReaction(config.getString(settings_config_prefix + ".stderr_reaction", "none")),
247+
.stderr_reaction = parseExternalCommandStderrReaction(config.getString(settings_config_prefix + ".stderr_reaction", "log_last")),
248248
.check_exit_code = config.getBool(settings_config_prefix + ".check_exit_code", true),
249249
.pool_size = config.getUInt64(settings_config_prefix + ".pool_size", 16),
250250
.max_command_execution_time_seconds = max_command_execution_time,

src/Functions/UserDefined/ExternalUserDefinedExecutableFunctionsLoader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ ExternalLoader::LoadableMutablePtr ExternalUserDefinedExecutableFunctionsLoader:
180180
size_t command_read_timeout_milliseconds = config.getUInt64(key_in_config + ".command_read_timeout", 10000);
181181
size_t command_write_timeout_milliseconds = config.getUInt64(key_in_config + ".command_write_timeout", 10000);
182182
ExternalCommandStderrReaction stderr_reaction
183-
= parseExternalCommandStderrReaction(config.getString(key_in_config + ".stderr_reaction", "none"));
183+
= parseExternalCommandStderrReaction(config.getString(key_in_config + ".stderr_reaction", "log_last"));
184184
bool check_exit_code = config.getBool(key_in_config + ".check_exit_code", true);
185185

186186
size_t pool_size = 0;

0 commit comments

Comments
 (0)