Skip to content

Data from USA Spending includes spending before BIL #116

@travissouthard

Description

@travissouthard

Overview

A clear description of the bug.

Expected Behavior

We should not see any spending from before month 1 of the fiscal year 2021 (the start of the bill)

Actual Behavior

From #114: The data we are seeing in the map is set to { "fiscal_year" : 2021, "month" : 1 }and in the monthly.spending.json the earliest I see money in Alaska is month 12, 2016:

{
    "per_capita": 0,
    "total": 0,
    "time_period": {
        "fiscal_year": 2016,
        "month": 11
    }
},
{
    "per_capita": 0.4374303699704051,
    "total": 320000,
    "time_period": {
        "fiscal_year": 2016,
        "month": 12
    }
},

Money in Idaho starts in month 4 of 2008:

{
    "per_capita": 0,
    "total": 0,
    "time_period": {
        "fiscal_year": 2008,
        "month": 3
    }
},
{
    "per_capita": 53.97577155279746,
    "total": 96458212.19,
    "time_period": {
        "fiscal_year": 2008,
        "month": 4
    }
},

On develop it's also showing this in Idaho:

{
    "per_capita": 53.97577155279746,
    "time_period": {
        "fiscal_year": 2008,
        "month": 4
    }
},
{
    "per_capita": 170.90665833083855,
    "time_period": {
        "fiscal_year": 2008,
        "month": 5
    }
},

And in Alaska ion develop:

{
    "per_capita": 0,
    "time_period": {
        "fiscal_year": 2016,
        "month": 11
    }
},
{
    "per_capita": 0.4374303699704051,
    "time_period": {
        "fiscal_year": 2016,
        "month": 12
    }
},

Steps to Reproduce

  • Either in the src/data/monthly.spending.json or in the query data in the AnimatedArcsAndMap.tsx, look a state's results value and look through the sopending for each month until you arrive at a value
  • These should be 0 until month 1, 2021, but start much eariler as demo'd above

Additional context

@jacobtylerwalls noted in #114

The spending codes "Z" and "1" are supposed to exclusively deal with BIL spending, so we need an investigation card to see if we botched something or if the API is returning bad results (or if a rogue agency submitted bad contract data, hah). Would you mind opening the card?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions