Skip to content

moduleResolution in near-wallets should be Bundler with Vite #63

@AgustinMJ

Description

@AgustinMJ

Vite is built on top of ESBuild and Rollup, both of which use modern resolution strategies, such as package exports. When moduleResolution is set to node in tsconfig.json, TypeScript doesn't support modern resolution strategies. This doesn't affect the build process but affects developer experience. Importing a package with exports will show a TypeScript error but won't throw any error when bundling it with Vite.

I suggest changing near-wallets/tsconfig.json as follows

"moduleResolution": "ESNext",
"module": "Bundler"

I'd be glad to make a Pull Request if the maintainers agree on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions