feat: move collections away from worldserver config reload (#219)

Author: Nyeriah

src/Transmogrification.cpp

@@ -1247,6 +1247,29 @@ bool Transmogrification::IsPlusFeatureEligible(ObjectGuid const &playerGuid, uin
     return false;
 }
 
+void Transmogrification::LoadCollections()
+{
+    if (sTransmogrification->GetUseCollectionSystem())
+    {
+        LOG_INFO("module", "Loading transmog appearance collection cache....");
+        uint32 collectedAppearanceCount = 0;
+        QueryResult result = CharacterDatabase.Query("SELECT account_id, item_template_id FROM custom_unlocked_appearances");
+        if (result)
+        {
+            do
+            {
+                uint32 accountId = (*result)[0].Get<uint32>();
+                uint32 itemId = (*result)[1].Get<uint32>();
+                if (sTransmogrification->AddCollectedAppearance(accountId, itemId))
+                    collectedAppearanceCount++;
+
+            } while (result->NextRow());
+        }
+
+        LOG_INFO("module", "Loaded {} collected appearances into cache", collectedAppearanceCount);
+    }
+}
+
 bool Transmogrification::GetEnableTransmogInfo() const
 {
     return EnableTransmogInfo;

src/Transmogrification.h

@@ -149,6 +149,7 @@ class Transmogrification
 
     void LoadPlayerSets(ObjectGuid pGUID);
     void UnloadPlayerSets(ObjectGuid pGUID);
+    void LoadCollections();
 #endif
 
     bool EnableTransmogInfo;

src/cs_transmog.cpp

@@ -41,11 +41,12 @@ class transmog_commandscript : public CommandScript
 
         static ChatCommandTable transmogTable =
         {
-            { "add",       addCollectionTable                                        },
-            { "",          HandleDisableTransMogVisual,   SEC_PLAYER,    Console::No },
-            { "sync",      HandleSyncTransMogCommand,     SEC_PLAYER,    Console::No },
-            { "portable",  HandleTransmogPortableCommand, SEC_PLAYER,    Console::No },
-            { "interface", HandleInterfaceOption,         SEC_PLAYER,    Console::No }
+            { "add",       addCollectionTable                                            },
+            { "",          HandleDisableTransMogVisual,   SEC_PLAYER,        Console::No },
+            { "sync",      HandleSyncTransMogCommand,     SEC_PLAYER,        Console::No },
+            { "portable",  HandleTransmogPortableCommand, SEC_PLAYER,        Console::No },
+            { "interface", HandleInterfaceOption,         SEC_PLAYER,        Console::No },
+            { "reload",    HandleReloadTransmogConfig,    SEC_ADMINISTRATOR, Console::Yes}
         };
 
         static ChatCommandTable commandTable =
@@ -315,6 +316,15 @@ class transmog_commandscript : public CommandScript
         handler->SendSysMessage(enable ? LANG_CMD_TRANSMOG_VENDOR_INTERFACE_ENABLE : LANG_CMD_TRANSMOG_VENDOR_INTERFACE_DISABLE);
         return true;
     }
+
+    static bool HandleReloadTransmogConfig(ChatHandler* handler)
+    {
+        sTransmogrification->LoadConfig(true);
+        handler->SendSysMessage("Transmog configs reloaded.");
+        sTransmogrification->LoadCollections();
+        handler->SendSysMessage("Transmog collections reloaded.");
+        return true;
+    }
 };
 
 void AddSC_transmog_commandscript()

src/transmog_scripts.cpp

@@ -1222,26 +1222,8 @@ class WS_Transmogrification : public WorldScript
 
     void OnAfterConfigLoad(bool reload) override
     {
-        sT->LoadConfig(reload);
-        if (sT->GetUseCollectionSystem())
-        {
-            LOG_INFO("module", "Loading transmog appearance collection cache....");
-            uint32 collectedAppearanceCount = 0;
-            QueryResult result = CharacterDatabase.Query("SELECT account_id, item_template_id FROM custom_unlocked_appearances");
-            if (result)
-            {
-                do
-                {
-                    uint32 accountId = (*result)[0].Get<uint32>();
-                    uint32 itemId = (*result)[1].Get<uint32>();
-                    if (sT->AddCollectedAppearance(accountId, itemId))
-                    {
-                        collectedAppearanceCount++;
-                    }
-                } while (result->NextRow());
-            }
-            LOG_INFO("module", "Loaded {} collected appearances into cache", collectedAppearanceCount);
-        }
+        if (!reload)
+            sT->LoadCollections();
     }
 
     void OnStartup() override