TRANSMOG / SOLO-LFG

[virgo77]

Hi there,

I recently updated all my AzerothCore Installation, and all the modules I usually use, such as:

• AH-BOT
• SKIP-DK-STARTING-AREA
• TRANSMOG
• SOLO-LFG
• SOLOCRAFT

But when compiling, at the end, I got this error:

[ 99%] Building CXX object modules/CMakeFiles/modules.dir/mod-transmog/src/transmog_scripts.cpp.o
/home/acore/ACORE_MODS_TESTS/core/modules/mod-solo-lfg/src/Lfg_Solo.cpp:21:34: fatal error: only virtual member functions can be marked 'override'
   21 |     void OnLogin(Player* player) override
      |                                  ^~~~~~~~
1 error generated.
make[2]: *** [modules/CMakeFiles/modules.dir/build.make:258: modules/CMakeFiles/modules.dir/mod-solo-lfg/src/Lfg_Solo.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1063: modules/CMakeFiles/modules.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

If I modify this file "/core/modules/mod-solo-lfg/src/Lfg_Solo.cpp" at lines 21 and 30, by deleting the word "override", the compilation goes to the end.

For helping you:

1. I had to switch from my working Debian 12 / MariaDB combination (not updated since July 2024 and was working well!) for a fresh Ubuntu Server 24.04.2 and MySQL 8.4.4 in order to be consistent with the AzerothCore prerequisites ;
2. I'd 'git' the AzerothCore
3. And I'd 'git' my modules, listed above
4. Then launch a compilation
5. At 99%, the error occured

I checked the SOLO-LFG module, and it's not updated since nearly a year, though!
So, is it a fix you can do on your module, or is it a fix to apply on the SOLO-LFG module?

I remind you that if this file "/core/modules/mod-solo-lfg/src/Lfg_Solo.cpp" is modified at lines 21 and 30, by deleting the word "override", the compilation runs totally fine! But I can't tell if this has any impact on the functioning of the core, the 'Transmog' module only, the 'SOLO-LFG' module only, or on the whole package!

Hope a fix can be published, or maybe a help or answer about how I can be sure that my modifications are safe or not :)

Thanks a lot

Regards,
V.

[Helias]

to fix them you need to rename the hooks name that have been changed in this PR azerothcore/azerothcore-wotlk#21020

an example of fixing the names for mod-transmog #198

[virgo77]

Hi Helias, thanks for your reply, but I don't understand what you mean. Sorry :(
Can you explain me? Thanks a lot

[Helias]

By mistake I did not put the link of "this PR azerothcore/azerothcore-wotlk#21020 "
If you look at the file changes in this PR you'll see that the hooks name changed, so now the modules need to rename some functions names with the new names as it has been done here #198 for mod-transmog, if you update the latest version of your mod-transmog you'll receive the fix, probably the same for the other modules, if not you can edit the hooks name to fix them

[virgo77]

Hi Helias,
I've read your PR topic as you gave links on your first answer. But I still don't understand what to do as I'm not a dev.
I think I will have to change some code lines on my own, in this file: mod-solo-lfg/src/Lfg_Solo.cpp.o
But, still, what will I have to do, as it seems this module not deved sinced a year now? :(
Sorry for asking, but I need more help to understand what I will have to change :)
Thanks to you
Regards,
V.

[virgo77]

Great! All has been upgraded by your team :)
I took a look on what was changed... and I can tell I would not be able to find out the specific 'hooks' to change, as you name these :)
Thanks a lot, sincerly
Best Regards,
V.

[Helias]

Perfect, thanks for the feedback!