Apply suggestions from code review

Nyeriah · web-flow · commit 57a5f1ee22e9 · 2025-07-29T11:52:30.000-03:00
diff --git a/src/mod_zone_difficulty_handler.cpp b/src/mod_zone_difficulty_handler.cpp
@@ -1092,7 +1092,7 @@ bool ZoneDifficulty::CheckCompletionStatus(Creature* creature, Player* player, u
     {
         uint32 category;
         uint32 setting;
-        const char* bossName;
+        char const* bossName;
     };
 
     static constexpr std::array<MythicRequirement, 5> requirements
@@ -1137,7 +1137,7 @@ void ZoneDifficulty::ProcessCreatureDeath(Map* map, uint32 entry)
         if (npcId != entry)
             continue;
 
-        const auto& [setting, zoneName] = data;
+        auto const& [setting, zoneName] = data;
 
         map->DoForAllPlayers([&](Player* player)
         {

Original file line number	Diff line number	Diff line change
`@@ -1092,7 +1092,7 @@ bool ZoneDifficulty::CheckCompletionStatus(Creature* creature, Player* player, u`
`1092`	`1092`	`{`
`1093`	`1093`	`uint32 category;`
`1094`	`1094`	`uint32 setting;`
`1095`		`- const char* bossName;`
	`1095`	`+ char const* bossName;`
`1096`	`1096`	`};`
`1097`	`1097`
`1098`	`1098`	`static constexpr std::array<MythicRequirement, 5> requirements`
`@@ -1137,7 +1137,7 @@ void ZoneDifficulty::ProcessCreatureDeath(Map* map, uint32 entry)`
`1137`	`1137`	`if (npcId != entry)`
`1138`	`1138`	`continue;`
`1139`	`1139`
`1140`		`- const auto& [setting, zoneName] = data;`
	`1140`	`+ auto const& [setting, zoneName] = data;`
`1141`	`1141`
`1142`	`1142`	`map->DoForAllPlayers([&](Player* player)`
`1143`	`1143`	`{`