Fix regex expression in ansible changed_when field (#919) (#920)

* Fix regex expression in ansible changed_when field (#919)

* Proposed fix for regex.

Deploy 0.16.2 leads to the following error:

```
TASK [azimuth_cloud.azimuth_ops.azimuth_capi_operator : Apply ACL annotations to non-current templates] ***
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: re.error: missing ), unterminated subpattern at position 0
fatal: [azimuth-cl2-seed]: FAILED! => {"msg": "Unexpected failure during module execution: missing ), unterminated subpattern at position 0", "stdout": ""}
```
It seems the regex negative lookahead isn't correctly formatted, this
change fixes that

* Changes requested

* Fix other 'no change' regex patterns

---------

Co-authored-by: James Osborne <[email protected]>

Author: sd109

roles/azimuth/tasks/move-caas-cluster.yml

@@ -45,7 +45,7 @@
       --type merge
       --patch '{"spec": {"paused": true}}'
   register: kubectl_patch_pause_cluster
-  changed_when: kubectl_patch_pause_cluster.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_pause_cluster.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Copy cloud credentials secret to new namespace
   ansible.builtin.command: kubectl apply -f -
@@ -120,7 +120,7 @@
     azimuth_cluster_status_patch:
       status: "{{ cluster.status }}"
   register: kubectl_patch_cluster_status
-  changed_when: kubectl_patch_cluster_status.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_cluster_status.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Get UID of new cluster object
   ansible.builtin.command: >-
@@ -148,7 +148,7 @@
             uid: "{{ azimuth_cluster_new_uid.stdout }}"
             blockOwnerDeletion: true
   register: kubectl_patch_owner_refs
-  changed_when: kubectl_patch_owner_refs.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_owner_refs.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Resume new cluster
   ansible.builtin.command: >-
@@ -157,7 +157,7 @@
       --type merge
       --patch '{"spec": {"paused": false}}'
   register: kubectl_patch_resume_cluster
-  changed_when: kubectl_patch_resume_cluster.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_resume_cluster.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Remove old cluster resources
   ansible.builtin.command: kubectl delete -f -

roles/azimuth_capi_operator/tasks/main.yml

@@ -62,7 +62,7 @@
   loop_control:
     label: "{{ item.metadata.name }}"
   register: kubectl_patch_acl_annotations
-  changed_when: kubectl_patch_acl_annotations.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_acl_annotations.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Deprecate non-current templates
   ansible.builtin.command: >-
@@ -81,7 +81,7 @@
   loop_control:
     label: "{{ item.metadata.name }}"
   register: kubectl_patch_templates
-  changed_when: kubectl_patch_templates.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_templates.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0
 
 - name: Install Azimuth CAPI app templates
   ansible.builtin.command: kubectl apply -f -

roles/zenith/tasks/migrate-services.yml

@@ -82,4 +82,4 @@
         map("split", ":")
     }}
   register: kubectl_patch_crd_pubkey
-  changed_when: kubectl_patch_crd_pubkey.stdout_lines | select('match', '(?!.*\\(no change\\)$') | length > 0
+  changed_when: kubectl_patch_crd_pubkey.stdout_lines | select('match', '(?!.*\\(no change\\)$)') | length > 0