Handle missing endpoints in service catalogue #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Alex-Welsh what was missing, out of curiosity? |
JohnGarbutt
reviewed
May 1, 2025
Contributor
Author
Scott was just showing me a few things yesterday. We had a teardown failing, our best theory was that it's caused by a service only having internal and admin endpoints but no backend. We used the CI in the PR to build a new release to test. It didn't work so I'm now learning all about Tilt. I'll put this PR back to draft for now |
Alex-Welsh
force-pushed
the
fix-missing-interface
branch
from
92f7a98 to
d2d2160
Compare
Alex-Welsh
force-pushed
the
fix-missing-interface
branch
from
6aea449 to
d18e914
Compare
This change refactors the endpoint initialisation, swapping list comprehensions and functional loops to a more traditional sequential style. This allows for improved error handling and much better readability.
Alex-Welsh
force-pushed
the
fix-missing-interface
branch
from
d18e914 to
c977e64
Compare
sd109
previously requested changes
Jun 11, 2025
Contributor
sd109
left a comment
sd109
left a comment
There was a problem hiding this comment.
Nice work on this, just a few nit picks.
sd109
changed the title
sd109
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.