-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
optimisationrefactor to improve speed/memory performance of existing coderefactor to improve speed/memory performance of existing code
Description
What?
It would be more efficient to move logic which builds expressions out of transform and into init/fit methods (depending on whether the transformer fits).
I had a vague memory of having tried this and run into issues, but just did a quick test and these seem to have vanished (if they were ever there!), possibly newer dependency versions have resolved this for us..
Why?
speed up transform methods
How?
may vary slightly from transformer to transformer, but the general idea will be to move the setup of 'transform_expressions' into an attr set during fit/init and just utilised in transform
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
optimisationrefactor to improve speed/memory performance of existing coderefactor to improve speed/memory performance of existing code