-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
refactorrefactor of existing functionalityrefactor of existing functionalitytech-debtcleaning up legacy code, or making changes for maintainability purposescleaning up legacy code, or making changes for maintainability purposes
Milestone
Description
What?
CappingTransformer and OutofRangeNullTransformer both have options for fit/stateless (hard capping values or quantiles) which complicates code, think we should be more DOT and just split these out into e.g. FixedValueCappingTransformer, QuantileCappingTransformer.
Possibly we will need three base classes, BaseCappingTransformer and BaseFixedCappingTransformer/BaseQuantileCappingTransformer
To avoid being a breaking change, would just make these into new classes and:
- deprecate the old classes
- rework the old classes to just call the new classes
Why?
simplify capping logic
How?
read through to separate out the different logic paths and move into the new classes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
refactorrefactor of existing functionalityrefactor of existing functionalitytech-debtcleaning up legacy code, or making changes for maintainability purposescleaning up legacy code, or making changes for maintainability purposes