Skip to content

split up capping transformers #696

@liamholmes31

Description

@liamholmes31

What?
CappingTransformer and OutofRangeNullTransformer both have options for fit/stateless (hard capping values or quantiles) which complicates code, think we should be more DOT and just split these out into e.g. FixedValueCappingTransformer, QuantileCappingTransformer.

Possibly we will need three base classes, BaseCappingTransformer and BaseFixedCappingTransformer/BaseQuantileCappingTransformer

To avoid being a breaking change, would just make these into new classes and:

  • deprecate the old classes
  • rework the old classes to just call the new classes

Why?
simplify capping logic

How?
read through to separate out the different logic paths and move into the new classes

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorrefactor of existing functionalitytech-debtcleaning up legacy code, or making changes for maintainability purposes

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions