Skip to content

Commit 8e6ec1f

Browse files
committed
Merge pull request riseuplabs#85 from azul/bugfix/group_pages
fix setting owner during page creation - fix #8311
2 parents 2c5c210 + 8fe9f57 commit 8e6ec1f

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

app/controllers/pages/create_controller.rb

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,10 @@ def init_options
6868
return true
6969
end
7070

71-
#
72-
# for some routes, the owner is in the page_id.
73-
#
7471
def set_owner
75-
unless params[:owner]
76-
params[:owner] = params[:page_id]
72+
# owner from form overwrites owner from context
73+
if params[:page].present? && params[:page][:owner].present?
74+
params[:owner] = params[:page][:owner]
7775
end
7876
if params[:owner] == 'me'
7977
@owner = current_user

test/integration/page_creation_test.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ def test_sharing_with_users
1616
assert_page_users user, public_user, hidden_user
1717
end
1818

19+
def test_setting_owner
20+
login users(:red)
21+
prepare_page :discussion_page
22+
select 'rainbow', from: :page_owner
23+
click_on :create.t
24+
find('#banner_content').assert_text 'rainbow'
25+
end
26+
1927
def test_sharing_with_groups
2028
login
2129
prepare_page :discussion_page

0 commit comments

Comments
 (0)