Commit 1bbb74d
authored
[Batch] Fix error when setting null values in job CommonEnvironmentSettings property (Azure#26692)
* Add Batch keys and node passwords to sanitizers
* [Batch] Fix null CommonEnvironmentSettings values
Setting null values inside nested objects such as
CommonEnvironmentSettings throw an 'Object reference not set to an
instance of an object' error.
Allow nulls to pass through to the Batch service so that objects
which support them work properly, and those that don't throw a
more useful error message from the service itself.
* Remove primary & secondary from JSON sanitizers1 parent 48ef9be commit 1bbb74d
File tree
37 files changed
+7822
-6350
lines changed- src/Batch
- Batch.Test
- ScenarioTests
- SessionRecords
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchAccountTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchApplicationPackageTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchApplicationTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.CertificateTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeUserTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobScheduleTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.LocationTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests
- Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests
- Batch
- Models
- tools/TestFx/Recorder
37 files changed
+7822
-6350
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
| 79 | + | |
81 | 80 | | |
82 | 81 | | |
83 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | 29 | | |
31 | 30 | | |
32 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
| |||
Lines changed: 361 additions & 298 deletions
Large diffs are not rendered by default.
Lines changed: 422 additions & 350 deletions
Large diffs are not rendered by default.
Lines changed: 179 additions & 146 deletions
Large diffs are not rendered by default.
Lines changed: 12 additions & 12 deletions
Large diffs are not rendered by default.
Lines changed: 116 additions & 95 deletions
Large diffs are not rendered by default.
Lines changed: 155 additions & 125 deletions
Large diffs are not rendered by default.
Lines changed: 146 additions & 125 deletions
Large diffs are not rendered by default.
Lines changed: 98 additions & 77 deletions
Large diffs are not rendered by default.
0 commit comments