Skip to content

Commit 74cb235

Browse files
authored
Added Warning for Customers to Use Default Probe Threshold Property (Azure#19891)
* added warning * accidently removed a line of code * added a need package * changed to cmdlet preview attribute and added to changeLog.md
1 parent 3fb3a00 commit 74cb235

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

src/Network/Network/ChangeLog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@
3434
* `New-AzVpnClientConnectionConfiguration`
3535
* Added message in breaking change attribute to notify that load balancer sku default behaviour will be changed
3636
* `New-AzLoadBalancer`
37+
* Added cmdlet preview to notify customers to use defualt value or leave null for load balancer probe theshold property
38+
* `New-AzLoadBalancerProbeConfig`
39+
* `Set-AzLoadBalancerProbeConfig`
40+
* `Add-AzLoadBalancerProbeConfig`
3741

3842
## Version 5.0.0
3943
* Added a new endpoint switch `AzureArcVM` in `New-AzNetworkWatcherConnectionMonitor`

src/Network/Network/LoadBalancer/Probe/AddAzureRmLoadBalancerProbeConfigCommand.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using Microsoft.Azure.Commands.Network.Models;
1616
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1717
using Microsoft.Azure.Management.Network.Models;
18+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
1819
using System;
1920
using System.Collections;
2021
using System.Collections.Generic;
@@ -23,6 +24,7 @@
2324

2425
namespace Microsoft.Azure.Commands.Network
2526
{
27+
[CmdletPreview("Please note that the parameter -ProbeThreshold is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.")]
2628
[Cmdlet(VerbsCommon.Add, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "LoadBalancerProbeConfig", SupportsShouldProcess = true), OutputType(typeof(PSLoadBalancer))]
2729
public partial class AddAzureRmLoadBalancerProbeConfigCommand : NetworkBaseCmdlet
2830
{

src/Network/Network/LoadBalancer/Probe/NewAzureRmLoadBalancerProbeConfigCommand.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using Microsoft.Azure.Commands.Network.Models;
1616
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1717
using Microsoft.Azure.Management.Network.Models;
18+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
1819
using System;
1920
using System.Collections;
2021
using System.Collections.Generic;
@@ -23,6 +24,7 @@
2324

2425
namespace Microsoft.Azure.Commands.Network
2526
{
27+
[CmdletPreview("Please note that the parameter -ProbeThreshold is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.")]
2628
[Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "LoadBalancerProbeConfig", SupportsShouldProcess = true), OutputType(typeof(PSProbe))]
2729
public partial class NewAzureRmLoadBalancerProbeConfigCommand : NetworkBaseCmdlet
2830
{

src/Network/Network/LoadBalancer/Probe/SetAzureRmLoadBalancerProbeConfigCommand.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using Microsoft.Azure.Commands.Network.Models;
1616
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1717
using Microsoft.Azure.Management.Network.Models;
18+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
1819
using System;
1920
using System.Collections;
2021
using System.Collections.Generic;
@@ -23,6 +24,7 @@
2324

2425
namespace Microsoft.Azure.Commands.Network
2526
{
27+
[CmdletPreview("Please note that the parameter -ProbeThreshold is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.")]
2628
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "LoadBalancerProbeConfig", SupportsShouldProcess = true), OutputType(typeof(PSLoadBalancer))]
2729
public partial class SetAzureRmLoadBalancerProbeConfigCommand : NetworkBaseCmdlet
2830
{

0 commit comments

Comments
 (0)