[Monitor] clean activitylogalert related models (Azure#19850)

* clean activitylogalert related models

* Create BreakingChangeIssues.csv

Author: VeryEarly

src/Monitor/Monitor.Test/Alerts/AddAzureRmMetricAlertRuleV2Tests.cs

@@ -16,6 +16,7 @@
 using Microsoft.Azure.Commands.Insights.OutputClasses;
 using Microsoft.Azure.Management.Monitor;
 using Microsoft.Azure.Management.Monitor.Models;
+using Microsoft.Azure.Management.Monitor.Management.Models;
 using Microsoft.Rest.Azure;
 using Microsoft.WindowsAzure.Commands.ScenarioTest;
 using Moq;
@@ -87,8 +88,8 @@ public void NewMetricAlertRuleV2ByTargetResourceScopeAndActionGroupParametersPro
         {
             _cmdlet.TargetResourceScope = new[] { "resourceId1", "resourceId2" };
             _cmdlet.ActionGroup = new[] {
-                new ActivityLogAlertActionGroup("actionGroupId1", null),
-                new ActivityLogAlertActionGroup("actionGroupId2", null)
+                new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup("actionGroupId1", null),
+                new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup("actionGroupId2", null)
             };
 
             _cmdlet.ExecuteCmdlet();
@@ -112,8 +113,8 @@ public void NewMetricAlertRuleV2ByTargetResourceScopeActionGroupAndActionGroupId
         {
             _cmdlet.TargetResourceScope = new[] { "resourceId1", "resourceId2" };
             _cmdlet.ActionGroup = new[] {
-                new ActivityLogAlertActionGroup("actionGroupId1", new Dictionary<string, string> {{"key1", "value1"}}),
-                new ActivityLogAlertActionGroup("actionGroupId2", null)
+                new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup("actionGroupId1", new Dictionary<string, string> {{"key1", "value1"}}),
+                new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup("actionGroupId2", null)
             };
 
             _cmdlet.ActionGroupId = new[] { "actionGroupId1", "actionGroupId3" };

src/Monitor/Monitor/Alerts/AddAzureRmMetricAlertRuleV2Command.cs

@@ -16,6 +16,7 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.Monitor;
 using Microsoft.Azure.Management.Monitor.Models;
+using Microsoft.Azure.Management.Monitor.Management.Models;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -110,7 +111,7 @@ public class AddAzureRmMetricAlertRuleV2Command : ManagementCmdletBase
         [Parameter(Mandatory = false, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The Action Group for rule")]
         [Alias("Actions")]
         [AllowEmptyCollection]
-        public ActivityLogAlertActionGroup[] ActionGroup { get; set; }
+        public Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup[] ActionGroup { get; set; }
 
         /// <summary>
         /// Gets or sets the ActionGroupId parameter

src/Monitor/Monitor/Monitor.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <PsModuleName>Monitor</PsModuleName>

src/Monitor/Monitor/OutputClasses/PSActivityLogAlertResource.cs

@@ -14,6 +14,7 @@
 
 using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
 using Microsoft.Azure.Management.Monitor.Models;
+using Microsoft.Azure.Management.Monitor.Management.Models;
 using Newtonsoft.Json;
 using System;
 using System.Collections.Generic;
@@ -53,10 +54,10 @@ public PSMetricAlertRuleV2(MetricAlertResource metricAlertResource)
             {
                 //Web-Test
             }
-            Actions = new ActivityLogAlertActionGroup[metricAlertResource.Actions.Count];
+            Actions = new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup[metricAlertResource.Actions.Count];
             for(int i = 0; i < metricAlertResource.Actions.Count;i++)
             {
-                Actions[i] = new ActivityLogAlertActionGroup(metricAlertResource.Actions[i].ActionGroupId, metricAlertResource.Actions[i].WebHookProperties);
+                Actions[i] = new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup(metricAlertResource.Actions[i].ActionGroupId, metricAlertResource.Actions[i].WebHookProperties);
             }
 
             var resourceIdentifier = new ResourceIdentifier(metricAlertResource.Id);
@@ -73,7 +74,7 @@ public PSMetricAlertRuleV2(MetricAlertResource metricAlertResource)
         /// Gets or sets list of action groups.
         /// </summary>
         [JsonProperty(PropertyName = "actions")]
-        public new ActivityLogAlertActionGroup[] Actions { get; set; }
+        public new Microsoft.Azure.Management.Monitor.Management.Models.ActivityLogAlertActionGroup[] Actions { get; set; }
 
         ///<summary>
         ///Gets or sets the resource group name

src/Monitor/Monitor/OutputClasses/PSMetricAlertRuleV2.cs

@@ -12,30 +12,48 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
+using Newtonsoft.Json;
+using System.Collections.Generic;
+
 namespace Microsoft.Azure.Management.Monitor.Management.Models
 {
     /// <summary>
     /// This class is intended to help in the transition between namespaces, since it will be a breaking change that needs to be announced and delayed 6 months.
     /// It is identical to the MetricSettings, but in the old namespace
     /// </summary>
-    public class ActivityLogAlertActionGroup : Monitor.Models.ActivityLogAlertActionGroup
+    public class ActivityLogAlertActionGroup
     {
         /// <summary>
         /// Initializes a new instance of the ActivityLogAlertActionGroup class.
         /// </summary>
         public ActivityLogAlertActionGroup()
-            : base()
         { }
 
         /// <summary>
-        /// Initializes a new instance of the ActivityLogAlertActionGroup class.
+        /// Initializes a new instance of the ActivityLogAlertActionGroup
+        /// class.
         /// </summary>
-        /// <param name="activityLogAlertActionGroup">The ActivityLogAlertActionGroup object</param>
-        public ActivityLogAlertActionGroup(Monitor.Models.ActivityLogAlertActionGroup activityLogAlertActionGroup)
-            : base(
-                  actionGroupId: activityLogAlertActionGroup?.ActionGroupId,
-                  webhookProperties: activityLogAlertActionGroup?.WebhookProperties)
+        /// <param name="actionGroupId">The resourceId of the action group.
+        /// This cannot be null or empty.</param>
+        /// <param name="webhookProperties">the dictionary of custom properties
+        /// to include with the post operation. These data are appended to the
+        /// webhook payload.</param>
+        public ActivityLogAlertActionGroup(string actionGroupId, IDictionary<string, string> webhookProperties = default(IDictionary<string, string>))
         {
+            ActionGroupId = actionGroupId;
+            WebhookProperties = webhookProperties;
         }
+
+        /// <summary>
+        /// Gets or sets the resourceId of the action group. This cannot be
+        /// null or empty.
+        /// </summary>
+        public string ActionGroupId { get; set; }
+
+        /// <summary>
+        /// Gets or sets the dictionary of custom properties to include with
+        /// the post operation. These data are appended to the webhook payload.
+        /// </summary>
+        public IDictionary<string, string> WebhookProperties { get; set; }
     }
 }