Skip to content

Commit 523a86f

Browse files
authored
Fix AzurePipelinesCredential options name (Azure#22970)
1 parent bac44f3 commit 523a86f

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

sdk/azidentity/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
that authenticates with client assertions such as federated credentials
88

99
### Breaking Changes
10+
> These changes affect only code written against a beta version such as v1.6.0-beta.4
11+
* Renamed `AzurePipelinesServiceConnectionCredentialOptions` to `AzurePipelinesCredentialOptions`
1012

1113
### Bugs Fixed
1214

sdk/azidentity/azure_pipelines_credential.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ type AzurePipelinesCredential struct {
3232
cred *ClientAssertionCredential
3333
}
3434

35-
// AzurePipelinesServiceConnectionCredentialOptions contains optional parameters for AzurePipelinesServiceConnectionCredential.
36-
type AzurePipelinesServiceConnectionCredentialOptions struct {
35+
// AzurePipelinesCredentialOptions contains optional parameters for AzurePipelinesCredential.
36+
type AzurePipelinesCredentialOptions struct {
3737
azcore.ClientOptions
3838

3939
// AdditionallyAllowedTenants specifies additional tenants for which the credential may acquire tokens.
@@ -54,9 +54,9 @@ type AzurePipelinesServiceConnectionCredentialOptions struct {
5454
// this variable in build job YAML.
5555
//
5656
// [Azure Pipelines documentation]: https://learn.microsoft.com/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#systemaccesstoken
57-
func NewAzurePipelinesCredential(tenantID, clientID, serviceConnectionID string, options *AzurePipelinesServiceConnectionCredentialOptions) (*AzurePipelinesCredential, error) {
57+
func NewAzurePipelinesCredential(tenantID, clientID, serviceConnectionID string, options *AzurePipelinesCredentialOptions) (*AzurePipelinesCredential, error) {
5858
if options == nil {
59-
options = &AzurePipelinesServiceConnectionCredentialOptions{}
59+
options = &AzurePipelinesCredentialOptions{}
6060
}
6161
u := os.Getenv(systemOIDCRequestURI)
6262
if u == "" {

sdk/azidentity/azure_pipelines_credential_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func TestAzurePipelinesCredential(t *testing.T) {
4040
}),
4141
)
4242
srv.AppendResponse()
43-
o := AzurePipelinesServiceConnectionCredentialOptions{
43+
o := AzurePipelinesCredentialOptions{
4444
ClientOptions: azcore.ClientOptions{
4545
Transport: srv,
4646
},

0 commit comments

Comments
 (0)