fix generator tool (Azure#23832)

* fix multi readme.md

* fix no  readme.go.md

* update comment

Author: jliusan

eng/tools/generator/cmd/issue/issueCmd.go

@@ -116,17 +116,17 @@ func (c *commandContext) execute() error {
 	if err != nil {
 		return err
 	}
+	// validate the config
+	if err := c.validateConfig(*cfg); err != nil {
+		log.Printf("validate config fail:error(%s)", err.Error())
+	}
+	// output the config to stdout after filtering out some invalid request,  so that the user could always get a usable config
 	// write config to stdout
 	b, err := json.MarshalIndent(*cfg, "", "  ")
 	if err != nil {
 		return err
 	}
 	fmt.Println(string(b))
-	// we first output the config to stdout, then validate it so that the user could always get a usable config
-	// validate the config
-	if err := c.validateConfig(*cfg); err != nil {
-		return err
-	}
 	return nil
 }
 

eng/tools/generator/cmd/issue/link/common.go

@@ -53,7 +53,18 @@ func GetReadmePathFromChangedFiles(ctx context.Context, client *query.Client, fi
 		readmeFiles[readme] = true
 	}
 	if len(readmeFiles) > 1 {
-		return "", fmt.Errorf("cannot determine which RP to release because we have the following readme files involved: %+v", getMapKeys(readmeFiles))
+		// filter specification/xxx/resource-manager/readme.md
+		rmReadmeFile := make(map[Readme]bool)
+		for readmePath, _ := range readmeFiles {
+			if strings.Contains(string(readmePath), "resource-manager/readme.md") {
+				rmReadmeFile[readmePath] = true
+			}
+		}
+		if len(rmReadmeFile) == 1 {
+			readmeFiles = rmReadmeFile
+		} else {
+			return "", fmt.Errorf("cannot determine which RP to release because we have the following readme files involved: %+v", getMapKeys(readmeFiles))
+		}
 	}
 	if len(readmeFiles) == 0 {
 		return "", fmt.Errorf("cannot get any readme files from these changed files: [%s]", strings.Join(files, ", "))

eng/tools/generator/config/validate/remoteValidator.go

@@ -23,16 +23,19 @@ type remoteValidator struct {
 
 func (v *remoteValidator) Validate(cfg config.Config) error {
 	var errResult error
+	invalidTrack2Requests := map[string]struct{}{}
 	for readme, infoMap := range cfg.Track2Requests {
 		// first we validate whether the readme exists
 		file, err := v.validateReadmeExistence(readme)
 		if err != nil {
 			errResult = errors.Join(errResult, err)
+			invalidTrack2Requests[readme] = struct{}{}
 			continue // readme file does not exist, we could just skip all of the other steps of validations
 		}
 		// get content of the readme
 		contentOfReadme, err := file.GetContent()
 		if err != nil {
+			invalidTrack2Requests[readme] = struct{}{}
 			errResult = errors.Join(errResult, fmt.Errorf("cannot get readme.md content: %+v", err))
 			continue
 		}
@@ -46,6 +49,7 @@ func (v *remoteValidator) Validate(cfg config.Config) error {
 		contentOfReadmeGo, err := fileGo.GetContent()
 		if err != nil {
 			errResult = errors.Join(errResult, fmt.Errorf("cannot get readme.go.md content: %+v", err))
+			invalidTrack2Requests[readme] = struct{}{}
 			continue
 		}
 		// get the keys from infoMap, which is the tags
@@ -55,13 +59,18 @@ func (v *remoteValidator) Validate(cfg config.Config) error {
 		}).ToSlice(&tags)
 		// check the tags one by one
 		if err := validateTagsInReadme([]byte(contentOfReadme), readme, tags...); err != nil {
+			invalidTrack2Requests[readme] = struct{}{}
 			errResult = errors.Join(errResult, err)
 		}
 		// check module-name exist
 		if err := validateModuleNameInReadmeGo([]byte(contentOfReadmeGo), readme); err != nil {
+			invalidTrack2Requests[readme] = struct{}{}
 			errResult = errors.Join(errResult, err)
 		}
 	}
+	for readme, _ := range invalidTrack2Requests {
+		delete(cfg.Track2Requests, readme)
+	}
 	return errResult
 }