Fix flakey live test (Azure#20405)

* Fix flakey live test

Ensure key name is unique so it doesn't collide with stale data.

* fix copy/pasta

* update sync token after updating a setting

Author: jhendrixMSFT

sdk/data/azappconfig/client_test.go

@@ -8,8 +8,10 @@ package azappconfig
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/require"
 )
@@ -22,7 +24,7 @@ func TestClient(t *testing.T) {
 		t.Skip("Skipping client test")
 	}
 
-	key := "key"
+	key := fmt.Sprintf("key-%d", time.Now().Unix())
 	label := "label"
 	contentType := "content-type"
 	value := "value"
@@ -72,6 +74,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, label, *setResp.Label)
 	require.Equal(t, contentType, *setResp.ContentType)
 	require.Equal(t, value, *setResp.Value)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	getResp3, err6 := client.GetSetting(context.TODO(), key, &GetSettingOptions{Label: &label, OnlyIfChanged: etag})
 	require.NoError(t, err6)
@@ -97,6 +103,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, key, *setResp2.Key)
 	require.Equal(t, label, *setResp2.Label)
 	require.Equal(t, value, *setResp2.Value)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	setResp3, err8 := client.SetSetting(context.TODO(), key, &value, &SetSettingOptions{Label: &label, OnlyIfUnchanged: etag})
 	require.Error(t, err8)
@@ -114,6 +124,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, label, *roResp.Label)
 	require.Equal(t, value, *roResp.Value)
 	require.True(t, *roResp.IsReadOnly)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	roResp2, err10 := client.SetReadOnly(context.TODO(), key, false, &SetReadOnlyOptions{Label: &label})
 	require.NoError(t, err10)
@@ -127,6 +141,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, label, *roResp2.Label)
 	require.Equal(t, value, *roResp2.Value)
 	require.False(t, *roResp2.IsReadOnly)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	roResp3, err11 := client.SetReadOnly(context.TODO(), key, true, &SetReadOnlyOptions{Label: &label, OnlyIfUnchanged: etag})
 	require.Error(t, err11)
@@ -145,6 +163,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, label, *roResp4.Label)
 	require.Equal(t, value, *roResp4.Value)
 	require.True(t, *roResp4.IsReadOnly)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	roResp5, err13 := client.SetReadOnly(context.TODO(), key, false, &SetReadOnlyOptions{Label: &label, OnlyIfUnchanged: etag})
 	require.Error(t, err13)
@@ -163,6 +185,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, label, *roResp6.Label)
 	require.Equal(t, value, *roResp6.Value)
 	require.False(t, *roResp6.IsReadOnly)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	any := "*"
 	revPgr := client.NewListRevisionsPager(SettingSelector{KeyFilter: &any, LabelFilter: &any, Fields: AllSettingFields()}, nil)
@@ -177,8 +203,8 @@ func TestClient(t *testing.T) {
 
 	settsPgr := client.NewListSettingsPager(SettingSelector{KeyFilter: &any, LabelFilter: &any, Fields: AllSettingFields()}, nil)
 	require.NotEmpty(t, settsPgr)
-	hasMoreSetts := revPgr.More()
-	require.False(t, hasMoreSetts)
+	hasMoreSetts := settsPgr.More()
+	require.True(t, hasMoreSetts)
 	settsResp, err16 := settsPgr.NextPage(context.TODO())
 	require.NoError(t, err16)
 	require.NotEmpty(t, settsResp)
@@ -197,6 +223,10 @@ func TestClient(t *testing.T) {
 	require.Equal(t, key, *delResp.Key)
 	require.Equal(t, label, *delResp.Label)
 	require.Equal(t, value, *delResp.Value)
+	require.NotNil(t, setResp.SyncToken)
+
+	// after changing the setting, update the sync token so we don't get cached, stale data
+	client.UpdateSyncToken(*setResp.SyncToken)
 
 	addResp2, err18 := client.AddSetting(context.TODO(), key, &value, &AddSettingOptions{Label: &label, ContentType: &contentType})
 	require.NoError(t, err18)