Skip to content

Commit cff0a55

Browse files
authored
[azopenai] Fixing failing tests (Azure#23955)
1 parent dcc6465 commit cff0a55

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

sdk/ai/azopenai/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "go",
44
"TagPrefix": "go/ai/azopenai",
5-
"Tag": "go/ai/azopenai_cb43c9a227"
5+
"Tag": "go/ai/azopenai_ce36c649fa"
66
}

sdk/ai/azopenai/client_chat_completions_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,18 @@ func TestClient_GetChatCompletions(t *testing.T) {
108108
resp.ChatCompletions.Choices[i].ContentFilterResults = nil
109109
}
110110

111+
// Exclude Usage field from comparison as they can change
112+
expectedUsage := expected.Usage
113+
actualUsage := resp.ChatCompletions.Usage
114+
expected.Usage = nil
115+
resp.ChatCompletions.Usage = nil
116+
111117
require.Equal(t, expected, resp.ChatCompletions)
118+
119+
// Compare the usage numbers, but allow for a small margin of error
120+
require.InDelta(t, *expectedUsage.CompletionTokens, *actualUsage.CompletionTokens, 5)
121+
require.InDelta(t, *expectedUsage.PromptTokens, *actualUsage.PromptTokens, 5)
122+
require.InDelta(t, *expectedUsage.TotalTokens, *actualUsage.TotalTokens, 5)
112123
}
113124

114125
t.Run("AzureOpenAI", func(t *testing.T) {

sdk/ai/azopenai/client_shared_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ var azureOpenAI, openAI = func() (testVars, testVars) {
169169
},
170170
Vision: endpointWithModel{
171171
Endpoint: ifAzure(azure, servers.SWECentral, servers.OpenAI),
172-
Model: ifAzure(azure, "gpt-4-vision-preview", "gpt-4-vision-preview"),
172+
Model: ifAzure(azure, "gpt-4o", "gpt-4o"),
173173
},
174174
Whisper: endpointWithModel{
175175
Endpoint: ifAzure(azure, servers.USNorthCentral, servers.OpenAI),

sdk/ai/azopenai/example_client_getchatcompletions_vision_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717

1818
func ExampleClient_GetChatCompletions_vision() {
1919
azureOpenAIKey := os.Getenv("AOAI_VISION_API_KEY")
20-
modelDeployment := os.Getenv("AOAI_VISION_MODEL") // ex: gpt-4-vision-preview"
20+
modelDeployment := os.Getenv("AOAI_VISION_MODEL") // ex: gpt-4o"
2121

2222
// Ex: "https://<your-azure-openai-host>.openai.azure.com"
2323
azureOpenAIEndpoint := os.Getenv("AOAI_VISION_ENDPOINT")

0 commit comments

Comments
 (0)