Skip to content

Commit d6b7b7c

Browse files
azure-sdkscbedd
andauthored
Sync eng/common directory with azure-sdk-tools for PR 8475 (Azure#23096)
* update the target version of the proxy * unskip the tests so they fail properly * fix the skips * update the assets.json --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
1 parent 060b442 commit d6b7b7c

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.0-dev.20240604.2
1+
1.0.0-dev.20240619.2

sdk/containers/azcontainerregistry/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "go",
44
"TagPrefix": "go/containers/azcontainerregistry",
5-
"Tag": "go/containers/azcontainerregistry_b6bdd049bc"
5+
"Tag": "go/containers/azcontainerregistry_734baeebc4"
66
}

sdk/containers/azcontainerregistry/client_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"github.com/Azure/azure-sdk-for-go/sdk/azcore/streaming"
2121
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
2222
"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
23-
"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
2423
"github.com/stretchr/testify/require"
2524
)
2625

@@ -131,9 +130,6 @@ func TestClient_DeleteTag_error(t *testing.T) {
131130
}
132131

133132
func TestClient_GetManifest(t *testing.T) {
134-
if recording.GetRecordMode() == recording.PlaybackMode {
135-
t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919")
136-
}
137133
startRecording(t)
138134
endpoint, cred, options := getEndpointCredAndClientOptions(t)
139135
ctx := context.Background()
@@ -616,9 +612,6 @@ func TestClient_UpdateTagProperties_wrongTag(t *testing.T) {
616612
}
617613

618614
func TestClient_UploadManifest(t *testing.T) {
619-
if recording.GetRecordMode() == recording.PlaybackMode {
620-
t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919")
621-
}
622615
startRecording(t)
623616
endpoint, cred, options := getEndpointCredAndClientOptions(t)
624617
ctx := context.Background()

0 commit comments

Comments
 (0)