azcontainerregistry tests use internal credential factory (Azure#23077)

* azcontainerregistry tests use internal credential factory

* upgrade

Author: chlowell

sdk/containers/azcontainerregistry/authentication_policy_test.go

@@ -10,6 +10,13 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"net/http"
+	"reflect"
+	"strings"
+	"sync/atomic"
+	"testing"
+	"time"
+
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
@@ -18,13 +25,8 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/temporal"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/test/credential"
 	"github.com/stretchr/testify/require"
-	"net/http"
-	"reflect"
-	"strings"
-	"sync/atomic"
-	"testing"
-	"time"
 )
 
 func Test_getJWTExpireTime(t *testing.T) {
@@ -161,7 +163,7 @@ func Test_authenticationPolicy_getAccessToken_error(t *testing.T) {
 	p := &authenticationPolicy{
 		temporal.NewResource(acquireRefreshToken),
 		atomic.Value{},
-		&FakeCredential{},
+		&credential.Fake{},
 		[]string{"test"},
 		authClient,
 	}
@@ -245,7 +247,7 @@ func Test_authenticationPolicy(t *testing.T) {
 	authPolicy := &authenticationPolicy{
 		temporal.NewResource(acquireRefreshToken),
 		atomic.Value{},
-		&FakeCredential{},
+		&credential.Fake{},
 		[]string{"test"},
 		authClient,
 	}

sdk/containers/azcontainerregistry/utils_test.go

@@ -12,15 +12,13 @@ import (
 	"os"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
 	azcloud "github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
-	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
-	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/test/credential"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry"
 	"github.com/stretchr/testify/require"
 )
@@ -37,19 +35,10 @@ var testConfig = struct {
 	loginServer string
 }{
 	cloud:       azcloud.AzurePublic,
-	credential:  &FakeCredential{},
+	credential:  &credential.Fake{},
 	loginServer: fakeLoginServer,
 }
 
-// FakeCredential is an empty credential for testing.
-type FakeCredential struct {
-}
-
-// GetToken provide a fake access token.
-func (c *FakeCredential) GetToken(ctx context.Context, opts policy.TokenRequestOptions) (azcore.AccessToken, error) {
-	return azcore.AccessToken{Token: recording.SanitizedValue, ExpiresOn: time.Now().Add(time.Hour * 24).UTC()}, nil
-}
-
 // getEndpointCredAndClientOptions will create a credential and a client options for test application.
 // The client options will initialize the transport for recording client add recording policy to the pipeline.
 // In the record mode, the credential will be a DefaultAzureCredential which combines several common credentials.
@@ -81,7 +70,7 @@ func TestMain(m *testing.M) {
 func run(m *testing.M) int {
 	if recording.GetRecordMode() != recording.PlaybackMode {
 		var err error
-		testConfig.credential, err = azidentity.NewDefaultAzureCredential(nil)
+		testConfig.credential, err = credential.New(nil)
 		if err != nil {
 			panic(err)
 		}