Remove default sanitizers added in sdk/internal v1.6.0 (Azure#22872)

Author: chlowell

sdk/internal/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Release History
 
-## 1.7.1 (Unreleased)
+## 1.8.0 (Unreleased)
 
 ### Features Added
 
@@ -10,6 +10,8 @@
 
 ### Other Changes
 
+* Removed default sanitizers added in v1.6.0 (the test proxy itself now includes these)
+
 ## 1.7.0 (2024-05-01)
 
 ### Features Added

sdk/internal/recording/default_sanitizers.go

@@ -25,7 +25,6 @@ import (
 	"strconv"
 	"strings"
 	"sync"
-	"sync/atomic"
 	"testing"
 	"time"
 
@@ -79,12 +78,7 @@ const (
 	Secret_Base64String VariableType = "secret_base64String"
 )
 
-var (
-	// defaultSanitizersSet tracks whether default sanitizers have been added (this would be neater with Go 1.19's atomic.Bool)
-	defaultSanitizersSet int32
-
-	errUnsupportedAPI = errors.New("the vcr based test recording API isn't supported. Use the test proxy instead")
-)
+var errUnsupportedAPI = errors.New("the vcr based test recording API isn't supported. Use the test proxy instead")
 
 // NewRecording initializes a new Recording instance
 func NewRecording(c TestContext, mode RecordMode) (*Recording, error) {
@@ -401,13 +395,6 @@ func Start(t *testing.T, pathToRecordings string, options *RecordingOptions) err
 			return nil
 		}
 	}
-	if recordMode == RecordingMode && atomic.CompareAndSwapInt32(&defaultSanitizersSet, 0, 1) {
-		err := addSanitizers(defaultSanitizers, options)
-		if err != nil {
-			atomic.StoreInt32(&defaultSanitizersSet, 0)
-			return err
-		}
-	}
 	if options == nil {
 		options = defaultOptions()
 	}