CodeCleanBasedOnFewGithubIssues (Azure#30099)

* clean code based on few open github issues

Co-authored-by: annie-mac <[email protected]>

Author: xinlian12

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PathsHelper.java

@@ -400,8 +400,8 @@ public static boolean tryParsePathSegments(String resourceUrl, PathInfo pathInfo
                 // modify.
                 if (!StringUtils.isEmpty(clientVersion)
                         && pathInfo.resourcePath.equalsIgnoreCase(Paths.MEDIA_PATH_SEGMENT)) {
-                    String attachmentId = null;
-                    byte storeIndex = 0;
+                    // String attachmentId = null;
+                    // byte storeIndex = 0;
                     // MEDIA Id parsing code  will come here , supported MediaIdHelper file missing in java sdk(Sync and Async both)
                     //Below code from .net
                     // if (!MediaIdHelper.TryParseMediaId(resourceIdOrFullName, out attachmentId, out storeIndex))

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/QueryMetrics.java

@@ -20,23 +20,6 @@
  * This metric represents a moving average for a set of queries whose metrics have been aggregated together.
  */
 public final class QueryMetrics {
-    public final static QueryMetrics ZERO = new QueryMetrics(
-        new ArrayList<>(), /* */
-        0, /* retrievedDocumentCount */
-        0, /* retrievedDocumentSize */
-        0, /* outputDocumentCount */
-        0, /* outputDocumentSize */
-        0, /* indexHitCount */
-        Duration.ZERO,
-        QueryPreparationTimes.ZERO,
-        Duration.ZERO,
-        Duration.ZERO,
-        Duration.ZERO,
-        RuntimeExecutionTimes.ZERO,
-        Duration.ZERO,
-        ClientSideMetrics.ZERO,
-        IndexUtilizationInfo.ZERO);
-
     private final long retrievedDocumentCount;
     private final long retrievedDocumentSize;
     private final long outputDocumentCount;
@@ -269,7 +252,6 @@ public static QueryMetrics createFromCollection(Collection<QueryMetrics> queryMe
     }
 
     public static QueryMetrics createFromDelimitedString(String delimitedString) {
-        HashMap<String, Double> metrics = QueryMetricsUtils.parseDelimitedString(delimitedString);
         return QueryMetrics.createFromDelimitedStringAndClientSideMetrics(delimitedString,
                 new ClientSideMetrics(0, 0, new ArrayList<FetchExecutionRange>(),
                         new ArrayList<ImmutablePair<String, SchedulingTimeSpan>>()), "", "");

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceId.java

@@ -172,7 +172,7 @@ public static Pair<Boolean, ResourceId> tryParse(String id) {
                 byte[] temp = new byte[4];
                 ResourceId.blockCopy(buffer, 4, temp, 0, 4);
 
-                boolean isCollection = (temp[0] & (128)) > 0;
+                boolean isCollection = (temp[0] & (128)) != 0;
 
                 if (isCollection) {
                     rid.documentCollection = ByteBuffer.wrap(temp).getInt();

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceTokenAuthorizationHelper.java

@@ -168,12 +168,9 @@ public static String getAuthorizationTokenUsingResourceTokens(
                     && (RequestVerb.GET == requestVerb
                             || RequestVerb.HEAD == requestVerb)) {
                 for (Map.Entry<String, List<PartitionKeyAndResourceTokenPair>> entry : resourceTokensMap.entrySet()) {
-                    ResourceId tokenRid;
                     final String key = entry.getKey();
                     Pair<Boolean, ResourceId> pair = ResourceId.tryParse(key);
                     if (pair.getLeft()) {
-                        ResourceId test1= pair.getRight().getDocumentCollectionId();
-                        boolean test = test1.equals(resourceId);
                         if (!PathsHelper.isNameBased(key) && pair.getLeft()
                             && pair.getRight().getDocumentCollectionId().equals(resourceId)) {
                             List<PartitionKeyAndResourceTokenPair> resourceTokens = entry.getValue();

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

@@ -4078,7 +4078,7 @@ public Flux<DatabaseAccount> getDatabaseAccountFromEndpoint(URI endpoint) {
     private RxStoreModel getStoreProxy(RxDocumentServiceRequest request) {
         // If a request is configured to always use GATEWAY mode(in some cases when targeting .NET Core)
         // we return the GATEWAY store model
-        if (request.UseGatewayMode) {
+        if (request.useGatewayMode) {
             return this.gatewayProxy;
         }
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentServiceRequest.java

@@ -67,7 +67,7 @@ public class RxDocumentServiceRequest implements Cloneable {
     // some of these fields are missing from the main java sdk service request
     // so it means most likely the corresponding features are also missing from the main sdk
     // we need to wire this up.
-    public boolean UseGatewayMode;
+    public boolean useGatewayMode;
 
     private volatile boolean isDisposed = false;
     public volatile String entityId;
@@ -1027,7 +1027,7 @@ public RxDocumentServiceRequest clone() {
         rxDocumentServiceRequest.setPartitionKeyRangeIdentity(this.getPartitionKeyRangeIdentity());
         rxDocumentServiceRequest.forceCollectionRoutingMapRefresh = this.forceCollectionRoutingMapRefresh;
         rxDocumentServiceRequest.forcePartitionKeyRangeRefresh = this.forcePartitionKeyRangeRefresh;
-        rxDocumentServiceRequest.UseGatewayMode = this.UseGatewayMode;
+        rxDocumentServiceRequest.useGatewayMode = this.useGatewayMode;
         rxDocumentServiceRequest.requestContext = this.requestContext;
         return rxDocumentServiceRequest;
     }

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java

@@ -157,14 +157,17 @@ public Mono<Utils.ValueHolder<PartitionKeyRange>> tryGetRangeByPartitionKeyRange
         return routingMapObs.map(routingMapValueHolder -> new Utils.ValueHolder<>(routingMapValueHolder.v.getRangeByPartitionKeyRangeId(partitionKeyRangeId)))
                 .onErrorResume(err -> {
                     CosmosException dce = Utils.as(err, CosmosException.class);
-                    logger.debug("tryGetRangeByPartitionKeyRangeId on collectionRid {} and partitionKeyRangeId {} encountered failure",
-                            collectionRid, partitionKeyRangeId, err);
+                    logger.debug(
+                            "tryGetRangeByPartitionKeyRangeId on collectionRid {} and partitionKeyRangeId {} encountered failure",
+                            collectionRid,
+                            partitionKeyRangeId,
+                            err);
 
-                    if (dce != null && Exceptions.isStatusCode(dce, HttpConstants.StatusCodes.NOTFOUND)) {
+                    if (dce != null && Exceptions.isNotFound(dce)) {
                         return Mono.just(new Utils.ValueHolder<>(null));
                     }
 
-                    return Mono.error(dce);
+                    return dce != null ? Mono.error(dce) : Mono.error(err);
                 });
     }
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/ServiceItemLease.java

@@ -38,9 +38,9 @@ public class ServiceItemLease implements Lease {
 
     private String id;
     private String _etag;
-    private String LeaseToken;
-    private String Owner;
-    private String ContinuationToken;
+    private String leaseToken;
+    private String owner;
+    private String continuationToken;
 
     private Map<String, String> properties;
     private String timestamp;  // ExplicitTimestamp
@@ -57,9 +57,9 @@ public ServiceItemLease(ServiceItemLease other)
     {
         this.id = other.id;
         this._etag = other._etag;
-        this.LeaseToken = other.LeaseToken;
-        this.Owner = other.Owner;
-        this.ContinuationToken = other.ContinuationToken;
+        this.leaseToken = other.leaseToken;
+        this.owner = other.owner;
+        this.continuationToken = other.continuationToken;
         this.properties = other.properties;
         this.timestamp = other.timestamp;
         this._ts = other._ts;
@@ -85,27 +85,27 @@ public ServiceItemLease withETag(String etag) {
     }
 
     public String getLeaseToken() {
-        return this.LeaseToken;
+        return this.leaseToken;
     }
 
     public ServiceItemLease withLeaseToken(String leaseToken) {
-        this.LeaseToken = leaseToken;
+        this.leaseToken = leaseToken;
         return this;
     }
 
     @Override
     public String getOwner() {
-        return this.Owner;
+        return this.owner;
     }
 
     public ServiceItemLease withOwner(String owner) {
-        this.Owner = owner;
+        this.owner = owner;
         return this;
     }
 
     @Override
     public String getContinuationToken() {
-        return this.ContinuationToken;
+        return this.continuationToken;
     }
 
     public ChangeFeedState getContinuationState(
@@ -119,7 +119,7 @@ public ChangeFeedState getContinuationState(
             containerRid,
             feedRange,
             ChangeFeedMode.INCREMENTAL,
-            ChangeFeedStartFromInternal.createFromETagAndFeedRange(this.ContinuationToken, feedRange),
+            ChangeFeedStartFromInternal.createFromETagAndFeedRange(this.continuationToken, feedRange),
             null);
     }
 
@@ -129,7 +129,7 @@ public void setContinuationToken(String continuationToken) {
     }
 
     public ServiceItemLease withContinuationToken(String continuationToken) {
-        this.ContinuationToken = continuationToken;
+        this.continuationToken = continuationToken;
         return this;
     }
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/AddressResolver.java

@@ -343,7 +343,6 @@ private static class RefreshState {
         volatile boolean collectionRoutingMapCacheIsUptoDate;
         volatile DocumentCollection collection;
         volatile CollectionRoutingMap routingMap;
-        volatile ResolutionResult resolutionResult;
     }
 
     private Mono<RefreshState> getOrRefreshRoutingMap(RxDocumentServiceRequest request, boolean forceRefreshPartitionAddresses) {

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReader.java

@@ -212,12 +212,7 @@ public Mono<StoreResponse> readAsync(RxDocumentServiceRequest entity,
                 return this.readPrimaryAsync(entity, useSessionToken.v);
 
             case Strong:
-                entity.requestContext.performLocalRefreshOnGoneException = true;
-                return this.quorumReader.readStrongAsync(this.diagnosticsClientContext, entity, readQuorumValue, desiredReadMode);
-
             case BoundedStaleness:
-                entity.requestContext.performLocalRefreshOnGoneException = true;
-
                 // for bounded staleness, we are defaulting to read strong for local region reads.
                 // this can be done since we are always running with majority quorum w = 3 (or 2 during quorum downshift).
                 // This means that the primary will always be part of the write quorum, and
@@ -228,6 +223,8 @@ public Mono<StoreResponse> readAsync(RxDocumentServiceRequest entity,
                 // we always contact two secondary replicas and exclude primary.
                 // However, this model significantly reduces availability and available throughput for serving reads for bounded staleness during reconfiguration.
                 // Therefore, to ensure monotonic read guarantee from any replica set we will just use regular quorum read(R=2) since our write quorum is always majority(W=3)
+
+                entity.requestContext.performLocalRefreshOnGoneException = true;
                 return this.quorumReader.readStrongAsync(this.diagnosticsClientContext, entity, readQuorumValue, desiredReadMode);
 
             case Any: