[Tables] Adjust catch level to exception (Azure#44063)

* Adjust catch level to exception

* Moving test to a class that doesn't extend TestProxyTestBase

* Fixing analyze issues

* Fixing analyze issues

Author: jairmyree

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/implementation/TableUtils.java

@@ -344,7 +344,7 @@ public static <T> Response<T> callWithOptionalTimeout(Supplier<Response<T>> call
         ClientLogger logger, boolean skip409Logging) {
         try {
             return callHandler(callable, timeout, logger);
-        } catch (Throwable thrown) {
+        } catch (Exception thrown) {
             Throwable exception = mapThrowableToTableServiceException(thrown);
             if (exception instanceof TableServiceException) {
                 TableServiceException e = (TableServiceException) exception;

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientBuilderTest.java

@@ -17,6 +17,8 @@
 import com.azure.core.test.utils.MockTokenCredential;
 import com.azure.core.util.ClientOptions;
 import com.azure.core.util.Header;
+import com.azure.core.util.logging.ClientLogger;
+import com.azure.data.tables.implementation.TableUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import reactor.core.publisher.Mono;
@@ -269,6 +271,15 @@ public void multipleFormsOfAuthenticationPresent() {
                 .buildAsyncClient());
     }
 
+    @Test
+    void nonRuntimeExceptionsDontGetCasted() {
+        assertThrows(Error.class, () -> {
+            TableUtils.callWithOptionalTimeout(() -> {
+                throw new NoClassDefFoundError("This is an error");
+            }, null, new ClientLogger(TableClientTest.class));
+        });
+    }
+
     @Test
     public void bothRetryOptionsAndRetryPolicyPresent() {
         assertThrows(IllegalStateException.class,

sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java

@@ -47,13 +47,7 @@
 import java.util.Map;
 import java.util.UUID;
 
-import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.*;
 
 /**
  * Tests {@link TableClient}.