Skip to content

Commit 51a3f69

Browse files
authored
Fix toString in ConnectionPolicy (Azure#44961)
* fix toString in ConnectionPolicy * use Objects.toString
1 parent a2f5f10 commit 51a3f69

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ConnectionPolicyTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ public void usingMultipleWriteRegions() {
4848
public void connectionPolicyDirectConnectionToString() {
4949
ConnectionPolicy policy = new ConnectionPolicy(DirectConnectionConfig.getDefaultConfig());
5050
assertThat(policy.toString()).isNotEmpty();
51+
assertThat(policy.toString()).isNotEqualTo("null");
5152
}
5253

5354
@Test(groups = { "unit" })
5455
public void connectionPolicyGatewayConnectionToString() {
5556
ConnectionPolicy policy = new ConnectionPolicy(GatewayConnectionConfig.getDefaultConfig());
5657
assertThat(policy.toString()).isNotEmpty();
58+
assertThat(policy.toString()).isNotEqualTo("null");
5759
}
5860
}

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConnectionPolicy.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import java.time.Duration;
1515
import java.util.Collections;
1616
import java.util.List;
17+
import java.util.Objects;
1718
import java.util.function.Supplier;
1819

1920
/**
@@ -669,7 +670,7 @@ public String toString() {
669670
", minConnectionPoolSizePerEndpoint=" + minConnectionPoolSizePerEndpoint +
670671
", openConnectionsConcurrency=" + openConnectionsConcurrency +
671672
", aggressiveWarmupConcurrency=" + aggressiveWarmupConcurrency +
672-
", pendingAcquireMaxCount=" + this.pendingAcquireMaxCount != null ? String.valueOf(this.pendingAcquireMaxCount) : "DEFAULT" +
673+
", pendingAcquireMaxCount=" + Objects.toString(this.pendingAcquireMaxCount,"DEFAULT") +
673674
'}';
674675
}
675676
}

0 commit comments

Comments
 (0)