Skip to content

Commit 57211e0

Browse files
authored
Align XML redactions with previous redaction framework (Azure#37043)
1 parent cbe7eb8 commit 57211e0

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

sdk/core/azure-core-test/src/main/java/com/azure/core/test/utils/TestProxyUtils.java

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,12 @@ public class TestProxyUtils {
7171
// - SignedOid
7272
// - SignedTid
7373
// - Value
74-
private static final String XML_BODY_REGEX_REDACTIONS =
75-
"(?:<(PrimaryKey|SecondaryKey|SignedOid|SignedTid|Value)>)(?<secret>.*)(?:</(PrimaryKey|SecondaryKey|SignedOid|SignedTid|Value)>)";
74+
private static final String XML_BODY_PRIMARY_KEY_REDACTION = "<PrimaryKey>(?<secret>.*?)</PrimaryKey>";
75+
private static final String XML_BODY_SECONDARY_KEY_REDACTION = "<SecondaryKey>(?<secret>.*?)</SecondaryKey>";
76+
private static final String XML_BODY_SIGNED_OID_REDACTION = "<UserDelegationKey>.*?<SignedOid>(?<secret>.*?)</SignedOid>.*?</UserDelegationKey>";
77+
private static final String XML_BODY_SIGNED_TID_REDACTION = "<UserDelegationKey>.*?<SignedTid>(?<secret>.*?)</SignedTid>.*?</UserDelegationKey>";
78+
private static final String XML_BODY_VALUE_REDACTION = "<UserDelegationKey>.*?<Value>(?<secret>.*?)</Value>.*?</UserDelegationKey>";
79+
7680
private static final HttpHeaderName X_RECORDING_UPSTREAM_BASE_URI =
7781
HttpHeaderName.fromString("x-recording-upstream-base-uri");
7882
private static final HttpHeaderName X_RECORDING_MODE = HttpHeaderName.fromString("x-recording-mode");
@@ -502,7 +506,15 @@ private static List<TestProxySanitizer> addDefaultRegexSanitizers() {
502506

503507
regexSanitizers.add(new TestProxySanitizer(JSON_BODY_REGEX_REDACTIONS, REDACTED_VALUE,
504508
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
505-
regexSanitizers.add(new TestProxySanitizer(XML_BODY_REGEX_REDACTIONS, REDACTED_VALUE,
509+
regexSanitizers.add(new TestProxySanitizer(XML_BODY_PRIMARY_KEY_REDACTION, REDACTED_VALUE,
510+
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
511+
regexSanitizers.add(new TestProxySanitizer(XML_BODY_SECONDARY_KEY_REDACTION, REDACTED_VALUE,
512+
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
513+
regexSanitizers.add(new TestProxySanitizer(XML_BODY_SIGNED_OID_REDACTION, REDACTED_VALUE,
514+
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
515+
regexSanitizers.add(new TestProxySanitizer(XML_BODY_SIGNED_TID_REDACTION, REDACTED_VALUE,
516+
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
517+
regexSanitizers.add(new TestProxySanitizer(XML_BODY_VALUE_REDACTION, REDACTED_VALUE,
506518
TestProxySanitizerType.BODY_REGEX).setGroupForReplace("secret"));
507519

508520
// Add header key regexes

0 commit comments

Comments
 (0)