Skip to content

Commit 5786337

Browse files
authored
Integrate paged iterable sync updates to AppConfig (Azure#30715)
1 parent e397953 commit 5786337

File tree

6 files changed

+110
-33
lines changed

6 files changed

+110
-33
lines changed

eng/versioning/version_client.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ com.azure.tools:azure-sdk-build-tool;1.0.0-beta.1;1.0.0-beta.2
383383
# In the pom, the version update tag after the version should name the unreleased package and the dependency version:
384384
# <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->
385385
unreleased_com.azure:azure-ai-formrecognizer;4.0.0-beta.7
386+
unreleased_com.azure:azure-core;1.32.0-beta.1
386387

387388
# Released Beta dependencies: Copy the entry from above, prepend "beta_", remove the current
388389
# version and set the version to the released beta. Released beta dependencies are only valid

sdk/appconfiguration/azure-data-appconfiguration/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<dependency>
4646
<groupId>com.azure</groupId>
4747
<artifactId>azure-core</artifactId>
48-
<version>1.31.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} -->
48+
<version>1.32.0-beta.1</version> <!-- {x-version-update;unreleased_com.azure:azure-core;dependency} -->
4949
</dependency>
5050
<dependency>
5151
<groupId>com.azure</groupId>

sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,14 +743,14 @@ public Mono<Response<ConfigurationSetting>> setReadOnlyWithResponse(Configuratio
743743
*
744744
* <p>Retrieve all settings that use the key "prodDBConnection".</p>
745745
*
746-
* <!-- src_embed com.azure.data.appconfiguration.configurationasyncclient.listsettings -->
746+
* <!-- src_embed com.azure.data.appconfiguration.configurationasyncclient.listConfigurationSettings -->
747747
* <pre>
748748
* client.listConfigurationSettings&#40;new SettingSelector&#40;&#41;.setKeyFilter&#40;&quot;prodDBConnection&quot;&#41;&#41;
749749
* .contextWrite&#40;Context.of&#40;key1, value1, key2, value2&#41;&#41;
750750
* .subscribe&#40;setting -&gt;
751751
* System.out.printf&#40;&quot;Key: %s, Value: %s&quot;, setting.getKey&#40;&#41;, setting.getValue&#40;&#41;&#41;&#41;;
752752
* </pre>
753-
* <!-- end com.azure.data.appconfiguration.configurationasyncclient.listsettings -->
753+
* <!-- end com.azure.data.appconfiguration.configurationasyncclient.listConfigurationSettings -->
754754
*
755755
* @param selector Optional. Selector to filter configuration setting results from the service.
756756
* @return A Flux of ConfigurationSettings that matches the {@code selector}. If no options were provided, the Flux

sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClient.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ public ConfigurationSetting setConfigurationSetting(ConfigurationSetting setting
279279
* <!-- end com.azure.data.appconfiguration.ConfigurationClient.setConfigurationSettingWithResponse#ConfigurationSetting-boolean-Context -->
280280
*
281281
* @param setting The setting to create or update based on its key, optional label and optional ETag combination.
282-
* @param ifUnchanged A boolean indicates if {@code setting} {@link ConfigurationSetting#getETag ETag} is used as a
282+
* @param ifUnchanged A boolean indicates if {@code setting} {@link ConfigurationSetting#getETag ETag} is used as an
283283
* IF-MATCH header.
284284
* @param context Additional context that is passed through the Http pipeline during the service call.
285285
* @return A REST response contains the {@link ConfigurationSetting} that was created or updated, or {@code null},
@@ -419,7 +419,7 @@ public ConfigurationSetting getConfigurationSetting(ConfigurationSetting setting
419419
* @param setting The setting to retrieve.
420420
* @param acceptDateTime Datetime to access a past state of the configuration setting. If {@code null}
421421
* then the current state of the configuration setting will be returned.
422-
* @param ifChanged Flag indicating if the {@code setting} {@link ConfigurationSetting#getETag ETag} is used as a
422+
* @param ifChanged Flag indicating if the {@code setting} {@link ConfigurationSetting#getETag ETag} is used as an
423423
* If-None-Match header.
424424
* @param context Additional context that is passed through the Http pipeline during the service call.
425425
* @return A REST response contains the {@link ConfigurationSetting} stored in the service, or {@code null}, if the
@@ -526,7 +526,7 @@ public ConfigurationSetting deleteConfigurationSetting(ConfigurationSetting sett
526526
* <!-- end com.azure.data.applicationconfig.configurationclient.deleteConfigurationSettingWithResponse#ConfigurationSetting-boolean-Context -->
527527
*
528528
* @param setting The setting to delete based on its key, optional label and optional ETag combination.
529-
* @param ifUnchanged Flag indicating if the {@code setting} {@link ConfigurationSetting#getETag ETag} is used as a
529+
* @param ifUnchanged Flag indicating if the {@code setting} {@link ConfigurationSetting#getETag ETag} is used as an
530530
* IF-MATCH header.
531531
* @param context Additional context that is passed through the Http pipeline during the service call.
532532
* @return A REST response containing the deleted ConfigurationSetting or {@code null} if didn't exist. {@code null}
@@ -726,12 +726,12 @@ public PagedIterable<ConfigurationSetting> listConfigurationSettings(SettingSele
726726
* @param selector Optional. Selector to filter configuration setting results from the service.
727727
* @param context Additional context that is passed through the Http pipeline during the service call.
728728
* @return A {@link PagedIterable} of ConfigurationSettings that matches the {@code selector}. If no options were
729-
* provided, the {@link PagedIterable} contains all of the current settings in the service.
729+
* provided, the {@link PagedIterable} contains all the current settings in the service.
730730
* @throws HttpResponseException If a client or service error occurs, such as a 404, 409, 429 or 500.
731731
*/
732732
@ServiceMethod(returns = ReturnType.COLLECTION)
733733
public PagedIterable<ConfigurationSetting> listConfigurationSettings(SettingSelector selector, Context context) {
734-
return new PagedIterable<>(serviceClient.listConfigurationSettingsAsync(selector, context));
734+
return serviceClient.listConfigurationSettings(selector, context);
735735
}
736736

737737
/**
@@ -800,7 +800,7 @@ public PagedIterable<ConfigurationSetting> listRevisions(SettingSelector selecto
800800
*/
801801
@ServiceMethod(returns = ReturnType.COLLECTION)
802802
public PagedIterable<ConfigurationSetting> listRevisions(SettingSelector selector, Context context) {
803-
return new PagedIterable<>(serviceClient.listRevisionsAsync(selector, context));
803+
return serviceClient.listRevisions(selector, context);
804804
}
805805

806806
/**

0 commit comments

Comments
 (0)