Replaces namespace prefix w/global namespace in payload for CreateTopicBodyImpl (fixes Azure#34880) (Azure#34895)

* Fix for Azure#34880: Updating TopicProperties w/AuthorizationRules returns 400 Bad request

* Added line to CHANGELOG.md

* Minimal test case.

Author: haraldk

sdk/servicebus/azure-messaging-servicebus/CHANGELOG.md

@@ -14,6 +14,8 @@
 
 - Fixed mapping of `ServiceBusManagementError` to corresponding `AzureExceptions` in `ServiceBusAdministrationClient`. ([33609](https://github.com/Azure/azure-sdk-for-java/issues/33609))
 
+- Fixed issue causing updates to TopicProperties w/AuthorizationRules to return 400 Bad request([#34880](https://github.com/Azure/azure-sdk-for-java/issues/34880))
+
 ### Other Changes
 
 ## 7.15.0-beta.2 (2023-07-18)

sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/administration/implementation/ServiceBusManagementSerializer.java

@@ -12,6 +12,7 @@
 import com.azure.messaging.servicebus.administration.implementation.models.CreateQueueBodyImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.CreateRuleBodyImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.CreateSubscriptionBodyImpl;
+import com.azure.messaging.servicebus.administration.implementation.models.CreateTopicBodyImpl;
 
 import java.io.IOException;
 import java.lang.reflect.Type;
@@ -44,7 +45,7 @@ public String serialize(Object object, SerializerEncoding encoding) throws IOExc
 
         final Class<?> clazz = object.getClass();
         if (!CreateQueueBodyImpl.class.equals(clazz) && !CreateRuleBodyImpl.class.equals(clazz)
-            && !CreateSubscriptionBodyImpl.class.equals(clazz)) {
+            && !CreateSubscriptionBodyImpl.class.equals(clazz) && !CreateTopicBodyImpl.class.equals(clazz)) {
             return contents;
         }
 

sdk/servicebus/azure-messaging-servicebus/src/test/java/com/azure/messaging/servicebus/implementation/ServiceBusManagementSerializerTest.java

@@ -3,11 +3,14 @@
 
 package com.azure.messaging.servicebus.implementation;
 
+import com.azure.core.util.serializer.SerializerEncoding;
 import com.azure.messaging.servicebus.TestUtils;
 import com.azure.messaging.servicebus.administration.implementation.EntityHelper;
 import com.azure.messaging.servicebus.administration.implementation.ServiceBusManagementSerializer;
 import com.azure.messaging.servicebus.administration.implementation.models.AuthorizationRuleImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.CorrelationFilterImpl;
+import com.azure.messaging.servicebus.administration.implementation.models.CreateTopicBodyContentImpl;
+import com.azure.messaging.servicebus.administration.implementation.models.CreateTopicBodyImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.EmptyRuleActionImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.FalseFilterImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.KeyValueImpl;
@@ -30,6 +33,7 @@
 import com.azure.messaging.servicebus.administration.implementation.models.SubscriptionDescriptionFeedImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.SubscriptionDescriptionImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.TitleImpl;
+import com.azure.messaging.servicebus.administration.implementation.models.TopicDescriptionImpl;
 import com.azure.messaging.servicebus.administration.implementation.models.TrueFilterImpl;
 import com.azure.messaging.servicebus.administration.models.AccessRights;
 import com.azure.messaging.servicebus.administration.models.AuthorizationRule;
@@ -763,6 +767,39 @@ void deserializeRuleEntryResponse() throws IOException {
         assertRuleEntryEquals(expected, actual);
     }
 
+    @Test
+    void serializeTopicDescriptionXML() throws IOException {
+        // Arrange
+        AuthorizationRuleImpl rule = new AuthorizationRuleImpl()
+            .setKeyName("test")
+            .setType("SharedAccessAuthorizationRule")
+            .setRights(Arrays.asList(AccessRights.MANAGE, AccessRights.LISTEN, AccessRights.SEND));
+
+        TopicDescriptionImpl topicDescription = new TopicDescriptionImpl()
+            .setAuthorizationRules(Arrays.asList(rule));
+
+        CreateTopicBodyImpl createTopicBody = new CreateTopicBodyImpl()
+            .setContent(new CreateTopicBodyContentImpl().setTopicDescription(topicDescription));
+
+        // Act
+        String serialized = SERIALIZER.serialize(createTopicBody, SerializerEncoding.XML);
+
+        // Assert
+        assertNotNull(serialized);
+
+        // Note: Technically, the XML created by the serializer is already valid/correct. However, the Azure Service
+        // that consumes the payload does not accept prefixed AuthorizationRule
+        // (ie. wstxns1:AuthorizationRule xmlns:wstxns1=...), so special care needs to be taken to create usable XML.
+
+        // Must contain correct default namespace
+        assertTrue(serialized.contains("<TopicDescription xmlns=\"http://schemas.microsoft.com/netservices/2010/10/servicebus/connect\""),
+            "Serialized payload does not contain correct default namespace");
+
+        // Must not contain prefixed namespace
+        assertTrue(serialized.contains("<AuthorizationRule"),
+            "Serialized payload does not contain AuthorizationRule in default namespace");
+    }
+
     /**
      * Given a file name, gets the corresponding resource and its contents as a string.
      *