Allow for publishing to DevOps feed instead of maven.org (Azure#45764)

weshaggard · web-flow · commit 6ee8e822110b · 2025-06-20T12:54:01.000-07:00
Add feature to enable the Storage team to release to a devops feed instead of public nuget.org for releases. This allows them to do a soft GA where consumers can use the latest GA from the Devops feed if they know their regions have the new storage features. The GA will get published to nuget.org once all the regions have the new features.
diff --git a/eng/pipelines/templates/stages/archetype-java-release-batch.yml b/eng/pipelines/templates/stages/archetype-java-release-batch.yml
@@ -14,11 +14,12 @@ parameters:
   - name: EnableIntegrationStage
     type: boolean
     default: true
-    # A different environment will be passed in for service directories that have
-    # live tests enabled for release and ReleaseDependsOnLiveTests is false
-  - name: Environment
+  - name: PublicPublishEnvironment
     type: string
-    default: 'maven'
+    default: 'package-publish'
+  - name: PublicFeedUrl
+    type: string
+    default: 'maven.org'
 
 stages:
   # The signing stage is responsible for submitting binaries to ESRP for our official signing
@@ -204,41 +205,43 @@ stages:
                   PackageRepository: Maven
                   ReleaseSha: $(Build.SourceVersion)
 
-        - deployment: PublishESRPPackage
-          displayName: "Publish to Maven Central via ESRP"
-          condition: and(succeeded(), ne(variables['Skip.PublishPackage'], 'true'))
-          # This timeout shouldn't be necessary once we're able to parallelize better. Right now,
-          # this is here to ensure larger areas (30+) libraries don't time out.
-          timeoutInMinutes: 120
-          environment: ${{ parameters.Environment }}
-          dependsOn: TagRepository
-
-          templateContext:
-            type: releaseJob
-            isProduction: true
-            inputs:
-            - input: pipelineArtifact
-              artifactName: 'packages-esrp-flattened'
-              targetPath: '$(Pipeline.Workspace)/packages-esrp-flattened'
-          pool:
-            name: azsdk-pool-mms-win-2022-general
-            image: azsdk-pool-mms-win-2022-1espt
-            os: windows
-          strategy:
-            runOnce:
-              deploy:
-                steps:
-                  - template: /eng/pipelines/templates/steps/java-esrp-publishing.yml
-                    parameters:
-                      FlattenedDirectory: $(Pipeline.Workspace)/packages-esrp-flattened
+        - ${{ if eq(parameters.PublicFeedUrl, 'maven.org') }}:
+          - deployment: PublishESRPPackage
+            displayName: "Publish to Maven Central via ESRP"
+            condition: and(succeeded(), ne(variables['Skip.PublishPackage'], 'true'))
+            # This timeout shouldn't be necessary once we're able to parallelize better. Right now,
+            # this is here to ensure larger areas (30+) libraries don't time out.
+            timeoutInMinutes: 120
+            environment: ${{ parameters.PublicPublishEnvironment }}
+            dependsOn: TagRepository
+
+            templateContext:
+              type: releaseJob
+              isProduction: true
+              inputs:
+              - input: pipelineArtifact
+                artifactName: 'packages-esrp-flattened'
+                targetPath: '$(Pipeline.Workspace)/packages-esrp-flattened'
+            pool:
+              name: azsdk-pool
+              image: windows-2022
+              os: windows
+            strategy:
+              runOnce:
+                deploy:
+                  steps:
+                    - template: /eng/pipelines/templates/steps/java-esrp-publishing.yml
+                      parameters:
+                        FlattenedDirectory: $(Pipeline.Workspace)/packages-esrp-flattened
 
         - job: PublishDevFeedPackage
           displayName: "Publish to Java Dev feed"
           condition: and(succeeded(), ne(variables['Skip.PublishPackage'], 'true'))
           # This timeout shouldn't be necessary once we're able to parallelize better. Right now,
           # this is here to ensure larger areas (30+) libraries don't time out.
           timeoutInMinutes: 120
-          dependsOn: PublishESRPPackage
+          ${{ if eq(parameters.PublicFeedUrl, 'maven.org') }}:
+            dependsOn: PublishESRPPackage
           pool:
             name: $(WINDOWSPOOL)
             image: $(WINDOWSVMIMAGE)
@@ -258,17 +261,20 @@ stages:
               displayName: 'Download Artifacts'
               artifact: packages-signed
             - template: tools/gpg/gpg.yml@azure-sdk-build-tools
+
+            - ${{ if ne(parameters.PublicFeedUrl, 'maven.org') }}:
+              - template: /eng/pipelines/templates/steps/java-dev-feed-publishing.yml
+                parameters:
+                  RepositoryUrl: ${{ parameters.PublicFeedUrl }}
+
             # Publish to the azure-sdk-for-java feed.
             - template: /eng/pipelines/templates/steps/java-dev-feed-publishing.yml
-              parameters:
-                ArtifactDirectory: $(Pipeline.Workspace)/packages-signed
-                RepositoryUrl: https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1
-                Target: JavaDevFeed
-                JavaRepoRoot: $(Pipeline.Workspace)/azure-sdk-for-java
+
             - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
               parameters:
                 ArtifactName: packages-javadevfeed-$(System.JobAttempt)
                 ArtifactPath: $(Pipeline.Workspace)/packages-signed
+
             - template: /eng/common/pipelines/templates/steps/create-apireview.yml
               parameters:
                 ArtifactPath: $(Pipeline.Workspace)/packages-signed
@@ -281,7 +287,7 @@ stages:
         - job: UpdatePackageVersion
           displayName: "Update Package Version"
           condition: and(succeeded(), ne(variables['Skip.UpdatePackageVersion'], 'true'))
-          dependsOn: PublishESRPPackage
+          dependsOn: PublishDevFeedPackage
           pool:
             name: $(WINDOWSPOOL)
             image: $(WINDOWSVMIMAGE)
@@ -367,7 +373,7 @@ stages:
         - job: PublishDocs
           displayName: Publish Docs to GitHubIO Blob Storage
           condition: and(succeeded(), ne(variables['Skip.PublishDocs'], 'true'))
-          dependsOn: PublishESRPPackage
+          dependsOn: PublishDevFeedPackage
           pool:
             name: $(WINDOWSPOOL)
             image: $(WINDOWSVMIMAGE)
@@ -399,9 +405,6 @@ stages:
       - job: PublishPackages
         condition: or(eq(variables['SetDevVersion'], 'true'), and(eq(variables['Build.Reason'],'Schedule'), eq(variables['System.TeamProject'], 'internal')))
         displayName: Publish package to daily feed
-        variables:
-          - name: RepositoryUrl
-            value: https://pkgs.dev.azure.com/azure-sdk/internal/_packaging/azure-sdk-for-java-pr/maven/v1
 
         templateContext:
           outputs:
@@ -434,14 +437,16 @@ stages:
         - pwsh: |
             # For safety default to publishing to the private feed.
             # Publish to https://pkgs.dev.azure.com/azure-sdk/internal/_packaging/azure-sdk-for-java-pr/maven/v1
+
+            $devFeedUrl = "https://pkgs.dev.azure.com/azure-sdk/internal/_packaging/azure-sdk-for-java-pr/maven/v1"
             if ('$(Build.Repository.Name)' -eq 'Azure/azure-sdk-for-java') {
-              # Publish to the public feed
-              # Publish to https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1
-              echo "##vso[task.setvariable variable=RepositoryUrl]https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1"
+              $devFeedUrl = "https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1"
               echo "Using Java Public Dev Feed"
             } else {
               echo "Using Java Private Dev Feed"
             }
+            echo "##vso[task.setvariable variable=RepositoryUrl]$devFeedUrl"
+
           displayName: Setup TargetFeed
 
         - template: tools/gpg/gpg.yml@azure-sdk-build-tools
@@ -452,10 +457,7 @@ stages:
               parameters:
                 ArtifactID: ${{artifact.name}}
                 GroupID: ${{artifact.groupId}}
-                ArtifactDirectory: $(Pipeline.Workspace)/packages-signed
                 RepositoryUrl: $(RepositoryUrl)
-                Target: JavaDevFeed
-                JavaRepoRoot: $(Pipeline.Workspace)/azure-sdk-for-java
 
       - job: PublishDocsToNightlyBranch
         dependsOn: PublishPackages
diff --git a/eng/pipelines/templates/stages/archetype-java-release-patch.yml b/eng/pipelines/templates/stages/archetype-java-release-patch.yml
@@ -171,11 +171,6 @@ stages:
             # this is that the azure-sdk-for-java feed will have the package available immediately
             # whereas Maven can take several hours for the package to become available.
             - template: /eng/pipelines/templates/steps/java-dev-feed-publishing.yml
-              parameters:
-                ArtifactDirectory: $(Pipeline.Workspace)/packages-signed
-                RepositoryUrl: https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1
-                Target: JavaDevFeed
-                JavaRepoRoot: $(Pipeline.Workspace)/azure-sdk-for-java
             - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
               parameters:
                 ArtifactName: packages-javadevfeed-$(System.JobAttempt)
diff --git a/eng/pipelines/templates/stages/archetype-java-release-pom-only.yml b/eng/pipelines/templates/stages/archetype-java-release-pom-only.yml
@@ -105,7 +105,7 @@ stages:
           - deployment: PublishESRPPackage
             displayName: "Publish to Maven Central via ESRP"
             condition: and(succeeded(), ne(variables['Skip.PublishPackage'], 'true'))
-            environment: maven
+            environment: package-publish
             dependsOn: TagRepository
 
             templateContext:
@@ -157,11 +157,7 @@ stages:
                 parameters:
                   ArtifactID: ${{artifact.name}}
                   GroupID: ${{artifact.groupId}}
-                  ArtifactDirectory: $(Pipeline.Workspace)/packages-signed
-                  RepositoryUrl: https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1
-                  Target: JavaDevFeed
-                  JavaRepoRoot: $(Pipeline.Workspace)/azure-sdk-for-java
-              - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
+                - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml
                 parameters:
                   ArtifactName: packages-${{artifact.name}}-javadevfeed-$(System.JobAttempt)
                   ArtifactPath: $(Pipeline.Workspace)/packages-signed
diff --git a/eng/pipelines/templates/stages/archetype-sdk-client.yml b/eng/pipelines/templates/stages/archetype-sdk-client.yml
@@ -61,6 +61,12 @@ parameters:
   - name: EnvVars
     type: object
     default: {}
+  - name: PublicFeedUrl
+    type: string
+    default: 'maven.org'
+  - name: PublicPublishEnvironment
+    type: string
+    default: 'package-publish'
 
 extends:
   template: /eng/pipelines/templates/stages/1es-redirect.yml
@@ -152,7 +158,6 @@ extends:
                     - ${{ if ne(artifact.releaseInBatch, 'false') }}:
                         - ${{ artifact }}
               TestPipeline: ${{ parameters.TestPipeline }}
-              # This where the MavenBreakGlassApprovers is set for the release tasks.
-              ${{ if and(in(variables['Build.Reason'], 'Manual', ''), eq(parameters.ReleaseDependsOnLiveTests, 'false')) }}:
-                Environment: 'MavenBreakGlassApprovers'
+              PublicFeedUrl: ${{ parameters.PublicFeedUrl }}
+              PublicPublishEnvironment: ${{ parameters.PublicPublishEnvironment }}
 
diff --git a/eng/pipelines/templates/steps/java-dev-feed-publishing.yml b/eng/pipelines/templates/steps/java-dev-feed-publishing.yml
@@ -1,46 +1,26 @@
 parameters:
-  ArtifactDirectory: not-specified
-  OutputDirectory: not-specified
-  RepositoryUrl: not-specified
+  ArtifactDirectory: $(Pipeline.Workspace)/packages-signed
+  RepositoryUrl: https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-java/maven/v1
   GroupID:
   ArtifactID:
   GPGExecutablePath: $(Pipeline.Workspace)/azure-sdk-build-tools/tools/gpg/bin/gpg.exe
   JavaRepoRoot: $(Pipeline.Workspace)/azure-sdk-for-java
   ShouldPublish: true
 
 steps:
-  - ${{if eq(parameters.Target, 'JavaDevFeed')}}:
-    - task: PowerShell@2
-      displayName: 'Publish to Java Dev Feed'
-      inputs:
-        pwsh: true
-        workingDirectory: $(Agent.BuildDirectory)
-        filePath: ${{ parameters.JavaRepoRoot }}/eng/scripts/Publish-MavenPackages.ps1
-        arguments: >
-          -ArtifactDirectory ${{ parameters.ArtifactDirectory }}
-          -GroupIDFilter "${{ parameters.GroupID }}"
-          -ArtifactIDFilter "${{ parameters.ArtifactID }}"
-          -RepositoryUrl ${{ parameters.RepositoryUrl }}
-          -RepositoryUsername nobody
-          -RepositoryPassword $(System.AccessToken)
-          -GPGExecutablePath ${{ parameters.GPGExecutablePath }}
-          -ShouldPublish:$${{parameters.ShouldPublish}}
-          -InformationAction Continue
-
-  - ${{if eq(parameters.Target, 'AndroidDevFeed')}}:
-    - task: PowerShell@2
-      displayName: 'Publish to Andriod Public Dev Feed'
-      inputs:
-        pwsh: true
-        workingDirectory: $(Agent.BuildDirectory)
-        filePath: ${{ parameters.JavaRepoRoot }}/eng/scripts/Publish-MavenPackages.ps1
-        arguments: >
-          -ArtifactDirectory ${{ parameters.ArtifactDirectory }}
-          -GroupIDFilter "${{ parameters.GroupID }}"
-          -ArtifactIDFilter "${{ parameters.ArtifactID }}"
-          -RepositoryUrl https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-android/maven/v1
-          -RepositoryUsername nobody
-          -RepositoryPassword $(System.AccessToken)
-          -GPGExecutablePath ${{ parameters.GPGExecutablePath }}
-          -ShouldPublish:$${{parameters.ShouldPublish}}
-          -InformationAction Continue
+  - task: PowerShell@2
+    displayName: 'Publish to DevOps Feed ${{ parameters.RepositoryUrl }}'
+    inputs:
+      pwsh: true
+      workingDirectory: $(Agent.BuildDirectory)
+      filePath: ${{ parameters.JavaRepoRoot }}/eng/scripts/Publish-MavenPackages.ps1
+      arguments: >
+        -ArtifactDirectory ${{ parameters.ArtifactDirectory }}
+        -GroupIDFilter "${{ parameters.GroupID }}"
+        -ArtifactIDFilter "${{ parameters.ArtifactID }}"
+        -RepositoryUrl ${{ parameters.RepositoryUrl }}
+        -RepositoryUsername nobody
+        -RepositoryPassword $(System.AccessToken)
+        -GPGExecutablePath ${{ parameters.GPGExecutablePath }}
+        -ShouldPublish:$${{ parameters.ShouldPublish }}
+        -InformationAction Continue
diff --git a/sdk/storage/ci.yml b/sdk/storage/ci.yml
@@ -110,10 +110,16 @@ parameters:
   displayName: 'azure-storage-queue'
   type: boolean
   default: true
+- name: ReleaseToDevOpsOnly
+  displayName: 'Release package to DevOps feed instead of maven.org'
+  type: boolean
+  default: false
 
 extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
+    ${{ if eq(parameters.ReleaseToDevOpsOnly, true) }}:
+      PublicFeedUrl: 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/storage-staging/maven/v1'
     ServiceDirectory: storage
     Artifacts:
       - name: azure-storage-common
diff --git a/sdk/template/ci.yml b/sdk/template/ci.yml
@@ -64,11 +64,23 @@ parameters:
     values:
       - release
       - canary
+  - name: ReleaseToDevOpsOnly
+    displayName: 'Release package to DevOps feed instead of maven.org'
+    type: boolean
+    default: false
+  - name: AutoApproveRelease
+    displayName: 'Automatically approve the release stage'
+    type: boolean
+    default: false
 
 extends:
   template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     oneESTemplateTag: ${{ parameters.oneESTemplateTag }}
+    ${{ if eq(parameters.ReleaseToDevOpsOnly, true) }}:
+      PublicFeedUrl: 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/storage-staging/maven/v1'
+    ${{ if eq(parameters.AutoApproveRelease, true) }}:
+      PublicPublishEnvironment: none
     ServiceDirectory: template
     ReleaseDependsOnLiveTests: ${{ parameters.release_dependsonlivetests }}
     # If you're copying template for a new pipeline, remove this variable. It is only valid for the template pipeline.
