Don't call .toString() or .length() on null strings/urls (Azure#44933)

* changes to logging

* pr comments

Author: harsimar

sdk/monitor/azure-monitor-opentelemetry-autoconfigure/src/main/java/com/azure/monitor/opentelemetry/autoconfigure/implementation/quickpulse/QuickPulse.java

@@ -24,6 +24,7 @@
 import java.util.concurrent.Executors;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Supplier;
+import java.util.Objects;
 
 public class QuickPulse {
 
@@ -81,8 +82,8 @@ private void initialize(HttpPipeline httpPipeline, Supplier<URL> endpointUrl, Su
         if (LOGGER.canLogAtLevel(LogLevel.VERBOSE)) {
             LOGGER.verbose(
                 "Initializing QuickPulse with instrumentation key: {} , URL {}, rolename {}, role instance {}, sdk version {}",
-                IKeyMasker.mask(instrumentationKey.get()), endpointUrl.get().toString(), roleName, roleInstance,
-                sdkVersion);
+                Objects.toString(IKeyMasker.mask(instrumentationKey.get())), Objects.toString(endpointUrl.get()),
+                roleName, roleInstance, sdkVersion);
         }
 
         String quickPulseId = UUID.randomUUID().toString().replace("-", "");

sdk/monitor/azure-monitor-opentelemetry-autoconfigure/src/main/java/com/azure/monitor/opentelemetry/autoconfigure/implementation/quickpulse/QuickPulseDataSender.java

@@ -12,13 +12,15 @@
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.CollectionConfigurationInfo;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.MonitoringDataPoint;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.PublishHeaders;
+import com.azure.monitor.opentelemetry.autoconfigure.implementation.utils.IKeyMasker;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.utils.Strings;
 
 import java.io.IOException;
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
+import java.util.Objects;
 import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Supplier;
@@ -55,7 +57,7 @@ class QuickPulseDataSender implements Runnable {
         this.instrumentationKey = instrumentationKey;
         this.configuration = configuration;
         logger.verbose("QuickPulseDataSender initialized with endpointUrl: {}, instrumentationKey: {}",
-            endpointUrl.get().toString(), instrumentationKey.get());
+            Objects.toString(endpointUrl.get()), Objects.toString(IKeyMasker.mask(instrumentationKey.get())));
     }
 
     @Override

sdk/monitor/azure-monitor-opentelemetry-autoconfigure/src/main/java/com/azure/monitor/opentelemetry/autoconfigure/implementation/utils/IKeyMasker.java

@@ -12,7 +12,7 @@ private IKeyMasker() {
 
     public static String mask(String instrumentationKey) {
         // Tests could set the connection string with a short one
-        if (instrumentationKey.length() > CHARACTERS_TO_KEEP_AT_END) {
+        if (instrumentationKey != null && instrumentationKey.length() > CHARACTERS_TO_KEEP_AT_END) {
             return "*" + instrumentationKey.substring(instrumentationKey.length() - CHARACTERS_TO_KEEP_AT_END);
         }
         return instrumentationKey;