Migrate to stream style serialization - Azure communication Identity (Azure#40967)

Author: samvaity

eng/code-quality-reports/src/main/resources/revapi/revapi.json

@@ -582,6 +582,14 @@
           "code": "java.missing.oldSuperType",
           "old": "class com.azure.resourcemanager.network.models.FirewallPacketCaptureParameters",
           "justification": "service bug fix."
+        },
+        {
+          "ignore": true,
+          "code": "java.annotation.removed",
+          "old": "method com.azure.communication.identity.models.CommunicationTokenScope com.azure.communication.identity.models.CommunicationTokenScope::fromString(java.lang.String)",
+          "new": "method com.azure.communication.identity.models.CommunicationTokenScope com.azure.communication.identity.models.CommunicationTokenScope::fromString(java.lang.String)",
+          "annotation": "@com.fasterxml.jackson.annotation.JsonCreator",
+          "justification": "Migration to azure-json"
         }
       ]
     }

sdk/communication/azure-communication-identity/src/main/java/com/azure/communication/identity/implementation/CommunicationIdentitiesImpl.java

@@ -6,68 +6,79 @@
 
 import com.azure.core.http.HttpPipeline;
 import com.azure.core.http.HttpPipelineBuilder;
-import com.azure.core.http.policy.CookiePolicy;
 import com.azure.core.http.policy.RetryPolicy;
 import com.azure.core.http.policy.UserAgentPolicy;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 
-/** Initializes a new instance of the CommunicationIdentityClient type. */
+/**
+ * Initializes a new instance of the CommunicationIdentityClient type.
+ */
 public final class CommunicationIdentityClientImpl {
-    /** The communication resource, for example https://my-resource.communication.azure.com. */
+    /**
+     * The communication resource, for example https://my-resource.communication.azure.com.
+     */
     private final String endpoint;
 
     /**
      * Gets The communication resource, for example https://my-resource.communication.azure.com.
-     *
+     * 
      * @return the endpoint value.
      */
     public String getEndpoint() {
         return this.endpoint;
     }
 
-    /** Api Version. */
+    /**
+     * Api Version.
+     */
     private final String apiVersion;
 
     /**
      * Gets Api Version.
-     *
+     * 
      * @return the apiVersion value.
      */
     public String getApiVersion() {
         return this.apiVersion;
     }
 
-    /** The HTTP pipeline to send requests through. */
+    /**
+     * The HTTP pipeline to send requests through.
+     */
     private final HttpPipeline httpPipeline;
 
     /**
      * Gets The HTTP pipeline to send requests through.
-     *
+     * 
      * @return the httpPipeline value.
      */
     public HttpPipeline getHttpPipeline() {
         return this.httpPipeline;
     }
 
-    /** The serializer to serialize an object into a string. */
+    /**
+     * The serializer to serialize an object into a string.
+     */
     private final SerializerAdapter serializerAdapter;
 
     /**
      * Gets The serializer to serialize an object into a string.
-     *
+     * 
      * @return the serializerAdapter value.
      */
     public SerializerAdapter getSerializerAdapter() {
         return this.serializerAdapter;
     }
 
-    /** The CommunicationIdentitiesImpl object to access its operations. */
+    /**
+     * The CommunicationIdentitiesImpl object to access its operations.
+     */
     private final CommunicationIdentitiesImpl communicationIdentities;
 
     /**
      * Gets the CommunicationIdentitiesImpl object to access its operations.
-     *
+     * 
      * @return the CommunicationIdentitiesImpl object.
      */
     public CommunicationIdentitiesImpl getCommunicationIdentities() {
@@ -76,23 +87,18 @@ public CommunicationIdentitiesImpl getCommunicationIdentities() {
 
     /**
      * Initializes an instance of CommunicationIdentityClient client.
-     *
+     * 
      * @param endpoint The communication resource, for example https://my-resource.communication.azure.com.
      * @param apiVersion Api Version.
      */
     public CommunicationIdentityClientImpl(String endpoint, String apiVersion) {
-        this(
-                new HttpPipelineBuilder()
-                        .policies(new UserAgentPolicy(), new RetryPolicy(), new CookiePolicy())
-                        .build(),
-                JacksonAdapter.createDefaultSerializerAdapter(),
-                endpoint,
-                apiVersion);
+        this(new HttpPipelineBuilder().policies(new UserAgentPolicy(), new RetryPolicy()).build(),
+            JacksonAdapter.createDefaultSerializerAdapter(), endpoint, apiVersion);
     }
 
     /**
      * Initializes an instance of CommunicationIdentityClient client.
-     *
+     * 
      * @param httpPipeline The HTTP pipeline to send requests through.
      * @param endpoint The communication resource, for example https://my-resource.communication.azure.com.
      * @param apiVersion Api Version.
@@ -103,14 +109,14 @@ public CommunicationIdentityClientImpl(HttpPipeline httpPipeline, String endpoin
 
     /**
      * Initializes an instance of CommunicationIdentityClient client.
-     *
+     * 
      * @param httpPipeline The HTTP pipeline to send requests through.
      * @param serializerAdapter The serializer to serialize an object into a string.
      * @param endpoint The communication resource, for example https://my-resource.communication.azure.com.
      * @param apiVersion Api Version.
      */
-    public CommunicationIdentityClientImpl(
-            HttpPipeline httpPipeline, SerializerAdapter serializerAdapter, String endpoint, String apiVersion) {
+    public CommunicationIdentityClientImpl(HttpPipeline httpPipeline, SerializerAdapter serializerAdapter,
+        String endpoint, String apiVersion) {
         this.httpPipeline = httpPipeline;
         this.serializerAdapter = serializerAdapter;
         this.endpoint = endpoint;

sdk/communication/azure-communication-identity/src/main/java/com/azure/communication/identity/implementation/CommunicationIdentityClientImpl.java

@@ -5,48 +5,52 @@
 package com.azure.communication.identity.implementation.models;
 
 import com.azure.core.annotation.Fluent;
-import com.fasterxml.jackson.annotation.JsonProperty;
+import com.azure.json.JsonReader;
+import com.azure.json.JsonSerializable;
+import com.azure.json.JsonToken;
+import com.azure.json.JsonWriter;
+import java.io.IOException;
 import java.util.List;
 
-/** The Communication Services error. */
+/**
+ * The Communication Services error.
+ */
 @Fluent
-public final class CommunicationError {
+public final class CommunicationError implements JsonSerializable<CommunicationError> {
     /*
      * The error code.
      */
-    @JsonProperty(value = "code", required = true)
     private String code;
 
     /*
      * The error message.
      */
-    @JsonProperty(value = "message", required = true)
     private String message;
 
     /*
      * The error target.
      */
-    @JsonProperty(value = "target", access = JsonProperty.Access.WRITE_ONLY)
     private String target;
 
     /*
      * Further details about specific errors that led to this error.
      */
-    @JsonProperty(value = "details", access = JsonProperty.Access.WRITE_ONLY)
     private List<CommunicationError> details;
 
     /*
      * The inner error if any.
      */
-    @JsonProperty(value = "innererror", access = JsonProperty.Access.WRITE_ONLY)
     private CommunicationError innerError;
 
-    /** Creates an instance of CommunicationError class. */
-    public CommunicationError() {}
+    /**
+     * Creates an instance of CommunicationError class.
+     */
+    public CommunicationError() {
+    }
 
     /**
      * Get the code property: The error code.
-     *
+     * 
      * @return the code value.
      */
     public String getCode() {
@@ -55,7 +59,7 @@ public String getCode() {
 
     /**
      * Set the code property: The error code.
-     *
+     * 
      * @param code the code value to set.
      * @return the CommunicationError object itself.
      */
@@ -66,7 +70,7 @@ public CommunicationError setCode(String code) {
 
     /**
      * Get the message property: The error message.
-     *
+     * 
      * @return the message value.
      */
     public String getMessage() {
@@ -75,7 +79,7 @@ public String getMessage() {
 
     /**
      * Set the message property: The error message.
-     *
+     * 
      * @param message the message value to set.
      * @return the CommunicationError object itself.
      */
@@ -86,7 +90,7 @@ public CommunicationError setMessage(String message) {
 
     /**
      * Get the target property: The error target.
-     *
+     * 
      * @return the target value.
      */
     public String getTarget() {
@@ -95,7 +99,7 @@ public String getTarget() {
 
     /**
      * Get the details property: Further details about specific errors that led to this error.
-     *
+     * 
      * @return the details value.
      */
     public List<CommunicationError> getDetails() {
@@ -104,10 +108,55 @@ public List<CommunicationError> getDetails() {
 
     /**
      * Get the innerError property: The inner error if any.
-     *
+     * 
      * @return the innerError value.
      */
     public CommunicationError getInnerError() {
         return this.innerError;
     }
+
+    @Override
+    public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
+        jsonWriter.writeStartObject();
+        jsonWriter.writeStringField("code", this.code);
+        jsonWriter.writeStringField("message", this.message);
+        return jsonWriter.writeEndObject();
+    }
+
+    /**
+     * Reads an instance of CommunicationError from the JsonReader.
+     * 
+     * @param jsonReader The JsonReader being read.
+     * @return An instance of CommunicationError if the JsonReader was pointing to an instance of it, or null if it was
+     * pointing to JSON null.
+     * @throws IllegalStateException If the deserialized JSON object was missing any required properties.
+     * @throws IOException If an error occurs while reading the CommunicationError.
+     */
+    public static CommunicationError fromJson(JsonReader jsonReader) throws IOException {
+        return jsonReader.readObject(reader -> {
+            CommunicationError deserializedCommunicationError = new CommunicationError();
+            while (reader.nextToken() != JsonToken.END_OBJECT) {
+                String fieldName = reader.getFieldName();
+                reader.nextToken();
+
+                if ("code".equals(fieldName)) {
+                    deserializedCommunicationError.code = reader.getString();
+                } else if ("message".equals(fieldName)) {
+                    deserializedCommunicationError.message = reader.getString();
+                } else if ("target".equals(fieldName)) {
+                    deserializedCommunicationError.target = reader.getString();
+                } else if ("details".equals(fieldName)) {
+                    List<CommunicationError> details
+                        = reader.readArray(reader1 -> CommunicationError.fromJson(reader1));
+                    deserializedCommunicationError.details = details;
+                } else if ("innererror".equals(fieldName)) {
+                    deserializedCommunicationError.innerError = CommunicationError.fromJson(reader);
+                } else {
+                    reader.skipChildren();
+                }
+            }
+
+            return deserializedCommunicationError;
+        });
+    }
 }