Skip to content

Commit d134454

Browse files
authored
API Review Updates. (Azure#44039)
* API Review Updates. * Fixing linting report.
1 parent 80edb6c commit d134454

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

eng/code-quality-reports/src/main/resources/revapi/revapi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@
204204
},
205205
{
206206
"code": "java.method.addedToInterface",
207-
"new" : "method <T> long com.azure.spring.data.cosmos.core.CosmosOperations::sum(com.azure.cosmos.models.SqlQuerySpec, java.lang.String)",
207+
"new" : "method long com.azure.spring.data.cosmos.core.CosmosOperations::sum(com.azure.cosmos.models.SqlQuerySpec, java.lang.String)",
208208
"justification": "Spring interfaces are allowed to add methods."
209209
},
210210
{

sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/CosmosOperations.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,10 +372,9 @@ public interface CosmosOperations {
372372
*
373373
* @param querySpec the document query spec
374374
* @param containerName the container name
375-
* @param <T> type class of domainType
376375
* @return sum result
377376
*/
378-
<T> long sum(SqlQuerySpec querySpec, String containerName);
377+
long sum(SqlQuerySpec querySpec, String containerName);
379378

380379
/**
381380
* To get converter

sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/CosmosTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1136,7 +1136,7 @@ public <T> long count(SqlQuerySpec querySpec, String containerName) {
11361136
}
11371137

11381138
@Override
1139-
public <T> long sum(SqlQuerySpec querySpec, String containerName) {
1139+
public long sum(SqlQuerySpec querySpec, String containerName) {
11401140
return this.numeric(querySpec, containerName);
11411141
}
11421142

sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/repository/support/StringBasedCosmosQuery.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ protected boolean isCountQuery() {
137137
* This method is used to determine if the query is a sum query.
138138
* @return boolean if the query is a sum query
139139
*/
140-
protected boolean isSumQuery() {
140+
boolean isSumQuery() {
141141
return isSumQuery(query, getQueryMethod().getReturnedObjectType());
142142
}
143143

0 commit comments

Comments
 (0)