Fix issue#34555 [BUG] Missing Null check in for loop (Azure#35078)

v-hongli1 · web-flow · commit d34fecda6cca · 2023-05-23T13:10:12.000+08:00
diff --git a/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/AvailabilitySetImpl.java b/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/AvailabilitySetImpl.java
@@ -63,10 +63,12 @@ public AvailabilitySetSkuTypes sku() {
 
     @Override
     public Set<String> virtualMachineIds() {
-        if (idOfVMsInSet == null) {
+        if (idOfVMsInSet == null && this.innerModel().virtualMachines() != null) {
             idOfVMsInSet = new HashSet<>();
             for (SubResource resource : this.innerModel().virtualMachines()) {
-                idOfVMsInSet.add(resource.id());
+                if (resource != null) {
+                    idOfVMsInSet.add(resource.id());
+                }
             }
         }
         return Collections.unmodifiableSet(idOfVMsInSet);

Original file line number	Diff line number	Diff line change
`@@ -63,10 +63,12 @@ public AvailabilitySetSkuTypes sku() {`
`63`	`63`
`64`	`64`	`@Override`
`65`	`65`	`public Set<String> virtualMachineIds() {`
`66`		`- if (idOfVMsInSet == null) {`
	`66`	`+ if (idOfVMsInSet == null && this.innerModel().virtualMachines() != null) {`
`67`	`67`	`idOfVMsInSet = new HashSet<>();`
`68`	`68`	`for (SubResource resource : this.innerModel().virtualMachines()) {`
`69`		`- idOfVMsInSet.add(resource.id());`
	`69`	`+ if (resource != null) {`
	`70`	`+ idOfVMsInSet.add(resource.id());`
	`71`	`+ }`
`70`	`72`	`}`
`71`	`73`	`}`
`72`	`74`	`return Collections.unmodifiableSet(idOfVMsInSet);`