Skip to content

Commit e7d5245

Browse files
heyamstrask
andauthored
Collect AKS attach rate numerator (Azure#37123)
* Fix a todo * Remove space Co-authored-by: Trask Stalnaker <[email protected]> * Fix test --------- Co-authored-by: Trask Stalnaker <[email protected]>
1 parent 11339c7 commit e7d5245

File tree

2 files changed

+6
-4
lines changed
  • sdk/monitor/azure-monitor-opentelemetry-exporter/src

2 files changed

+6
-4
lines changed

sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/AttachStatsbeat.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ static String initResourceProviderId(
7676
} else {
7777
return UNKNOWN_RP_ID;
7878
}
79-
case RP_AKS: // TODO will update resourceProviderId when cluster_id becomes available from the
80-
// AKS AzureMetadataService extension.
79+
case RP_AKS:
80+
return envVarFn.apply("AKS_ARM_NAMESPACE_ID");
8181
case UNKNOWN:
8282
return UNKNOWN_RP_ID;
8383
}

sdk/monitor/azure-monitor-opentelemetry-exporter/src/test/java/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/AttachStatsbeatTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,10 @@ public void testFunctionsResourceProviderId() {
7373

7474
@Test
7575
public void testAksResourceProviderId() {
76-
assertThat(AttachStatsbeat.initResourceProviderId(ResourceProvider.RP_AKS, null, key -> null))
77-
.isEqualTo("unknown");
76+
Map<String, String> envVars = new HashMap<>();
77+
envVars.put("AKS_ARM_NAMESPACE_ID", "test_aks_rp_id");
78+
assertThat(AttachStatsbeat.initResourceProviderId(ResourceProvider.RP_AKS, null, envVars::get))
79+
.isEqualTo("test_aks_rp_id");
7880
}
7981

8082
@Test

0 commit comments

Comments
 (0)