Skip to content

Commit faf958b

Browse files
authored
Further implement http-netty4 package (Azure#44890)
Further implement http-netty4 package
1 parent c62b9d5 commit faf958b

File tree

67 files changed

+5320
-553
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+5320
-553
lines changed

.vscode/cspell.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@
203203
"sdk/devcenter/azure-developer-devcenter/**",
204204
"sdk/loadtesting/azure-developer-loadtesting/**",
205205
"sdk/clientcore/core/**",
206-
"sdk/clientcore/http-netty/**",
206+
"sdk/clientcore/http-netty4/**",
207207
"sdk/clientcore/http-okhttp3/**",
208208
"sdk/clientcore/annotation-processor/**",
209209
"sdk/clientcore/annotation-processor-test/**",

eng/.docsettings.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ known_content_issues:
9898
- ['sdk/core/README.md', '#3113']
9999
- ['sdk/clientcore/README.md', '#3113']
100100
- ['sdk/clientcore/core/README.md', '#3113']
101-
- ['sdk/clientcore/http-netty/README.md', '#3113']
101+
- ['sdk/clientcore/http-netty4/README.md', '#3113']
102102
- ['sdk/clientcore/http-okhttp3/README.md', '#3113']
103103
- ['sdk/clientcore/tools/annotation-processor/README.md', '#3113']
104104
- ['sdk/clientcore/optional-dependency-tests/README.md', '#3113']

eng/versioning/version_client.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,13 +481,13 @@ com.azure.v2:azure-core-test;2.0.0-beta.1;2.0.0-beta.1
481481
com.azure.v2:azure-identity;2.0.0-beta.1;2.0.0-beta.1
482482
io.clientcore:clientcore-parent;1.0.0-beta.3;1.0.0-beta.3
483483
io.clientcore:core;1.0.0-beta.8;1.0.0-beta.9
484+
io.clientcore:http-netty4;1.0.0-beta.1;1.0.0-beta.1
484485
io.clientcore:http-okhttp3;1.0.0-beta.2;1.0.0-beta.3
485486
io.clientcore:http-stress;1.0.0-beta.1;1.0.0-beta.1
486487
io.clientcore:optional-dependency-tests;1.0.0-beta.1;1.0.0-beta.1
487488
io.clientcore:annotation-processor;1.0.0-beta.1;1.0.0-beta.2
488489
io.clientcore:annotation-processor-test;1.0.0-beta.1;1.0.0-beta.1
489490

490-
491491
# Unreleased dependencies: Copy the entry from above, prepend "unreleased_" and remove the current
492492
# version. Unreleased dependencies are only valid for dependency versions.
493493
# Format;

sdk/clientcore/annotation-processor/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
<dependency>
114114
<groupId>io.clientcore</groupId>
115115
<artifactId>core</artifactId>
116-
<version>1.0.0-beta.9</version> <!-- {x-version-update;io.clientcore:core;dependency} -->
116+
<version>1.0.0-beta.8</version> <!-- {x-version-update;io.clientcore:core;dependency} -->
117117
</dependency>
118118

119119
<!-- Unit Test -->

sdk/clientcore/ci.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ parameters:
3030
displayName: 'core'
3131
type: boolean
3232
default: true
33-
- name: release_clientcorehttpokhttp3
33+
- name: release_httpnetty4
34+
displayName: 'http-netty4'
35+
type: boolean
36+
default: false
37+
- name: release_httpokhttp3
3438
displayName: 'http-okhttp3'
3539
type: boolean
3640
default: false
@@ -52,10 +56,14 @@ extends:
5256
releaseInBatch: ${{ parameters.release_core }}
5357
triggeringPaths:
5458
- /sdk/parents/clientcore-parent
59+
- name: http-netty4
60+
groupId: io.clientcore
61+
safeName: httpnetty4
62+
releaseInBatch: ${{ parameters.release_httpnetty4 }}
5563
- name: http-okhttp3
5664
groupId: io.clientcore
5765
safeName: httpokhttp3
58-
releaseInBatch: ${{ parameters.release_clientcorehttpokhttp3 }}
66+
releaseInBatch: ${{ parameters.release_httpokhttp3 }}
5967
AdditionalModules:
6068
- name: optional-dependency-tests
6169
groupId: io.clientcore

sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/HttpHeader.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
*/
2424
@Metadata(properties = MetadataProperties.FLUENT)
2525
public final class HttpHeader {
26-
private static final String[] EMPTY_HEADER_ARRAY = new String[0];
2726

2827
private final HttpHeaderName name;
2928

@@ -114,21 +113,6 @@ public String getValue() {
114113
return CACHED_STRING_VALUE_UPDATER.get(this);
115114
}
116115

117-
/**
118-
* Gets the comma separated value as an array. Changes made to this array will not be reflected in the headers.
119-
*
120-
* @return the values of this {@link HttpHeader} that are separated by a comma
121-
*/
122-
String[] getValuesArray() {
123-
if (value != null) {
124-
return new String[] { value };
125-
} else if (!isNullOrEmpty(values)) {
126-
return values.toArray(new String[0]);
127-
} else {
128-
return EMPTY_HEADER_ARRAY;
129-
}
130-
}
131-
132116
/**
133117
* Returns all values associated with this header, represented as an unmodifiable list of strings.
134118
*

sdk/clientcore/core/src/test/java/io/clientcore/core/http/client/SimpleBasicAuthHttpProxyServer.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,11 @@ public ProxyEndpoint start() {
4545
if (proxyAuthorization == null) {
4646
resp.setStatus(407);
4747
resp.setHeader("Proxy-Authenticate", "Basic");
48-
4948
return;
5049
}
5150

5251
if (!proxyAuthorization.startsWith("Basic")) {
5352
resp.setStatus(401);
54-
5553
return;
5654
}
5755

sdk/clientcore/core/src/test/java/io/clientcore/core/shared/HttpClientTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public abstract class HttpClientTests {
8080
private static final String UTF_32BE_BOM_RESPONSE = "utf32BeBomBytes";
8181
private static final String UTF_32LE_BOM_RESPONSE = "utf32LeBomBytes";
8282
private static final String BOM_WITH_DIFFERENT_HEADER = "bomBytesWithDifferentHeader";
83-
private static final String SSE_RESPONSE = "serversentevent";
8483

8584
protected static final String ECHO_RESPONSE = "echo";
8685

sdk/clientcore/http-netty/checkstyle-suppressions.xml

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdk/clientcore/http-netty/spotbugs-exclude.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)