Skip to content

Commit 4e3aba1

Browse files
authored
[Test][core] inline build:test commands into browser test scripts (Azure#29411)
As far as I know for NodeJS the majority of our packages don't need `build:test` as we either runs test on .ts files, or `build` script already generates the .js files under `dist-esm`. Currently we only need to build the test for browser testing. This PR moves commands in `build:test` into the browser test scripts for core packages, thus saving us from rebuilding when testing for NodeJS.
1 parent 7a0c520 commit 4e3aba1

File tree

19 files changed

+62
-63
lines changed

19 files changed

+62
-63
lines changed

sdk/core/abort-controller/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
],
5858
"scripts": {
5959
"build:samples": "echo Obsolete",
60-
"build:test": "npm run clean && tshy && dev-tool run build-test",
60+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
6161
"build": "npm run clean && tshy && dev-tool run extract-api",
6262
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,mjs,cjs,json}\"",
6363
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -70,10 +70,10 @@
7070
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
7171
"lint": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts",
7272
"pack": "npm pack 2>&1",
73-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
73+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
7474
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
7575
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run build-test && npm run unit-test:browser && npm run integration-test",
76-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
76+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7777
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7878
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7979
},

sdk/core/core-amqp/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"scripts": {
3434
"bundle": "tsc -p . && dev-tool run bundle --polyfill-node false --inject-node-polyfills true --ignore-missing-node-builtins true",
3535
"build:samples": "echo Obsolete",
36-
"build:test": "tsc -p . && npm run bundle",
36+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
3737
"build": "npm run clean && tsc -p . && dev-tool run bundle && dev-tool run extract-api",
3838
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"",
3939
"clean": "rimraf --glob dist dist-* temp types coverage coverage-browser .nyc_output *.tgz *.log test*.xml",
@@ -46,10 +46,10 @@
4646
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
4747
"lint": "eslint package.json api-extractor.json src test --ext .ts",
4848
"pack": "npm pack 2>&1",
49-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
49+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
5050
"test:node": "npm run clean && tsc -p . && npm run unit-test:node && npm run integration-test:node",
5151
"test": "npm run clean && tsc -p . && npm run unit-test:node && npm run bundle && npm run unit-test:browser && npm run integration-test",
52-
"unit-test:browser": "karma start --single-run",
52+
"unit-test:browser": "tsc -p . && npm run bundle && karma start --single-run",
5353
"unit-test:node": "cross-env TS_NODE_FILES=true dev-tool run test:node-ts-input --no-test-proxy",
5454
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
5555
},

sdk/core/core-auth/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"sideEffects": false,
5252
"scripts": {
5353
"build:samples": "echo Obsolete",
54-
"build:test": "npm run clean && tshy && dev-tool run build-test",
54+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5555
"build": "npm run clean && tshy && dev-tool run extract-api",
5656
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
5757
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -64,10 +64,10 @@
6464
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
6565
"lint": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts",
6666
"pack": "npm pack 2>&1",
67-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
67+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
6868
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
6969
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run bundle && npm run unit-test:browser && npm run integration-test",
70-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
70+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7171
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7272
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7373
},

sdk/core/core-client-rest/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
5252
"scripts": {
5353
"build:samples": "echo Obsolete",
54-
"build:test": "npm run clean && tshy && dev-tool run build-test",
54+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5555
"build": "npm run clean && tshy && dev-tool run extract-api",
5656
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
5757
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -64,10 +64,10 @@
6464
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
6565
"lint": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts",
6666
"pack": "npm pack 2>&1",
67-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
67+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
6868
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
6969
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run bundle && npm run unit-test:browser && npm run integration-test",
70-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
70+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7171
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7272
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7373
},

sdk/core/core-client/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
5252
"scripts": {
5353
"build:samples": "echo Obsolete",
54-
"build:test": "npm run clean && tshy && dev-tool run build-test",
54+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5555
"build": "npm run clean && tshy && dev-tool run extract-api",
5656
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
5757
"clean": "rimraf --glob dist temp types *.tgz *.log",
@@ -64,10 +64,10 @@
6464
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
6565
"lint": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts",
6666
"pack": "npm pack 2>&1",
67-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
67+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
6868
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
6969
"test": "npm run clean && tshy && npm run unit-test:node && npm run unit-test:browser && npm run integration-test",
70-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
70+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7171
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7272
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7373
},

sdk/core/core-http-compat/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
5252
"scripts": {
5353
"build:samples": "echo Obsolete",
54-
"build:test": "npm run clean && tshy && dev-tool run build-test",
54+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5555
"build": "npm run clean && tshy && dev-tool run extract-api",
5656
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,mts}\" \"test/**/*.{ts,mts}\" \"*.{js,cjs,mjs,json}\"",
5757
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -67,7 +67,7 @@
6767
"test:browser": "echo skipped",
6868
"test:node": "echo skipped",
6969
"test": "npm run clean && npm run build && npm run unit-test:node && npm run unit-test:browser && npm run integration-test",
70-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
70+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7171
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7272
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7373
},

sdk/core/core-lro/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"sideEffects": false,
6767
"scripts": {
6868
"build:samples": "echo Obsolete",
69-
"build:test": "npm run clean && tshy && dev-tool run build-test",
69+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
7070
"build": "npm run clean && tshy && dev-tool run extract-api",
7171
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
7272
"clean": "rimraf --glob dist dist-* types *.log browser statistics.html coverage src/**/*.js test/**/*.js",
@@ -79,10 +79,10 @@
7979
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
8080
"lint": "eslint package.json api-extractor.json src test --ext .ts --ext .cts --ext .mts",
8181
"pack": "npm pack 2>&1",
82-
"test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
83-
"test:node": "npm run build:test && npm run unit-test:node && npm run integration-test:node",
84-
"test": "npm run build:test && npm run unit-test",
85-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
82+
"test:browser": "npm run unit-test:browser && npm run integration-test:browser",
83+
"test:node": "npm run unit-test:node && npm run integration-test:node",
84+
"test": "npm run unit-test",
85+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
8686
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
8787
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
8888
},

sdk/core/core-paging/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"private": false,
5858
"scripts": {
5959
"build:samples": "echo Obsolete",
60-
"build:test": "npm run clean && tshy && dev-tool run build-test",
60+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
6161
"build": "npm run clean && tshy && dev-tool run extract-api",
6262
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
6363
"clean": "rimraf --glob dist dist-* temp *.tgz types *.log",
@@ -70,10 +70,10 @@
7070
"lint": "eslint package.json src --ext .ts --ext .cts --ext .mts",
7171
"lint:fix": "eslint package.json src --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
7272
"pack": "npm pack 2>&1",
73-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
73+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
7474
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
7575
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run build-test && npm run unit-test:browser && npm run integration-test",
76-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
76+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7777
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7878
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7979
},

sdk/core/core-rest-pipeline/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
5252
"scripts": {
5353
"build:samples": "echo Obsolete",
54-
"build:test": "npm run clean && tshy && dev-tool run build-test",
54+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5555
"build": "npm run clean && tshy && dev-tool run extract-api",
5656
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
5757
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -64,10 +64,10 @@
6464
"lint:fix": "eslint package.json api-extractor.json src --ext .ts --ext .cts --ext .mts --fix --fix-type [problem,suggestion]",
6565
"lint": "eslint package.json api-extractor.json src --ext .ts --ext .cts --ext .mts",
6666
"pack": "npm pack 2>&1",
67-
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
67+
"test:browser": "npm run clean && npm run unit-test:browser && npm run integration-test:browser",
6868
"test:node": "npm run clean && tshy && npm run unit-test:node && npm run integration-test:node",
6969
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run build-test && npm run unit-test:browser && npm run integration-test",
70-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
70+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7171
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7272
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7373
},

sdk/core/core-sse/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
5656
"scripts": {
5757
"build:samples": "echo Obsolete",
58-
"build:test": "npm run clean && tshy && dev-tool run build-test",
58+
"build:test": "echo skipped. actual commands inlined in browser test scripts",
5959
"build": "npm run clean && tshy && dev-tool run extract-api",
6060
"check-format": "dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.{ts,cts,mts}\" \"test/**/*.{ts,cts,mts}\" \"*.{js,cjs,mjs,json}\"",
6161
"clean": "rimraf --glob dist dist-* temp types *.tgz *.log",
@@ -71,7 +71,7 @@
7171
"test:browser": "npm run clean && npm run build && npm run integration-test:browser",
7272
"test:node": "npm run clean && tshy && npm run integration-test:node",
7373
"test": "npm run clean && tshy && npm run unit-test:node && dev-tool run build-test && npm run unit-test:browser && npm run integration-test",
74-
"unit-test:browser": "npm run build:test && dev-tool run test:vitest --no-test-proxy --browser",
74+
"unit-test:browser": "npm run clean && tshy && dev-tool run build-test && dev-tool run test:vitest --no-test-proxy --browser",
7575
"unit-test:node": "dev-tool run test:vitest --no-test-proxy",
7676
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
7777
},

0 commit comments

Comments
 (0)