Skip to content

Commit 66ea1d8

Browse files
jeremymengjeremymeng
authored
[core-amqp,event-hubs,service-bus] upgrade rhea-promise dependency version to ^3.0.0 (Azure#25070)
1 parent 8c77abb commit 66ea1d8

File tree

10 files changed

+52
-29
lines changed

10 files changed

+52
-29
lines changed

‎common/config/rush/pnpm-lock.yaml

Lines changed: 22 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sdk/core/core-amqp/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Release History
22

3-
## 3.2.3 (Unreleased)
3+
## 3.3.0 (Unreleased)
44

55
### Features Added
66

@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- upgrade dependency `rhea-promise` version to `^3.0.0`.
14+
1315
## 3.2.2 (2023-02-02)
1416

1517
### Other Changes

‎sdk/core/core-amqp/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@azure/core-amqp",
33
"sdk-type": "client",
4-
"version": "3.2.3",
4+
"version": "3.3.0",
55
"description": "Common library for amqp based azure sdks like @azure/event-hubs.",
66
"author": "Microsoft Corporation",
77
"license": "MIT",
@@ -80,7 +80,7 @@
8080
"jssha": "^3.1.0",
8181
"process": "^0.11.10",
8282
"rhea": "^2.0.3",
83-
"rhea-promise": "^2.1.0",
83+
"rhea-promise": "^3.0.0",
8484
"tslib": "^2.2.0",
8585
"util": "^0.12.1"
8686
},

‎sdk/core/core-amqp/test/context.spec.ts

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import * as chai from "chai";
55
const should = chai.should();
66
import { CbsClient, ConnectionConfig, ConnectionContextBase } from "../src";
77
import { Connection } from "rhea-promise";
8+
import { ConnectionOptions as TlsConnectionOptions } from "tls";
89

910
describe("ConnectionContextBase", function () {
1011
it("should be created with required parameters", function (done) {
@@ -53,7 +54,8 @@ describe("ConnectionContextBase", function () {
5354
should.exist(context.connectionLock);
5455
should.exist(context.negotiateClaimLock);
5556
context.connection.options.hostname!.should.equal("hostname.servicebus.windows.net");
56-
context.connection.options.host!.should.equal("hostname.servicebus.windows.net");
57+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
58+
tlsConnectionOptions.host!.should.equal("hostname.servicebus.windows.net");
5759
context.wasConnectionCloseCalled.should.equal(false);
5860
context.connection.should.instanceOf(Connection);
5961
context.connection.options.properties!.product.should.equal("MSJSClient");
@@ -82,7 +84,8 @@ describe("ConnectionContextBase", function () {
8284
should.exist(context.connectionLock);
8385
should.exist(context.negotiateClaimLock);
8486
context.connection.options.hostname!.should.equal("127.0.0.1");
85-
context.connection.options.host!.should.equal("hostname.servicebus.windows.net");
87+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
88+
tlsConnectionOptions.host!.should.equal("hostname.servicebus.windows.net");
8689
context.wasConnectionCloseCalled.should.equal(false);
8790
context.connection.should.instanceOf(Connection);
8891
context.connection.options.properties!.product.should.equal("MSJSClient");
@@ -110,7 +113,8 @@ describe("ConnectionContextBase", function () {
110113
should.exist(context.connectionId);
111114
should.exist(context.connectionLock);
112115
should.exist(context.negotiateClaimLock);
113-
context.connection.options.port!.should.equal(1111);
116+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
117+
tlsConnectionOptions.port!.should.equal(1111);
114118
context.wasConnectionCloseCalled.should.equal(false);
115119
context.connection.should.instanceOf(Connection);
116120
context.connection.options.properties!.product.should.equal("MSJSClient");
@@ -137,7 +141,8 @@ describe("ConnectionContextBase", function () {
137141
should.exist(context.connectionId);
138142
should.exist(context.connectionLock);
139143
should.exist(context.negotiateClaimLock);
140-
context.connection.options.port!.should.equal(5671);
144+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
145+
tlsConnectionOptions.port!.should.equal(5671);
141146
context.wasConnectionCloseCalled.should.equal(false);
142147
context.connection.should.instanceOf(Connection);
143148
context.connection.options.properties!.product.should.equal("MSJSClient");
@@ -170,7 +175,8 @@ describe("ConnectionContextBase", function () {
170175
should.exist(context.connectionId);
171176
should.exist(context.connectionLock);
172177
should.exist(context.negotiateClaimLock);
173-
context.connection.options.host!.should.equal("127.0.0.1");
178+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
179+
tlsConnectionOptions.host!.should.equal("127.0.0.1");
174180
context.connection.options.hostname!.should.equal("hostname.servicebus.windows.net");
175181
context.wasConnectionCloseCalled.should.equal(false);
176182
context.connection.should.instanceOf(Connection);
@@ -237,7 +243,8 @@ describe("ConnectionContextBase", function () {
237243
should.exist(context.connectionId);
238244
should.exist(context.connectionLock);
239245
should.exist(context.negotiateClaimLock);
240-
context.connection.options.port!.should.equal(1111);
246+
const tlsConnectionOptions = context.connection.options as TlsConnectionOptions;
247+
tlsConnectionOptions.port!.should.equal(1111);
241248
context.wasConnectionCloseCalled.should.equal(false);
242249
context.connection.should.instanceOf(Connection);
243250
context.connection.options.properties!.product.should.equal("MSJSClient");

‎sdk/eventhub/event-hubs/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Release History
22

3-
## 5.9.1 (Unreleased)
3+
## 5.10.0 (Unreleased)
44

55
### Features Added
66

@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- upgrade dependency `rhea-promise` version to `^3.0.0`.
14+
1315
## 5.9.0 (2023-03-07)
1416

1517
### Bugs Fixed

‎sdk/eventhub/event-hubs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@azure/event-hubs",
33
"sdk-type": "client",
4-
"version": "5.9.1",
4+
"version": "5.10.0",
55
"description": "Azure Event Hubs SDK for JS.",
66
"author": "Microsoft Corporation",
77
"license": "MIT",
@@ -116,7 +116,7 @@
116116
"is-buffer": "^2.0.3",
117117
"jssha": "^3.1.0",
118118
"process": "^0.11.10",
119-
"rhea-promise": "^2.1.0",
119+
"rhea-promise": "^3.0.0",
120120
"tslib": "^2.2.0",
121121
"uuid": "^8.3.0"
122122
},

‎sdk/eventhub/event-hubs/src/util/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77
export const packageJsonInfo = {
88
name: "@azure/event-hubs",
9-
version: "5.9.1",
9+
version: "5.10.0",
1010
};
1111

1212
/**

‎sdk/servicebus/service-bus/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Release History
22

3-
## 7.8.2 (Unreleased)
3+
## 7.9.0 (Unreleased)
44

55
### Features Added
66

@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- upgrade dependency `rhea-promise` version to `^3.0.0`.
14+
1315
## 7.8.1 (2023-03-07)
1416

1517
### Bugs Fixed

‎sdk/servicebus/service-bus/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@azure/service-bus",
33
"sdk-type": "client",
44
"author": "Microsoft Corporation",
5-
"version": "7.8.2",
5+
"version": "7.9.0",
66
"license": "MIT",
77
"description": "Azure Service Bus SDK for JavaScript",
88
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/servicebus/service-bus/",
@@ -126,7 +126,7 @@
126126
"long": "^5.2.0",
127127
"process": "^0.11.10",
128128
"tslib": "^2.2.0",
129-
"rhea-promise": "^2.1.0"
129+
"rhea-promise": "^3.0.0"
130130
},
131131
"devDependencies": {
132132
"@azure/dev-tool": "^1.0.0",

‎sdk/servicebus/service-bus/src/util/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77
export const packageJsonInfo = {
88
name: "@azure/service-bus",
9-
version: "7.8.2",
9+
version: "7.9.0",
1010
};
1111

1212
/**

0 commit comments

Comments
 (0)