Skip to content

Commit a43aaf3

Browse files
authored
Upgrade jsonwebtoken to address security vulnerability (Azure#24340)
### Packages impacted by this PR @azure/identity, @azure/web-pubsub, @azure/web-pubsub-express, and @azure/web-pubsub-client Live tests runs: - [Identity](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2081318&view=results) - [webpubsub](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2081328&view=results) ### Issues associated with this PR Fixes Azure#24337 Fixes Azure#24336 Fixes Azure#24334 ### Describe the problem that is addressed by this PR There is a security vulnerability in v8 of the jsonwebtoken library. However, I can't shake the vulnerable version off our lock file completely because @azure/msal-node depends on it and they didn't make a release with the upgraded dependency yet, [see my comment on their PR](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/5503/files#r1058120234). ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
1 parent 28b2aa2 commit a43aaf3

File tree

6 files changed

+47
-35
lines changed

6 files changed

+47
-35
lines changed

common/config/rush/pnpm-lock.yaml

Lines changed: 39 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/identity/identity/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
"@azure/test-utils": "^1.0.0",
129129
"@microsoft/api-extractor": "^7.31.1",
130130
"@types/chai": "^4.1.6",
131-
"@types/jsonwebtoken": "~8.5.0",
131+
"@types/jsonwebtoken": "^9.0.0",
132132
"@types/jws": "^3.2.2",
133133
"@types/mocha": "^7.0.2",
134134
"@types/ms": "^0.7.31",
@@ -141,7 +141,7 @@
141141
"dotenv": "^16.0.0",
142142
"eslint": "^8.0.0",
143143
"inherits": "^2.0.3",
144-
"jsonwebtoken": "^8.5.1",
144+
"jsonwebtoken": "^9.0.0",
145145
"karma": "^6.2.0",
146146
"karma-chrome-launcher": "^3.0.0",
147147
"karma-coverage": "^2.0.0",

sdk/web-pubsub/web-pubsub-client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"@types/chai-as-promised": "^7.1.5",
7777
"@types/express": "^4.16.0",
7878
"@types/express-serve-static-core": "^4.17.19",
79-
"@types/jsonwebtoken": "~8.5.0",
79+
"@types/jsonwebtoken": "^9.0.0",
8080
"@types/mocha": "^7.0.2",
8181
"@types/node": "^12.0.0",
8282
"@types/sinon": "^9.0.4",

sdk/web-pubsub/web-pubsub-express/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"@types/chai": "^4.1.6",
6666
"@types/express": "^4.16.0",
6767
"@types/express-serve-static-core": "^4.17.19",
68-
"@types/jsonwebtoken": "~8.5.0",
68+
"@types/jsonwebtoken": "^9.0.0",
6969
"@types/mocha": "^7.0.2",
7070
"@types/node": "^14.0.0",
7171
"@types/sinon": "^9.0.4",

sdk/web-pubsub/web-pubsub/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- Bumped the version of the jsonwebtoken dependency to v9.
14+
1315
## 1.1.0 (2022-11-11)
1416

1517
### Features Added

sdk/web-pubsub/web-pubsub/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"@azure/core-tracing": "^1.0.0",
7676
"@azure/logger": "^1.0.0",
7777
"tslib": "^2.2.0",
78-
"jsonwebtoken": "^8.5.1"
78+
"jsonwebtoken": "^9.0.0"
7979
},
8080
"devDependencies": {
8181
"@azure/dev-tool": "^1.0.0",
@@ -85,7 +85,7 @@
8585
"@azure-tools/test-recorder": "^2.0.0",
8686
"@microsoft/api-extractor": "^7.31.1",
8787
"@types/chai": "^4.1.6",
88-
"@types/jsonwebtoken": "~8.5.0",
88+
"@types/jsonwebtoken": "^9.0.0",
8989
"@types/mocha": "^7.0.2",
9090
"@types/node": "^14.0.0",
9191
"@types/sinon": "^9.0.4",

0 commit comments

Comments
 (0)