Skip to content

Commit b6249f6

Browse files
authored
[engsys] turn off sort-imports linter rule (Azure#23549)
because - the default sorting rules are strange - no automation to fix all the violations - benefit not worth the effort required to fix the violations
1 parent 1906b99 commit b6249f6

File tree

22 files changed

+11
-92
lines changed

22 files changed

+11
-92
lines changed

common/tools/eslint-plugin-azure-sdk/.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"no-multi-spaces": "error",
3535
"no-redeclare": "error",
3636
"no-useless-escape": "off",
37-
"prefer-template": "error",
38-
"sort-imports": "error"
37+
"prefer-template": "error"
3938
}
4039
}

common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default {
6666
"no-var": "error",
6767
"one-var-declaration-per-line": "error",
6868
"prefer-const": "error",
69-
"sort-imports": "warn",
69+
"sort-imports": "off",
7070
"spaced-comment": ["error", "always", { markers: ["/"] }],
7171
"space-infix-ops": ["error", { int32Hint: false }],
7272
"use-isnan": "error",

sdk/core/abort-controller/.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"plugins": ["@azure/azure-sdk"],
33
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
44
"rules": {
5-
"@azure/azure-sdk/ts-package-json-types": "off",
6-
"sort-imports": "error"
5+
"@azure/azure-sdk/ts-package-json-types": "off"
76
}
87
}

sdk/core/core-amqp/.eslintrc.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

sdk/core/core-auth/.eslintrc.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

sdk/core/core-client/.eslintrc.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

sdk/core/core-http/.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"@azure/azure-sdk/ts-apiextractor-json-types": "off",
77
"@azure/azure-sdk/ts-package-json-types": "off",
88
"@azure/azure-sdk/ts-package-json-module": "off",
9-
"@azure/azure-sdk/ts-package-json-files-required": "off",
10-
"sort-imports": "error"
9+
"@azure/azure-sdk/ts-package-json-files-required": "off"
1110
}
1211
}

sdk/core/core-lro/.eslintrc.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

sdk/core/core-paging/.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"rules": {
55
// `package.json`'s sideEffects has to be true because this package loads a
66
// polyfill.
7-
"@azure/azure-sdk/ts-package-json-sideeffects": "off",
8-
"sort-imports": "error"
7+
"@azure/azure-sdk/ts-package-json-sideeffects": "off"
98
}
109
}

sdk/core/core-tracing/.eslintrc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
44
"rules": {
55
"@azure/azure-sdk/ts-no-const-enums": "off",
6-
"@azure/azure-sdk/ts-versioning-semver": "warn",
7-
"sort-imports": "error"
6+
"@azure/azure-sdk/ts-versioning-semver": "warn"
87
}
98
}

0 commit comments

Comments
 (0)