Skip to content

Commit c365b54

Browse files
authored
[dev-tool] Fix build error in full rush update (Azure#23972)
Our dependency `concurrently` updates `ConcurrentlyCommandInput` type to be better in https://github.com/open-cli-tools/concurrently/pull/374/files#diff-c5f81f4f40df5fad240a4291b8b00ad455a1ede66ba398cb675ff7d9b5e7d051 This PR reacts to it by enforcing correct type of the input `testCommandObj` parameter. ``` src/util/testUtils.ts:54:19 - error TS2345: Argument of type 'Partial<Command>' is not assignable to parameter of type 'ConcurrentlyCommandInput'. Type 'Partial<Command>' is not assignable to type '{ command: string; } & Partial<CommandInfo>'. Type 'Partial<Command>' is not assignable to type '{ command: string; }'. Types of property 'command' are incompatible. Type 'string | undefined' is not assignable to type 'string'. Type 'undefined' is not assignable to type 'string'. 54 commands.push(testCommandObj); ~~~~~~~~~~~~~~ ```
1 parent 73eeae8 commit c365b54

File tree

3 files changed

+27
-25
lines changed

3 files changed

+27
-25
lines changed

common/config/rush/pnpm-lock.yaml

Lines changed: 25 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/tools/dev-tool/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"private": true,
4141
"prettier": "../eslint-plugin-azure-sdk/prettier.json",
4242
"dependencies": {
43-
"concurrently": "^7.1.0",
43+
"concurrently": "^7.6.0",
4444
"chalk": "~4.1.1",
4545
"dotenv": "^8.2.0",
4646
"fs-extra": "^10.0.0",

common/tools/dev-tool/src/util/testUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ async function shouldRunProxyTool(): Promise<boolean> {
2929
}
3030

3131
export async function runTestsWithProxyTool(
32-
testCommandObj: Partial<ConcurrentlyCommand>
32+
testCommandObj: Partial<ConcurrentlyCommand> & { command: string }
3333
): Promise<boolean> {
3434
const commands: ConcurrentlyCommandInput[] = [];
3535
let concurrentlyOptions: Partial<ConcurrentlyOptions> | undefined;

0 commit comments

Comments
 (0)