Repro for content-length being set (Azure#23332)

Author: timovv

sdk/test-utils/recorder/test/testProxyTests.spec.ts

@@ -2,6 +2,8 @@
 // Licensed under the MIT license.
 
 import { ServiceClient } from "@azure/core-client";
+import { createPipelineRequest } from "@azure/core-rest-pipeline";
+import { expect } from "chai";
 import { CustomMatcherOptions, isPlaybackMode, Recorder } from "../src";
 import { isLiveMode, TestMode } from "../src/utils/utils";
 import { getTestServerUrl, makeRequestAndVerifyResponse, setTestMode } from "./utils/utils";
@@ -90,6 +92,21 @@ import { getTestServerUrl, makeRequestAndVerifyResponse, setTestMode } from "./u
       );
     });
 
+    describe("does not add a content-length header unnecessarily", () =>
+      (["GET", "DELETE"] as const).forEach((method) =>
+        it(`to a ${method} request`, async () => {
+          await recorder.start({ envSetupForPlayback: {} });
+          const req = createPipelineRequest({
+            url: getTestServerUrl() + "/content_length_test",
+            method,
+            allowInsecureConnection: isLiveMode(),
+          });
+
+          const rsp = await client.sendRequest(req);
+          expect(rsp.status).to.be.within(200, 299);
+        })
+      ));
+
     // Matchers
     describe("Matchers", () => {
       it("BodilessMatcher", async () => {

sdk/test-utils/recorder/test/utils/server.ts

@@ -76,6 +76,14 @@ app.get("/api/sample_uuid_in_header", function (_, res) {
   res.send();
 });
 
+app.all("/content_length_test", function (req, res) {
+  if (["GET", "DELETE"].includes(req.method) && req.header("Content-Length")) {
+    res.status(400).json({ error: "Content-Length header should not be present" });
+  } else {
+    res.status(204).send();
+  }
+});
+
 app.listen(port, () => {
   console.log(`server started at ${TEST_SERVER_URL}`);
 });