Update ActivityExtensions mark failed after review (Azure#49759)

* Update ActivityExtensions.MarkFailed name from review

* export api and fix samples

Author: m-redding

sdk/core/System.ClientModel/api/System.ClientModel.net6.0.cs

@@ -64,7 +64,7 @@ namespace System.ClientModel.Primitives
 {
     public static partial class ActivityExtensions
     {
-        public static System.Diagnostics.Activity MarkFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
+        public static System.Diagnostics.Activity MarkClientActivityFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
         public static System.Diagnostics.Activity? StartClientActivity(this System.Diagnostics.ActivitySource activitySource, System.ClientModel.Primitives.ClientPipelineOptions options, string name, System.Diagnostics.ActivityKind kind = System.Diagnostics.ActivityKind.Internal, System.Diagnostics.ActivityContext parentContext = default(System.Diagnostics.ActivityContext), System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object?>>? tags = null) { throw null; }
     }
     public partial class ApiKeyAuthenticationPolicy : System.ClientModel.Primitives.PipelinePolicy

sdk/core/System.ClientModel/api/System.ClientModel.net8.0.cs

@@ -64,7 +64,7 @@ namespace System.ClientModel.Primitives
 {
     public static partial class ActivityExtensions
     {
-        public static System.Diagnostics.Activity MarkFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
+        public static System.Diagnostics.Activity MarkClientActivityFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
         public static System.Diagnostics.Activity? StartClientActivity(this System.Diagnostics.ActivitySource activitySource, System.ClientModel.Primitives.ClientPipelineOptions options, string name, System.Diagnostics.ActivityKind kind = System.Diagnostics.ActivityKind.Internal, System.Diagnostics.ActivityContext parentContext = default(System.Diagnostics.ActivityContext), System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object?>>? tags = null) { throw null; }
     }
     public partial class ApiKeyAuthenticationPolicy : System.ClientModel.Primitives.PipelinePolicy

sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs

@@ -64,7 +64,7 @@ namespace System.ClientModel.Primitives
 {
     public static partial class ActivityExtensions
     {
-        public static System.Diagnostics.Activity MarkFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
+        public static System.Diagnostics.Activity MarkClientActivityFailed(this System.Diagnostics.Activity activity, System.Exception? exception) { throw null; }
         public static System.Diagnostics.Activity? StartClientActivity(this System.Diagnostics.ActivitySource activitySource, System.ClientModel.Primitives.ClientPipelineOptions options, string name, System.Diagnostics.ActivityKind kind = System.Diagnostics.ActivityKind.Internal, System.Diagnostics.ActivityContext parentContext = default(System.Diagnostics.ActivityContext), System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object?>>? tags = null) { throw null; }
     }
     public partial class ApiKeyAuthenticationPolicy : System.ClientModel.Primitives.PipelinePolicy

sdk/core/System.ClientModel/samples/Diagnostics.md

@@ -80,7 +80,7 @@ public class SampleClient
         catch (Exception ex)
         {
             // Catch any exceptions and update the activity. Then re-throw the exception.
-            activity?.MarkFailed(ex);
+            activity?.MarkClientActivityFailed(ex);
             throw;
         }
     }

sdk/core/System.ClientModel/src/Convenience/ActivityExtensions.cs

@@ -69,7 +69,7 @@ public static class ActivityExtensions
     /// to implement distributed tracing.</remarks>
     /// <param name="activity">The activity to mark as failed.</param>
     /// <param name="exception">The <see cref="Exception"/> encountered during the operation.</param>
-    public static Activity MarkFailed(this Activity activity, Exception? exception)
+    public static Activity MarkClientActivityFailed(this Activity activity, Exception? exception)
     {
         // See: https://opentelemetry.io/docs/specs/semconv/general/recording-errors/
 

sdk/core/System.ClientModel/tests/Convenience/ActivityExtensionsTests.cs

@@ -168,7 +168,7 @@ public void FailureIsMarkedWithStatus()
         MockPipelineResponse response = new(500, "Internal Server error");
         ClientResultException exception = new(message, response);
 
-        activity?.MarkFailed(exception);
+        activity?.MarkClientActivityFailed(exception);
 
         Assert.NotNull(activity);
         Assert.AreEqual(message, activity!.StatusDescription);
@@ -191,7 +191,7 @@ public void FailureIsMarkedWithExceptionType()
         string message = "Value cannot be null. (Parameter 'parameter')";
 #endif
 
-        activity?.MarkFailed(exception);
+        activity?.MarkClientActivityFailed(exception);
 
         Assert.NotNull(activity);
         Assert.AreEqual(message, activity!.StatusDescription);
@@ -207,7 +207,7 @@ public void FailureIsMarkedWithOther()
 
         using Activity? activity = activitySource.StartClientActivity(options, "Client.Method");
 
-        activity?.MarkFailed(null);
+        activity?.MarkClientActivityFailed(null);
 
         Assert.NotNull(activity);
         Assert.AreEqual(null, activity!.StatusDescription);

sdk/core/System.ClientModel/tests/Samples/DiagnosticsSamples.cs

@@ -70,7 +70,7 @@ public ClientResult<SampleResource> UpdateResource(SampleResource resource)
             catch (Exception ex)
             {
                 // Catch any exceptions and update the activity. Then re-throw the exception.
-                activity?.MarkFailed(ex);
+                activity?.MarkClientActivityFailed(ex);
                 throw;
             }
         }