Making maxtonestocollect required (Azure#31148)

Author: cochi2

sdk/communication/Azure.Communication.CallingServer/api/Azure.Communication.CallingServer.netstandard2.0.cs

@@ -227,9 +227,9 @@ protected CallMedia() { }
     }
     public partial class CallMediaRecognizeDtmfOptions : Azure.Communication.CallingServer.CallMediaRecognizeOptions
     {
-        public CallMediaRecognizeDtmfOptions(Azure.Communication.CommunicationIdentifier targetParticipant) : base (default(Azure.Communication.CallingServer.RecognizeInputType), default(Azure.Communication.CommunicationIdentifier)) { }
+        public CallMediaRecognizeDtmfOptions(Azure.Communication.CommunicationIdentifier targetParticipant, int maxTonesToCollect) : base (default(Azure.Communication.CallingServer.RecognizeInputType), default(Azure.Communication.CommunicationIdentifier)) { }
         public System.TimeSpan InterToneTimeout { get { throw null; } set { } }
-        public int MaxTonesToCollect { get { throw null; } set { } }
+        public int MaxTonesToCollect { get { throw null; } }
         public System.Collections.Generic.IReadOnlyList<Azure.Communication.CallingServer.DtmfTone> StopTones { get { throw null; } set { } }
     }
     public abstract partial class CallMediaRecognizeOptions

sdk/communication/Azure.Communication.CallingServer/src/Models/CallMediaRecognizeDtmfOptions.cs

@@ -14,9 +14,10 @@ public class CallMediaRecognizeDtmfOptions : CallMediaRecognizeOptions
         private static readonly TimeSpan _defaultInterToneTimeout = TimeSpan.FromSeconds(2);
 
         /// <summary> Initializes a new instance of CallMediaRecognizeDtmfOptions. </summary>
-        public CallMediaRecognizeDtmfOptions(CommunicationIdentifier targetParticipant) : base(RecognizeInputType.Dtmf, targetParticipant)
+        public CallMediaRecognizeDtmfOptions(CommunicationIdentifier targetParticipant, int maxTonesToCollect) : base(RecognizeInputType.Dtmf, targetParticipant)
         {
             StopTones = Array.Empty<DtmfTone>();
+            MaxTonesToCollect = maxTonesToCollect;
         }
 
         /// <summary>
@@ -28,7 +29,7 @@ public CallMediaRecognizeDtmfOptions(CommunicationIdentifier targetParticipant)
         /// <summary>
         /// Maximum number of DTMF tones to be collected.
         /// </summary>
-        public int MaxTonesToCollect { get; set; }
+        public int MaxTonesToCollect { get; }
 
         /// <summary>
         /// List of tones that will stop recognizing.

sdk/communication/Azure.Communication.CallingServer/tests/CallMedia/CallMediaTests.cs

@@ -21,18 +21,17 @@ public class CallMediaTests : CallAutomationTestBase
             Loop = false,
             OperationContext = "context"
         };
-        private static readonly CallMediaRecognizeOptions _fullRecognizeOptions = new CallMediaRecognizeDtmfOptions(new CommunicationUserIdentifier("targetUserId"))
+        private static readonly CallMediaRecognizeOptions _fullRecognizeOptions = new CallMediaRecognizeDtmfOptions(new CommunicationUserIdentifier("targetUserId"), maxTonesToCollect: 5)
         {
             InterruptCallMediaOperation = true,
             InterToneTimeout = TimeSpan.FromSeconds(10),
-            MaxTonesToCollect = 5,
             StopTones = new DtmfTone[] { DtmfTone.Pound },
             InitialSilenceTimeout = TimeSpan.FromSeconds(5),
             InterruptPrompt = true,
             OperationContext = "operationContext",
             Prompt = new FileSource(new Uri("https://localhost"))
         };
-        private static readonly CallMediaRecognizeOptions _emptyRecognizeOptions = new CallMediaRecognizeDtmfOptions(new CommunicationUserIdentifier("targetUserId"));
+        private static readonly CallMediaRecognizeOptions _emptyRecognizeOptions = new CallMediaRecognizeDtmfOptions(new CommunicationUserIdentifier("targetUserId"), maxTonesToCollect: 1);
 
         private static CallMedia? _callMedia;