Skip to content

Commit 1aa5107

Browse files
author
Timothy Mothra
authored
[AzureMonitor] move LiveMetrics tests to new project (Azure#48676)
* move LiveMetrics tests to new project * cleanup * disable specific sql tests in netfx
1 parent 2a600ff commit 1aa5107

24 files changed

+132
-84
lines changed

sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@
3030
<Compile Include="..\..\..\Azure.Monitor.OpenTelemetry.Exporter\tests\Azure.Monitor.OpenTelemetry.Exporter.Tests\CommonTestFramework\TelemetryItemOutputHelper.cs" LinkBase="CommonTestFramework" />
3131
</ItemGroup>
3232

33-
<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
34-
<FrameworkReference Include="Microsoft.AspNetCore.App" />
35-
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="6.0.21" />
36-
</ItemGroup>
37-
3833
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
3934
<FrameworkReference Include="Microsoft.AspNetCore.App" />
4035
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="8.0.7" />

sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureMonitorAspNetCoreEventSourceTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class AzureMonitorAspNetCoreEventSourceTests
1313
/// This validates that parameters are logged and helps to confirm that EventIds are correct.
1414
/// </summary>
1515
[Fact]
16-
public void EventSourceTest_AzureMonitorExporterEventSource()
16+
public void EventSourceTest_AzureMonitorAspNetCoreEventSource()
1717
{
1818
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(AzureMonitorAspNetCoreEventSource.Log);
1919
}

sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/LiveMetrics/LiveMetricsPolingIntervalTests.cs

Lines changed: 0 additions & 39 deletions
This file was deleted.

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.Runtime.CompilerServices;
55

66
[assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.LiveMetrics.Demo, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")]
7+
[assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.LiveMetrics.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")]
78

89
// Moq
910
[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7")]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<Project Sdk="Microsoft.NET.Sdk">
2+
3+
<PropertyGroup>
4+
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
5+
<NoWarn>SA1636</NoWarn>
6+
<Nullable>enable</Nullable>
7+
</PropertyGroup>
8+
9+
<ItemGroup>
10+
<PackageReference Include="Microsoft.Data.SqlClient" />
11+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
12+
<PackageReference Include="Moq" />
13+
<PackageReference Include="OpenTelemetry.Exporter.InMemory" />
14+
<PackageReference Include="xunit" />
15+
<PackageReference Include="xunit.runner.visualstudio" />
16+
17+
<PackageReference Include="OpenTelemetry.Extensions.Hosting" />
18+
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" />
19+
<PackageReference Include="OpenTelemetry.Instrumentation.Http" />
20+
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" />
21+
</ItemGroup>
22+
23+
<ItemGroup>
24+
<ProjectReference Include="$(AzureCoreTestFramework)" />
25+
<ProjectReference Include="..\..\..\Azure.Monitor.OpenTelemetry.AspNetCore\tests\Azure.Monitor.AspNetCoreTestApp\Azure.Monitor.AspNetCoreTestApp.csproj" />
26+
<ProjectReference Include="..\..\..\Azure.Monitor.OpenTelemetry.Exporter\src\Azure.Monitor.OpenTelemetry.Exporter.csproj" />
27+
<ProjectReference Include="..\..\src\Azure.Monitor.OpenTelemetry.LiveMetrics.csproj" />
28+
</ItemGroup>
29+
30+
<ItemGroup>
31+
<Compile Include="$(AzureCoreSharedSources)AzureEventSource.cs" LinkBase="SharedSource\Azure.Core" />
32+
<Compile Include="..\..\..\Azure.Monitor.OpenTelemetry.Exporter\tests\Azure.Monitor.OpenTelemetry.Exporter.Tests\CommonTestFramework\EventSourceTestHelper.cs" LinkBase="CommonTestFramework" />
33+
<Compile Include="..\..\..\Azure.Monitor.OpenTelemetry.Exporter\tests\Azure.Monitor.OpenTelemetry.Exporter.Tests\CommonTestFramework\TestEventListener.cs" LinkBase="CommonTestFramework" />
34+
</ItemGroup>
35+
36+
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
37+
<FrameworkReference Include="Microsoft.AspNetCore.App" />
38+
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="8.0.7" />
39+
</ItemGroup>
40+
41+
<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
42+
<FrameworkReference Include="Microsoft.AspNetCore.App" />
43+
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="9.0.0" />
44+
</ItemGroup>
45+
46+
</Project>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
// Copyright (c) Microsoft Corporation. All rights reserved.
2+
// Licensed under the MIT License.
3+
4+
using Xunit;
5+
using Azure.Monitor.OpenTelemetry.Exporter.Tests.CommonTestFramework;
6+
7+
namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Tests
8+
{
9+
public class AzureMonitorLiveMetricsEventSourceTests
10+
{
11+
/// <summary>
12+
/// This test uses reflection to invoke every Event method in our EventSource class.
13+
/// This validates that parameters are logged and helps to confirm that EventIds are correct.
14+
/// </summary>
15+
[Fact]
16+
public void EventSourceTest_AzureMonitorLiveMetricsrEventSource()
17+
{
18+
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(AzureMonitorLiveMetricsEventSource.Log);
19+
}
20+
}
21+
}
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@
77
using System.Linq;
88
using Azure.Monitor.OpenTelemetry.LiveMetrics.Internals.DataCollection;
99
using Azure.Monitor.OpenTelemetry.LiveMetrics.Models;
10-
using OpenTelemetry.Trace;
1110
using Xunit;
1211
using Xunit.Abstractions;
1312

14-
namespace Azure.Monitor.OpenTelemetry.AspNetCore.Tests.LiveMetrics.DocumentTests
13+
namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Tests.DocumentTests
1514
{
1615
public class ActivityEventTests : DocumentTestBase
1716
{
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
using Xunit;
1111
using Xunit.Abstractions;
1212

13-
namespace Azure.Monitor.OpenTelemetry.AspNetCore.Tests.LiveMetrics.DocumentTests
13+
namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Tests.DocumentTests
1414
{
1515
public abstract class DocumentTestBase
1616
{
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
using Xunit;
1616
using Xunit.Abstractions;
1717

18-
namespace Azure.Monitor.OpenTelemetry.AspNetCore.Tests.LiveMetrics.DocumentTests
18+
namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Tests.DocumentTests
1919
{
2020
public class HttpClientDependecyTests : DocumentTestBase
2121
{
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
using Xunit;
1212
using Xunit.Abstractions;
1313

14-
namespace Azure.Monitor.OpenTelemetry.AspNetCore.Tests.LiveMetrics.DocumentTests
14+
namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Tests.DocumentTests
1515
{
1616
public class LogTests : DocumentTestBase
1717
{

0 commit comments

Comments
 (0)