Replace ResourceDataProvdier with ResoruceVisitor (Azure#48362)

Author: live1206

eng/Packages.Data.props

@@ -262,7 +262,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250211.5" />
+    <PackageReference Update="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250223.1" />
   </ItemGroup>
 
   <!--

eng/packages/http-client-csharp/emitter/src/emitter.ts

@@ -5,12 +5,12 @@ import { EmitContext } from "@typespec/compiler";
 
 import {
   $onEmit as $OnMGCEmit,
-  NetEmitterOptions,
+  CSharpEmitterOptions,
   setSDKContextOptions
 } from "@typespec/http-client-csharp";
 import { azureSDKContextOptions } from "./sdk-context-options.js";
 
-export async function $onEmit(context: EmitContext<NetEmitterOptions>) {
+export async function $onEmit(context: EmitContext<CSharpEmitterOptions>) {
   context.options["plugin-name"] ??= "AzureClientPlugin";
   context.options["emitter-extension-path"] = import.meta.url;
   setSDKContextOptions(azureSDKContextOptions);

eng/packages/http-client-csharp/eng/scripts/Generate.ps1

@@ -80,6 +80,7 @@ $failingSpecs = @(
     Join-Path 'http' 'encode' 'datetime'
     Join-Path 'http' 'encode' 'duration'
     Join-Path 'http' 'parameters' 'collection-format'
+    Join-Path 'http' 'response' 'status-code-range' # Response namespace conflicts with Azure.Response
     Join-Path 'http' 'routes'
     Join-Path 'http' 'type' 'array'
     Join-Path 'http' 'type' 'dictionary'

eng/packages/http-client-csharp/generator/Azure.Generator.StubLibrary/src/AzureStubVisitor.cs

@@ -18,7 +18,7 @@ internal class AzureStubVisitor : ScmLibraryVisitor
         private readonly ValueExpression _throwNull = ThrowExpression(Null);
         private readonly XmlDocProvider _emptyDocs = new();
 
-        protected override TypeProvider? Visit(TypeProvider type)
+        protected override TypeProvider? VisitType(TypeProvider type)
         {
             if (!type.DeclarationModifiers.HasFlag(TypeSignatureModifiers.Public) &&
                 !type.Name.StartsWith("Unknown", StringComparison.Ordinal) &&
@@ -31,7 +31,7 @@ internal class AzureStubVisitor : ScmLibraryVisitor
             return type;
         }
 
-        protected override TypeProvider? PostVisit(TypeProvider type)
+        protected override TypeProvider? PostVisitType(TypeProvider type)
         {
             if (type is RestClientProvider &&
                 type.Methods.Count == 0 &&
@@ -45,7 +45,7 @@ internal class AzureStubVisitor : ScmLibraryVisitor
             return type;
         }
 
-        protected override ConstructorProvider? Visit(ConstructorProvider constructor)
+        protected override ConstructorProvider? VisitConstructor(ConstructorProvider constructor)
         {
             if (!IsCallingBaseCtor(constructor) &&
                 !IsEffectivelyPublic(constructor.Signature.Modifiers) &&
@@ -69,15 +69,15 @@ private static bool IsCallingBaseCtor(ConstructorProvider constructor)
                 constructor.Signature.Initializer.Arguments.Count > 0;
         }
 
-        protected override FieldProvider? Visit(FieldProvider field)
+        protected override FieldProvider? VisitField(FieldProvider field)
         {
             // For ClientOptions, keep the non-public field as this currently represents the latest service version for a client.
             return (field.Modifiers.HasFlag(FieldModifiers.Public) || field.EnclosingType.Implements.Any(i => i.Equals(typeof(ClientPipelineOptions))))
                 ? field
                 : null;
         }
 
-        protected override MethodProvider? Visit(MethodProvider method)
+        protected override MethodProvider? VisitMethod(MethodProvider method)
         {
             if (method.Signature.ExplicitInterface is null && !IsEffectivelyPublic(method.Signature.Modifiers))
             {
@@ -98,7 +98,7 @@ private static bool IsCallingBaseCtor(ConstructorProvider constructor)
             return method;
         }
 
-        protected override PropertyProvider? Visit(PropertyProvider property)
+        protected override PropertyProvider? VisitProperty(PropertyProvider property)
         {
             if (!property.IsDiscriminator && !IsEffectivelyPublic(property.Modifiers))
             {

eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs

@@ -17,7 +17,7 @@ namespace Azure.Generator;
 /// </summary>
 [Export(typeof(CodeModelPlugin))]
 [ExportMetadata("PluginName", nameof(AzureClientPlugin))]
-public class AzureClientPlugin : ClientModelPlugin
+public class AzureClientPlugin : ScmCodeModelPlugin
 {
     private static AzureClientPlugin? _instance;
     internal static AzureClientPlugin Instance => _instance ?? throw new InvalidOperationException("AzureClientPlugin is not loaded.");
@@ -56,6 +56,7 @@ public override void Configure()
         if (IsAzureArm.Value)
         {
             AddVisitor(new RestClientVisitor());
+            AddVisitor(new ResourceVisitor());
         }
     }
 

eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureTypeFactory.cs

@@ -122,30 +122,6 @@ public override MethodBodyStatement SerializeJsonValue(Type valueType, ValueExpr
             return transformedClient is null ? null : base.CreateClientCore(transformedClient);
         }
 
-        /// <inheritdoc/>
-        protected override IReadOnlyList<TypeProvider> CreateSerializationsCore(InputType inputType, TypeProvider typeProvider)
-        {
-            if (inputType is InputModelType inputModel
-                && typeProvider is ModelProvider modelProvider
-                && AzureClientPlugin.Instance.OutputLibrary.IsResource(inputType.Name)
-                && inputModel.Usage.HasFlag(InputModelTypeUsage.Json))
-            {
-                return [new ResourceDataSerializationProvider(inputModel, modelProvider)];
-            }
-
-            return base.CreateSerializationsCore(inputType, typeProvider);
-        }
-
-        /// <inheritdoc/>
-        protected override ModelProvider? CreateModelCore(InputModelType model)
-        {
-            if (AzureClientPlugin.Instance.OutputLibrary.IsResource(model.Name))
-            {
-                return new ResourceDataProvider(model);
-            }
-            return base.CreateModelCore(model);
-        }
-
         /// <inheritdoc/>
         public override NewProjectScaffolding CreateNewProjectScaffolding()
         {

eng/packages/http-client-csharp/generator/Azure.Generator/src/NamespaceVisitor.cs

@@ -10,7 +10,7 @@ namespace Azure.Generator
 {
     internal class NamespaceVisitor : ScmLibraryVisitor
     {
-        protected override ModelProvider? Visit(InputModelType model, ModelProvider? type)
+        protected override ModelProvider? PreVisitModel(InputModelType model, ModelProvider? type)
         {
             if (type is not null)
             {
@@ -19,7 +19,7 @@ internal class NamespaceVisitor : ScmLibraryVisitor
             return type;
         }
 
-        protected override TypeProvider? Visit(InputEnumType enumType, TypeProvider? type)
+        protected override EnumProvider? PreVisitEnum(InputEnumType enumType, EnumProvider? type)
         {
             if (enumType.Usage.HasFlag(InputModelTypeUsage.ApiVersionEnum))
             {
@@ -33,7 +33,7 @@ internal class NamespaceVisitor : ScmLibraryVisitor
             return type;
         }
 
-        protected override TypeProvider? Visit(TypeProvider type)
+        protected override TypeProvider? VisitType(TypeProvider type)
         {
             if (type is EnumProvider && type.Name == "ServiceVersion")
             {
@@ -47,7 +47,7 @@ internal class NamespaceVisitor : ScmLibraryVisitor
             }
             else
             {
-                type.Type.Namespace = AzureClientPlugin.Instance.TypeFactory.RootNamespace;
+                type.Type.Update(@namespace: AzureClientPlugin.Instance.TypeFactory.PackageName);
             }
             return type;
         }
@@ -57,7 +57,7 @@ private static void UpdateModelsNamespace(TypeProvider type)
             // TODO: need to take consideration of model-namespace configuration
             // if model-namespace is false, set namespace to $"{AzureClientPlugin.Instance.TypeFactory.RootNamespace}"
             // if model-namespace is true, set namespace to $"{AzureClientPlugin.Instance.TypeFactory.RootNamespace}.Models"
-            type.Type.Namespace = AzureClientPlugin.Instance.TypeFactory.GetCleanNameSpace($"{AzureClientPlugin.Instance.TypeFactory.RootNamespace}.Models");
+            type.Type.Update(@namespace: AzureClientPlugin.Instance.TypeFactory.GetCleanNameSpace($"{AzureClientPlugin.Instance.TypeFactory.PackageName}.Models"));
         }
     }
 }

eng/packages/http-client-csharp/generator/Azure.Generator/src/Primitives/NewAzureProjectScaffolding.cs

@@ -23,10 +23,10 @@ protected override string GetSourceProjectFileContent()
         {
             var builder = new CSharpProjectWriter()
             {
-                Description = $"This is the {AzureClientPlugin.Instance.TypeFactory.RootNamespace} client library for developing .NET applications with rich experience.",
-                AssemblyTitle = $"SDK Code Generation {AzureClientPlugin.Instance.TypeFactory.RootNamespace}",
+                Description = $"This is the {AzureClientPlugin.Instance.TypeFactory.PackageName} client library for developing .NET applications with rich experience.",
+                AssemblyTitle = $"SDK Code Generation {AzureClientPlugin.Instance.TypeFactory.PackageName}",
                 Version = "1.0.0-beta.1",
-                PackageTags = AzureClientPlugin.Instance.TypeFactory.RootNamespace,
+                PackageTags = AzureClientPlugin.Instance.TypeFactory.PackageName,
                 GenerateDocumentationFile = true,
             };
 
@@ -36,7 +36,7 @@ protected override string GetSourceProjectFileContent()
             }
 
             int pathSegmentCount = GetPathSegmentCount();
-            if (AzureClientPlugin.Instance.InputLibrary.InputNamespace.Auth.ApiKey is not null)
+            if (AzureClientPlugin.Instance.InputLibrary.InputNamespace.Auth?.ApiKey is not null)
             {
                 builder.CompileIncludes.Add(new CSharpProjectWriter.CSProjCompileInclude(GetCompileInclude("AzureKeyCredentialPolicy.cs", pathSegmentCount), "Shared/Core"));
             }
@@ -133,36 +133,5 @@ private string GetCompileInclude(string fileName, int pathSegmentCount)
                 new("System.ClientModel"),
                 new("System.Text.Json")
             ];
-
-        /// <inheritdoc/>
-        protected override string GetSolutionFileContent()
-        {
-            string slnContent = @"Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.10.35201.131
-MinimumVisualStudioVersion = 10.0.40219.1
-Project(""{{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}}"") = ""{0}"", ""src\{0}.csproj"", ""{{28FF4005-4467-4E36-92E7-DEA27DEB1519}}""
-EndProject
-Global
-    GlobalSection(SolutionConfigurationPlatforms) = preSolution
-        Debug|Any CPU = Debug|Any CPU
-        Release|Any CPU = Release|Any CPU
-    EndGlobalSection
-    GlobalSection(ProjectConfigurationPlatforms) = postSolution
-        {{28FF4005-4467-4E36-92E7-DEA27DEB1519}}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-        {{28FF4005-4467-4E36-92E7-DEA27DEB1519}}.Debug|Any CPU.Build.0 = Debug|Any CPU
-        {{28FF4005-4467-4E36-92E7-DEA27DEB1519}}.Release|Any CPU.ActiveCfg = Release|Any CPU
-        {{28FF4005-4467-4E36-92E7-DEA27DEB1519}}.Release|Any CPU.Build.0 = Release|Any CPU
-    EndGlobalSection
-    GlobalSection(SolutionProperties) = preSolution
-        HideSolutionNode = FALSE
-    EndGlobalSection
-    GlobalSection(ExtensibilityGlobals) = postSolution
-        SolutionGuid = {{A97F4B90-2591-4689-B1F8-5F21FE6D6CAE}}
-    EndGlobalSection
-EndGlobal
-";
-            return string.Format(slnContent, AzureClientPlugin.Instance.TypeFactory.RootNamespace);
-        }
     }
 }